From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 459D3C001DE for ; Wed, 26 Jul 2023 06:12:33 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4CBA085813; Wed, 26 Jul 2023 08:12:29 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 56D0A8475C; Wed, 26 Jul 2023 08:12:26 +0200 (CEST) Received: from out30-131.freemail.mail.aliyun.com (out30-131.freemail.mail.aliyun.com [115.124.30.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5FDDE84660 for ; Wed, 26 Jul 2023 08:12:21 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=hsiangkao@linux.alibaba.com X-Alimail-AntiSpam: AC=PASS; BC=-1|-1; BR=01201311R151e4; CH=green; DM=||false|; DS=||; FP=0|-1|-1|-1|0|-1|-1|-1; HT=ay29a033018046056; MF=hsiangkao@linux.alibaba.com; NM=1; PH=DS; RN=5; SR=0; TI=SMTPD_---0VoFrh3._1690351935; Received: from 30.97.48.127(mailfrom:hsiangkao@linux.alibaba.com fp:SMTPD_---0VoFrh3._1690351935) by smtp.aliyun-inc.com; Wed, 26 Jul 2023 14:12:16 +0800 Message-ID: Date: Wed, 26 Jul 2023 14:12:15 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] fs/erofs: Remove an unnecessary assertion To: Yifan Zhao , u-boot@lists.denx.de, cfsworks@gmail.com, trini@konsulko.com Cc: jnhuang95@gmail.com References: <20230726045604.40958-1-zhaoyifan@sjtu.edu.cn> From: Gao Xiang In-Reply-To: <20230726045604.40958-1-zhaoyifan@sjtu.edu.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 2023/7/26 12:56, Yifan Zhao wrote: > In [1] Sam points out an assertion does not hold true for 32-bit > platforms, which only impacts Large File Support (LFS) API usage > in erofs-utils according to Xiang [2]. We don't think these APIs > are used in u-boot and this restriction could be safely removed. > > [1] https://lists.denx.de/pipermail/u-boot/2023-July/524679.html > [2] https://lists.denx.de/pipermail/u-boot/2023-July/524727.html > > Fixes: 3a21e92fc255 ("fs/erofs: Introduce new features including ztailpacking, fragments and dedupe") > Signed-off-by: Yifan Zhao Acked-by: Gao Xiang Thanks, Gao Xiang