Re: [PATCH] fbarray: support no-shconf

["Burakov, Anatoly" <anatoly.burakov@intel.com>]

On 22-May-18 9:38 PM, Thomas Monjalon wrote:
> 22/05/2018 18:35, Anatoly Burakov:
>> When using --no-shconf option, the expectation is that no multiprocess
>> will be supported as no shared files are created. However, fbarray
>> still creates some shared files that prevent multiple processes with
>> the same prefix from starting.
>>
>> Fix this by avoiding creating shared files whenever noshconf option is
>> specified. Since virtual areas we get from eal_get_virtual_area() are
>> read-only, remap them as writable.
>>
>> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
>> ---
>>
>> Notes:
>>      Without this patch, EAL flags autotest will fail when attempting
>>      to run a test with the same prefix as primary, and --no-shconf
>>      specified.
>>      
>>      Technically, we never spelled out any guarantees about --no-shconf
>>      mode, and we've been sloppy about it, so even though we don't create
>>      the shared config, we still create lots of other miscelaneous files.
>>      This patch only fixes issue with fbarray, as this affects intialization
>>      of different primaries with the same prefix (fbarrays are shared too),
>>      but does not address the other instances where we create "shared" files
>>      such as hugepage info.
> 
> Just for confirmation: this patch won't be integrated in 18.05.
> 

OK, no objection to that. I'll work on an expanded version for 18.08 
fixing all the inconsistencies then.

-- 
Thanks,
Anatoly