From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"Anthony PERARD" <anthony.perard@vates.tech>,
"Michal Orzel" <michal.orzel@amd.com>,
"Jan Beulich" <jbeulich@suse.com>,
"Julien Grall" <julien@xen.org>,
"Roger Pau Monné" <roger.pau@citrix.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Samuel Thibault" <samuel.thibault@ens-lyon.org>,
"Bertrand Marquis" <bertrand.marquis@arm.com>,
"Oleksii Kurochko" <oleksii.kurochko@gmail.com>,
"Community Manager" <community.manager@xenproject.org>
Subject: Re: [PATCH v5 for-4.20(?) 0/4] Add/enable stack protector
Date: Fri, 14 Feb 2025 00:38:03 +0000 [thread overview]
Message-ID: <b1af4f09-cdb4-48fa-bc17-b5bd724dc53e@citrix.com> (raw)
In-Reply-To: <87jz9tz7nn.fsf@epam.com>
On 14/02/2025 12:34 am, Volodymyr Babchuk wrote:
> Hi Andrew,
>
> Andrew Cooper <andrew.cooper3@citrix.com> writes:
>
>> On 13/02/2025 10:00 pm, Volodymyr Babchuk wrote:
>>> Volodymyr Babchuk (4):
>>> common: remove -fno-stack-protector from EMBEDDED_EXTRA_CFLAGS
>>> xen: common: add ability to enable stack protector
>>> xen: arm: enable stack protector feature
>>> CHANGELOG.md: Mention stack-protector feature
>> Given the last minute observation on v4, I ran this through GitlabCI
>> with STACK_PROTECTOR forced on.
>>
>> https://gitlab.com/xen-project/people/andyhhp/xen/-/pipelines/1670468808
>> is the full run.
> I noticed that you enabled both UBSAN and STACK_PROTECTOR for
> arm32. Have you tried to run arm32 test with UBSAN only?
No, but I'm also confident that the UBSAN failure is unrelated to
STACK_PROTECTOR.
It turns out it's very gnarly to fix.
~Andrew
prev parent reply other threads:[~2025-02-14 0:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-13 22:00 [PATCH v5 for-4.20(?) 0/4] Add/enable stack protector Volodymyr Babchuk
2025-02-13 22:00 ` [PATCH v5 1/4] common: remove -fno-stack-protector from EMBEDDED_EXTRA_CFLAGS Volodymyr Babchuk
2025-02-14 8:02 ` Jan Beulich
2025-02-13 22:00 ` [PATCH v5 4/4] CHANGELOG.md: Mention stack-protector feature Volodymyr Babchuk
2025-02-13 22:00 ` [PATCH v5 2/4] xen: common: add ability to enable stack protector Volodymyr Babchuk
2025-02-14 8:05 ` Jan Beulich
2025-02-15 9:38 ` Julien Grall
2025-02-17 0:59 ` Volodymyr Babchuk
2025-02-13 22:00 ` [PATCH v5 3/4] xen: arm: enable stack protector feature Volodymyr Babchuk
2025-02-15 9:46 ` Julien Grall
2025-02-13 23:18 ` [PATCH v5 for-4.20(?) 0/4] Add/enable stack protector Andrew Cooper
2025-02-14 0:34 ` Volodymyr Babchuk
2025-02-14 0:38 ` Andrew Cooper [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1af4f09-cdb4-48fa-bc17-b5bd724dc53e@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=anthony.perard@vates.tech \
--cc=bertrand.marquis@arm.com \
--cc=community.manager@xenproject.org \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=michal.orzel@amd.com \
--cc=oleksii.kurochko@gmail.com \
--cc=roger.pau@citrix.com \
--cc=samuel.thibault@ens-lyon.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.