Re: [PATCH v5 00/11] drm/crtc: Convert all drivers to atomic_create_state and remove reset

[Thomas Zimmermann <tzimmermann@suse.de>]

Hi

Am 15.09.26 um 16:24 schrieb Maxime Ripard:
> This is a follow-up to the plane reset removal series, and part of a
> larger effort to remove the reset hook from all KMS objects.
>
> The CRTC reset hook is overloaded: it is called both at probe time to
> create the initial software state and during suspend/resume to reset
> hardware and software state. These two roles have different
> requirements, and the reset hook is not fallible, making error
> handling difficult for the initial state allocation path.
>
> While reset has the semantics to reset both the software and hardware
> state, the vast majority of implementations and all the helpers only
> reset the software state, making them equivalent to
> atomic_create_state in practice. The atomic_create_state hook makes
> this explicit: it only allocates and initializes a pristine state
> without any side effect, and returns the state pointer or an ERR_PTR
> on failure.
>
> This series converts all CRTC drivers tree-wide from the reset hook to
> atomic_create_state, then removes the reset hook from struct
> drm_crtc_funcs entirely. Two drivers (tilcdc and loongson) had actual
> hardware reset logic mixed into their reset hook; those are moved to
> CRTC creation instead. The conversions were done using a combination of
> Coccinelle semantic patches and manual adjustments.
>
> Signed-off-by: Maxime Ripard <mripard@kernel.org>

It might be my mail client but the formatting in patch 5 looks off. 
Besides that, for the series:

Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>

Best regards
Thomas

> ---
> Changes in v5:
> - Convert more drivers recently posted
> - Link to v4: https://lore.kernel.org/r/20260911-drm-no-more-crtc-reset-v4-0-662e0ccd815c@kernel.org
>
> Changes in v4:
> - Convert gm12u320 too
> - Link to v3: https://lore.kernel.org/r/20260904-drm-no-more-crtc-reset-v3-0-27d9891512ce@kernel.org
>
> Changes in v3:
> - Test if crtc->helper_private is set before accessing it, and call the
>    temp variable to store it helper_funcs
> - Rework outdated commit logs
> - Fix error path for amdgpu_dm_crtc_init
> - Fix new amdgpu tests doc
> - Rebased on drm-misc-next-2026-09-03
> - Link to v2: https://lore.kernel.org/r/20260831-drm-no-more-crtc-reset-v2-0-4500d49a337f@kernel.org
>
> Changes in v2:
> - Fix indentation in logicvc
> - Fix hardware reset at probe and suspend for loonsoon and tilcldc
> - Fix state creation for amdgpu
> - Rebase on current drm-misc-next
> - Fix commit message for st7920
> - Fix merge conflict for mediatek
> - Link to v1: https://lore.kernel.org/r/20260821-drm-no-more-crtc-reset-v1-0-fb793475c05a@kernel.org
>
> ---
> Maxime Ripard (11):
>        drm/arcgpu: Switch to drm_atomic_helper_crtc_create_state
>        drm/aspeed: Switch to drm_atomic_helper_crtc_create_state
>        drm/gm12u320: Switch to drm_atomic_helper_crtc_create_state
>        drm/mcde: Switch to drm_atomic_helper_crtc_create_state
>        drm/pl111: Switch to drm_atomic_helper_crtc_create_state
>        drm/repaper: Switch to drm_atomic_helper_crtc_create_state
>        drm/tve200: Switch to drm_atomic_helper_crtc_create_state
>        drm/xen: Switch to drm_atomic_helper_crtc_create_state
>        drm/atomic-helper: Remove drm_atomic_helper_crtc_reset
>        drm/atomic-helper: Remove __drm_atomic_helper_crtc_reset
>        drm/crtc: Remove reset
>
>   drivers/gpu/drm/aspeed/aspeed_gfx_crtc.c  |  2 +-
>   drivers/gpu/drm/drm_atomic_state_helper.c | 45 -------------------------------
>   drivers/gpu/drm/drm_mode_config.c         |  4 +--
>   drivers/gpu/drm/mcde/mcde_display.c       |  2 +-
>   drivers/gpu/drm/pl111/pl111_display.c     |  2 +-
>   drivers/gpu/drm/tiny/arcpgu.c             |  2 +-
>   drivers/gpu/drm/tiny/gm12u320.c           |  2 +-
>   drivers/gpu/drm/tiny/repaper.c            |  2 +-
>   drivers/gpu/drm/tve200/tve200_display.c   |  2 +-
>   drivers/gpu/drm/xen/xen_drm_front_kms.c   |  2 +-
>   include/drm/drm_atomic_state_helper.h     |  3 ---
>   include/drm/drm_crtc.h                    | 12 ---------
>   12 files changed, 9 insertions(+), 71 deletions(-)
> ---
> base-commit: 17c6b88e85ffe5de5720004ae8c2176d52944aca
> change-id: 20260709-drm-no-more-crtc-reset-14a4d5bc8d41
>
> Best regards,

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, (HRB 36809, AG Nürnberg)