From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kip Macy Subject: New patch was Re: follow-up to guest debug support patches Date: Sat, 12 Mar 2005 13:22:48 -0800 Message-ID: References: Reply-To: Kip Macy Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit In-Reply-To: Sender: xen-devel-admin@lists.sourceforge.net Errors-To: xen-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: Ian Pratt Cc: xen-devel@lists.sourceforge.net, Keir Fraser , Ian.Pratt@cl.cam.ac.uk, Christian Limpach , ian.pratt@cl.cam.ac.uk List-Id: xen-devel@lists.xenproject.org Updated single patch for inspection is at: http://www.fsmware.com/xenofreebsd/gdb/050312/patch > patch1: > It seems to be missing a way to undo the foreign mappings on exit? No change. > > The memcpy copying the user_ctxt is now after if gets used (addtl. > VMX checks) Looks like he wasn't too careful when forward > porting -- scary :-( Maybe the VMX check should just look at the > context passed in. Fixed. FYI the callers don't correctly handle the EINVAL returned there. > Not sure why he's skipping setting DONEFPUINIT, kernel mode and clearing > IOPL bits though. Fixed. > Doesn't the change in traps.c break in-guest debugger support? It seems > to always pause the domain if it is in kernel, an in-guest debugger > which has set a breakpoint in the kernel will never get the int3. I > think > this needs some kind of flag to enable/disable this behaviour. Long term this will be a guest boot-time / run-time settable option. Right now, for the sake of expediency, it is xen compile-time option - see Rules.mk. > I think the order in arch_final_setup_guest should be: > > - check cs/ss in passed in cpu_ctxt (before doing anything) > - update DONEFPUINIT and TF_kernel_mode flags > - copy user_ctxt > - copy fpu ctxt > - clear iopl > - exit if updating (EDF_DONEINIT) Fixed. Let me know if there is anything else I missed. Thanks. -Kip ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click