From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kip Macy Subject: Re: separate domain info and vcpu context Date: Sun, 8 May 2005 11:09:41 -0700 Message-ID: References: Reply-To: Kip Macy Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Pratt Cc: xen-devel List-Id: xen-devel@lists.xenproject.org > I would like both calls to return the number of VCPUs in use, but we > still want the 'give me VCPU x or the next active one if it doesn't > exist' enumeration scheme since VCPUs can potentially be sparse. Go for > it! >=20 Why should GETDOMAINCONTEXT also return the number of active VCPUs? That seems redundant. It would make more sense to me for it to take exec_domain as an in/out variable. The value coming in would be the index into the active CPUs and the out value would be the actual vcpu number. So if you were running with 4 vcpus but only the 4th vcpu was active, the caller would set exec_domain to 0 and then xen would set exec_domain to 3. I'd like to keep the number of iterations to 1, so just to clarify - in GETDOMAININFO, exec_domain will be changed to out variable n_active_vcpus, ctxt will be removed. - GETDOMAINCONTEXT will have two fields, (u16)exec_domain described above and (vcpu_guest_context_t *)ctxt Thanks. =20 -Kip