All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Khem Raj" <raj.khem@gmail.com>
To: Denys Dmytriyenko <denis@denix.org>,
	Mark Hatle <mark.hatle@kernel.crashing.org>
Cc: yocto@lists.yoctoproject.org
Subject: Re: [yocto] [PATCH] gcc-cross-canadian: Enable wildcard expansion support
Date: Mon, 2 Mar 2020 15:03:17 -0800	[thread overview]
Message-ID: <b1faecfd-b210-abbd-ff76-352495aa0e62@gmail.com> (raw)
In-Reply-To: <20200302223038.GE1578@denix.org>



On 3/2/20 2:30 PM, Denys Dmytriyenko wrote:
> On Mon, Mar 02, 2020 at 04:27:05PM -0600, Mark Hatle wrote:
>>
>>
>> On 3/2/20 12:42 PM, Khem Raj wrote:
>>>
>>>
>>> On 3/2/20 9:39 AM, Mark Hatle wrote:
>>>> In gcc 8, the behavior of GCC changed and expansion of wild cards to calls
>>>> of gcc were disabled by default.  This behavior may be required by some
>>>> (poorly written) makefiles.
>>>>
>>>> This will allow someone to do:
>>>>
>>>> gcc *.c -o myoutput
>>>>
>>>> Signed-off-by: Mark Hatle <mark.hatle@kernel.crashing.org>
>>>> ---
>>>>    recipes-devtools/gcc/gcc-cross-canadian_%.bbappend | 2 +-
>>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/recipes-devtools/gcc/gcc-cross-canadian_%.bbappend b/recipes-devtools/gcc/gcc-cross-canadian_%.bbappend
>>>> index 9c0d828..e0463c6 100644
>>>> --- a/recipes-devtools/gcc/gcc-cross-canadian_%.bbappend
>>>> +++ b/recipes-devtools/gcc/gcc-cross-canadian_%.bbappend
>>>> @@ -1,5 +1,5 @@
>>>>    INSANE_SKIP_${PN}_append_sdkmingw32 = " staticdev"
>>>> -EXTRA_OECONF_append_sdkmingw32 = " --disable-nls"
>>>> +EXTRA_OECONF_append_sdkmingw32 = " --disable-nls --enable-mingw-wildcard"
>>>
>>> this change is fine. is this the only place we need it ?
>>
>> Yes, it doesn't do anything if the generated toolchain isn't mingw.. and AFAIK,
> 
> Where does this bbappend go? Should this patch be designated to mingw layer?
> 

its using an override, so it wont be effective elsewhere, perhaps 
oe-core is better place for it.

> 
>> we're only build cross-canadian there.
>>
>> (binutils and others don't appear to have this option, unless I just missed it.)
>>
>> --Mark
>>
>>>>    LDFLAGS_append_sdkmingw32 = " -Wl,-static"
>>>>    EXEEXT_sdkmingw32 = ".exe"
>>>>    ELFUTILS_sdkmingw32 = ""
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
> 
>> 
> 

  reply	other threads:[~2020-03-02 23:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-02 17:39 [PATCH] gcc-cross-canadian: Enable wildcard expansion support Mark Hatle
2020-03-02 18:15 ` [yocto] " akuster
2020-03-02 18:22   ` Mark Hatle
2020-03-02 18:42 ` Khem Raj
2020-03-02 22:27   ` Mark Hatle
2020-03-02 22:30     ` Denys Dmytriyenko
2020-03-02 23:03       ` Khem Raj [this message]
2020-03-02 23:38         ` Joshua Watt
2020-03-02 23:56           ` Khem Raj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b1faecfd-b210-abbd-ff76-352495aa0e62@gmail.com \
    --to=raj.khem@gmail.com \
    --cc=denis@denix.org \
    --cc=mark.hatle@kernel.crashing.org \
    --cc=yocto@lists.yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.