From: Nuno Das Neves <nunodasneves@linux.microsoft.com>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: "K. Y. Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
Praveen K Paladugu <prapal@linux.microsoft.com>,
Roman Kisel <romank@linux.microsoft.com>,
Jinank Jain <jinankjain@microsoft.com>,
Mukesh Rathor <mrathor@linux.microsoft.com>,
linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH next] Drivers: hv: mshv: Fix uninitialize variable in mshv_ioctl_passthru_hvcall()
Date: Fri, 21 Mar 2025 09:49:53 -0700 [thread overview]
Message-ID: <b1fe0df0-efee-4940-9865-8bcabcd5809e@linux.microsoft.com> (raw)
In-Reply-To: <97036225-597d-4a2d-8f51-7310757b9929@stanley.mountain>
On 3/21/2025 7:35 AM, Dan Carpenter wrote:
> The "ret" variable could be uninitialized on the success path depending
> on if "is_async" is true of false. Initialized it to zero.
>
> Fixes: f5288d14069b ("Drivers: hv: Introduce mshv_root module to expose /dev/mshv to VMMs")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> drivers/hv/mshv_root_main.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hv/mshv_root_main.c b/drivers/hv/mshv_root_main.c
> index 29fa6d5a3994..b94d8fe0f691 100644
> --- a/drivers/hv/mshv_root_main.c
> +++ b/drivers/hv/mshv_root_main.c
> @@ -151,13 +151,14 @@ static int mshv_ioctl_passthru_hvcall(struct mshv_partition *partition,
> void __user *user_args)
> {
> u64 status;
> - int ret, i;
> bool is_async;
> struct mshv_root_hvcall args;
> struct page *page;
> unsigned int pages_order;
> void *input_pg = NULL;
> void *output_pg = NULL;
> + int ret = 0;
> + int i;
>
> if (copy_from_user(&args, user_args, sizeof(args)))
> return -EFAULT;
Thanks Dan, I already sent a fixup for this:
https://lore.kernel.org/linux-hyperv/1742492693-21960-1-git-send-email-nunodasneves@linux.microsoft.com/
prev parent reply other threads:[~2025-03-21 16:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-21 14:35 [PATCH next] Drivers: hv: mshv: Fix uninitialize variable in mshv_ioctl_passthru_hvcall() Dan Carpenter
2025-03-21 16:49 ` Nuno Das Neves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1fe0df0-efee-4940-9865-8bcabcd5809e@linux.microsoft.com \
--to=nunodasneves@linux.microsoft.com \
--cc=dan.carpenter@linaro.org \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=jinankjain@microsoft.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mrathor@linux.microsoft.com \
--cc=prapal@linux.microsoft.com \
--cc=romank@linux.microsoft.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.