From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: BALATON Zoltan <balaton@eik.bme.hu>, qemu-devel@nongnu.org
Subject: Re: [PATCH 3/4] hw/nvram/eeprom_at24c: Remove memset after g_malloc0
Date: Mon, 3 Mar 2025 12:20:27 +0100 [thread overview]
Message-ID: <b2049037-4324-4e8e-8c86-059b25995740@linaro.org> (raw)
In-Reply-To: <ff281851e6d824ecd01b8b5cd955328dae1515a0.1740839457.git.balaton@eik.bme.hu>
On 1/3/25 15:35, BALATON Zoltan wrote:
> Calling memset to zero memory is not needed after g_malloc0 which
> already clears memory. These used to be in separate functions but
> after some patches the memset ended up after g_malloc0 and thus can be
> dropped.
>
> Fixes: 4f2c6448c3 (hw/nvram/eeprom_at24c: Make reset behavior more like hardware)
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
> hw/nvram/eeprom_at24c.c | 1 -
> 1 file changed, 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2025-03-03 11:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-01 14:35 [PATCH 0/4] Misc eeprom_at24c clean ups BALATON Zoltan
2025-03-01 14:35 ` [PATCH 1/4] hw/nvram/eeprom_at24c: Use OBJECT_DECLARE_SIMPLE_TYPE BALATON Zoltan
2025-03-03 11:19 ` Philippe Mathieu-Daudé
2025-03-01 14:35 ` [PATCH 2/4] hw/nvram/eeprom_at24c: Remove ERR macro that calls fprintf to stderr BALATON Zoltan
2025-03-03 11:24 ` Philippe Mathieu-Daudé
2025-03-01 14:35 ` [PATCH 3/4] hw/nvram/eeprom_at24c: Remove memset after g_malloc0 BALATON Zoltan
2025-03-03 11:20 ` Philippe Mathieu-Daudé [this message]
2025-03-01 14:35 ` [PATCH 4/4] hw/nvram/eeprom_at24c: Reorganise init to avoid overwriting values BALATON Zoltan
2025-03-03 11:23 ` Philippe Mathieu-Daudé
2025-03-03 12:32 ` BALATON Zoltan
2025-03-03 12:40 ` Philippe Mathieu-Daudé
2025-03-03 12:43 ` Philippe Mathieu-Daudé
2025-03-03 12:43 ` [PATCH 0/4] Misc eeprom_at24c clean ups Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2049037-4324-4e8e-8c86-059b25995740@linaro.org \
--to=philmd@linaro.org \
--cc=balaton@eik.bme.hu \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.