From: Jan Beulich <jbeulich@suse.com>
To: Juergen Gross <jgross@suse.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>,
xen-devel@lists.xenproject.org, x86@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] x86: fix setup of brk area
Date: Thu, 23 Jun 2022 10:09:09 +0200 [thread overview]
Message-ID: <b210d5c7-26cc-df6f-fa37-56fe04c8d0dc@suse.com> (raw)
In-Reply-To: <20220622161048.4483-3-jgross@suse.com>
On 22.06.2022 18:10, Juergen Gross wrote:
> Commit e32683c6f7d2 ("x86/mm: Fix RESERVE_BRK() for older binutils")
> put the brk area into the .bss segment, causing it not to be cleared
> initially.
This reads contradictively: If the area was put in .bss, it would be
cleared. Thing is it is put in .bss..brk in the object files, while
the linker script puts it in .brk (i.e. outside of .bss).
> As the brk area is used to allocate early page tables, these
> might contain garbage in not explicitly written entries.
I'm surprised this lack of zero-initialization didn't cause any issue
outside of PV Xen. Unless of course there never was the intention for
users of the facility to assume blank pages coming from there, in
which case Xen's use for early page tables would have been wrong (in
not explicitly zeroing the space first).
Jan
next prev parent reply other threads:[~2022-06-23 8:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-22 16:10 [PATCH 0/2] x86: fix brk area initialization Juergen Gross
2022-06-22 16:10 ` [PATCH 1/2] x86/xen: use clear_bss() for Xen PV guests Juergen Gross
2022-06-23 7:59 ` Jan Beulich
2022-06-22 16:10 ` [PATCH 2/2] x86: fix setup of brk area Juergen Gross
2022-06-23 8:09 ` Jan Beulich [this message]
2022-06-23 8:14 ` Juergen Gross
2022-06-23 8:50 ` Jan Beulich
2022-06-23 9:03 ` Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b210d5c7-26cc-df6f-fa37-56fe04c8d0dc@suse.com \
--to=jbeulich@suse.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.