From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 008D4C4361B for ; Mon, 14 Dec 2020 13:18:08 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9781220643 for ; Mon, 14 Dec 2020 13:18:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9781220643 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 22D4D6E157; Mon, 14 Dec 2020 13:18:07 +0000 (UTC) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 47AE56E157; Mon, 14 Dec 2020 13:18:06 +0000 (UTC) IronPort-SDR: KFb3uwr5BdpM2CUXSnTxoQ7RlU9AsJ/lHwPbHmRHD6XG/TbdlmC2X6OMBfunwsQUepvR4X34/P mGcJkVIhOgQQ== X-IronPort-AV: E=McAfee;i="6000,8403,9834"; a="161753572" X-IronPort-AV: E=Sophos;i="5.78,418,1599548400"; d="scan'208";a="161753572" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2020 05:18:05 -0800 IronPort-SDR: upzBDfuoLSVDJRaf/pFVdy9J3Rsr3gSu93DSaSkpJ+OzQSLQLuPvTxGqOF4z2Pq7hpO7+zbNkw gljHR9lWj5RQ== X-IronPort-AV: E=Sophos;i="5.78,418,1599548400"; d="scan'208";a="381654103" Received: from aknautiy-mobl.gar.corp.intel.com (HELO [10.213.98.131]) ([10.213.98.131]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2020 05:18:02 -0800 To: "Shankar, Uma" , "intel-gfx@lists.freedesktop.org" References: <20201208075145.17389-1-ankit.k.nautiyal@intel.com> <20201208075145.17389-8-ankit.k.nautiyal@intel.com> <84fd6863339d4737a67decd2a9787a23@intel.com> From: "Nautiyal, Ankit K" Message-ID: Date: Mon, 14 Dec 2020 18:47:59 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: <84fd6863339d4737a67decd2a9787a23@intel.com> Content-Language: en-US Subject: Re: [Intel-gfx] [PATCH v4 07/16] drm/dp_helper: Add helpers to configure PCONs RGB-YCbCr Conversion X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "airlied@linux.ie" , "dri-devel@lists.freedesktop.org" Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi Uma Shankar, Thanks for the comments and suggestions. Please find my response inline. On 12/13/2020 12:40 PM, Shankar, Uma wrote: > >> -----Original Message----- >> From: Nautiyal, Ankit K >> Sent: Tuesday, December 8, 2020 1:22 PM >> To: intel-gfx@lists.freedesktop.org >> Cc: dri-devel@lists.freedesktop.org; Shankar, Uma ; >> airlied@linux.ie; jani.nikula@linux.intel.com; ville.syrjala@linux.intel.com; >> Kulkarni, Vandita ; Sharma, Swati2 >> >> Subject: [PATCH v4 07/16] drm/dp_helper: Add helpers to configure PCONs RGB- >> YCbCr Conversion >> >> DP Specification for DP2.0 to HDMI2.1 Pcon specifies support for conversion of >> colorspace from RGB to YCbCr. >> https://groups.vesa.org/wg/DP/document/previewpdf/15651 >> >> This patch adds the relavant registers and helper functions to get the capability >> and set the color conversion bits for rgb->ycbcr conversion through PCON. >> >> Signed-off-by: Ankit Nautiyal >> --- >> drivers/gpu/drm/drm_dp_helper.c | 59 +++++++++++++++++++++++++++++++++ >> include/drm/drm_dp_helper.h | 10 +++++- >> 2 files changed, 68 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/drm_dp_helper.c >> b/drivers/gpu/drm/drm_dp_helper.c index d0626f57f99c..344662d5c295 100644 >> --- a/drivers/gpu/drm/drm_dp_helper.c >> +++ b/drivers/gpu/drm/drm_dp_helper.c >> @@ -949,6 +949,35 @@ bool >> drm_dp_downstream_444_to_420_conversion(const u8 >> dpcd[DP_RECEIVER_CAP_SIZE] } >> EXPORT_SYMBOL(drm_dp_downstream_444_to_420_conversion); >> >> +/** >> + * drm_dp_downstream_rgb_to_ycbcr_conversion() - determine downstream >> facing port >> + * RGB->YCbCr conversion capability >> + * @dpcd: DisplayPort configuration data >> + * @port_cap: downstream facing port capabilities >> + * >> + * Returns: whether the downstream facing port can convert RGB->YCbCr >> +*/ bool drm_dp_downstream_rgb_to_ycbcr_conversion(const u8 >> +dpcd[DP_RECEIVER_CAP_SIZE], >> + const u8 port_cap[4]) >> +{ >> + if (!drm_dp_is_branch(dpcd)) >> + return false; >> + >> + if (dpcd[DP_DPCD_REV] < 0x13) >> + return false; >> + >> + switch (port_cap[0] & DP_DS_PORT_TYPE_MASK) { >> + case DP_DS_PORT_TYPE_HDMI: >> + if ((dpcd[DP_DOWNSTREAMPORT_PRESENT] & >> DP_DETAILED_CAP_INFO_AVAILABLE) == 0) >> + return false; >> + >> + return port_cap[3] & DP_DS_HDMI_BT601_RGB_YCBCR_CONV; > I guess there are other conversions also possible, like BT709 and 2020. Update those > as well here. Yes you are right. I will modify the function to take as input colorspace, also and the function will be returning true, if the rgb->ycbcr conversion for the given colorspace is supported. > >> + default: >> + return false; >> + } >> +} >> +EXPORT_SYMBOL(drm_dp_downstream_rgb_to_ycbcr_conversion); >> + >> /** >> * drm_dp_downstream_mode() - return a mode for downstream facing port >> * @dev: DRM device >> @@ -3140,3 +3169,33 @@ int drm_dp_pcon_pps_override_param(struct >> drm_dp_aux *aux, u8 pps_param[6]) >> return 0; >> } >> EXPORT_SYMBOL(drm_dp_pcon_pps_override_param); >> + >> +/* >> + * drm_dp_pcon_convert_rgb_to_ycbcr() - Configure the PCon to convert >> +RGB to Ycbcr >> + * @aux: displayPort AUX channel >> + * @color_spc: Color space conversion type >> + * >> + * Returns 0 on success, else returns negative error code. >> + */ >> +int drm_dp_pcon_convert_rgb_to_ycbcr(struct drm_dp_aux *aux, u8 >> +color_spc) { >> + int ret; >> + u8 buf; >> + >> + if (color_spc != DP_CONVERSION_BT601_RGB_YCBCR_ENABLE || >> + color_spc != DP_CONVERSION_BT709_RGB_YCBCR_ENABLE || >> + color_spc != DP_CONVERSION_BT2020_RGB_YCBCR_ENABLE) >> + return -EINVAL; > Yeah this is wrong, fix it. Agreed. Will fix this in next version of the patch. > >> + >> + ret = drm_dp_dpcd_readb(aux, DP_PROTOCOL_CONVERTER_CONTROL_2, >> &buf); >> + if (ret < 0) >> + return ret; >> + >> + buf |= color_spc; >> + ret = drm_dp_dpcd_writeb(aux, >> DP_PROTOCOL_CONVERTER_CONTROL_2, buf); >> + if (ret < 0) >> + return ret; >> + >> + return 0; >> +} >> +EXPORT_SYMBOL(drm_dp_pcon_convert_rgb_to_ycbcr); >> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h index >> 347b4e1a55b4..1b3d54ed7a78 100644 >> --- a/include/drm/drm_dp_helper.h >> +++ b/include/drm/drm_dp_helper.h >> @@ -431,6 +431,9 @@ struct drm_device; >> # define DP_DS_HDMI_YCBCR420_PASS_THROUGH (1 << 2) >> # define DP_DS_HDMI_YCBCR444_TO_422_CONV (1 << 3) >> # define DP_DS_HDMI_YCBCR444_TO_420_CONV (1 << 4) >> +# define DP_DS_HDMI_BT601_RGB_YCBCR_CONV (1 << 5) >> +# define DP_DS_HDMI_BT709_RGB_YCBCR_CONV (1 << 6) >> +# define DP_DS_HDMI_BT2020_RGB_YCBCR_CONV (1 << 7) > I think it would be good to mention the location in spec (section or table), > will make it easier to understand/review by directly going to relevant sections in spec. This is still Draft 1 of the spec: VESA DP-to-HDMI PCON Specification Standalone Document. Link in the commit message. I will mention the current Section and Table no. nevertheless in the next version of the patch. Thanks & Regards, Ankit >> #define DP_MAX_DOWNSTREAM_PORTS 0x10 >> >> @@ -1217,7 +1220,9 @@ struct drm_device; >> # define DP_PCON_ENC_PPS_OVERRIDE_DISABLED 0 >> # define DP_PCON_ENC_PPS_OVERRIDE_EN_PARAMS 1 >> # define DP_PCON_ENC_PPS_OVERRIDE_EN_BUFFER 2 >> - >> +# define DP_CONVERSION_BT601_RGB_YCBCR_ENABLE (1 << 4) # define >> +DP_CONVERSION_BT709_RGB_YCBCR_ENABLE (1 << 5) # define >> +DP_CONVERSION_BT2020_RGB_YCBCR_ENABLE (1 << 6) >> >> /* PCON Downstream HDMI ERROR Status per Lane */ >> #define DP_PCON_HDMI_ERROR_STATUS_LN0 0x3037 >> @@ -2178,5 +2183,8 @@ int drm_dp_pcon_dsc_bpp_incr(const u8 >> pcon_dsc_dpcd[DP_PCON_DSC_ENCODER_CAP_SIZE >> int drm_dp_pcon_pps_default(struct drm_dp_aux *aux); int >> drm_dp_pcon_pps_override_buf(struct drm_dp_aux *aux, u8 pps_buf[128]); int >> drm_dp_pcon_pps_override_param(struct drm_dp_aux *aux, u8 pps_param[6]); >> +bool drm_dp_downstream_rgb_to_ycbcr_conversion(const u8 >> dpcd[DP_RECEIVER_CAP_SIZE], >> + const u8 port_cap[4]); >> +int drm_dp_pcon_convert_rgb_to_ycbcr(struct drm_dp_aux *aux, u8 >> +color_spc); >> >> #endif /* _DRM_DP_HELPER_H_ */ >> -- >> 2.17.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93D3AC4361B for ; Mon, 14 Dec 2020 13:18:10 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3E1D720643 for ; Mon, 14 Dec 2020 13:18:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3E1D720643 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B5C006E1A4; Mon, 14 Dec 2020 13:18:07 +0000 (UTC) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 47AE56E157; Mon, 14 Dec 2020 13:18:06 +0000 (UTC) IronPort-SDR: KFb3uwr5BdpM2CUXSnTxoQ7RlU9AsJ/lHwPbHmRHD6XG/TbdlmC2X6OMBfunwsQUepvR4X34/P mGcJkVIhOgQQ== X-IronPort-AV: E=McAfee;i="6000,8403,9834"; a="161753572" X-IronPort-AV: E=Sophos;i="5.78,418,1599548400"; d="scan'208";a="161753572" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2020 05:18:05 -0800 IronPort-SDR: upzBDfuoLSVDJRaf/pFVdy9J3Rsr3gSu93DSaSkpJ+OzQSLQLuPvTxGqOF4z2Pq7hpO7+zbNkw gljHR9lWj5RQ== X-IronPort-AV: E=Sophos;i="5.78,418,1599548400"; d="scan'208";a="381654103" Received: from aknautiy-mobl.gar.corp.intel.com (HELO [10.213.98.131]) ([10.213.98.131]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2020 05:18:02 -0800 Subject: Re: [PATCH v4 07/16] drm/dp_helper: Add helpers to configure PCONs RGB-YCbCr Conversion To: "Shankar, Uma" , "intel-gfx@lists.freedesktop.org" References: <20201208075145.17389-1-ankit.k.nautiyal@intel.com> <20201208075145.17389-8-ankit.k.nautiyal@intel.com> <84fd6863339d4737a67decd2a9787a23@intel.com> From: "Nautiyal, Ankit K" Message-ID: Date: Mon, 14 Dec 2020 18:47:59 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: <84fd6863339d4737a67decd2a9787a23@intel.com> Content-Language: en-US X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "airlied@linux.ie" , "dri-devel@lists.freedesktop.org" , "Sharma, Swati2" , "Kulkarni, Vandita" Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Uma Shankar, Thanks for the comments and suggestions. Please find my response inline. On 12/13/2020 12:40 PM, Shankar, Uma wrote: > >> -----Original Message----- >> From: Nautiyal, Ankit K >> Sent: Tuesday, December 8, 2020 1:22 PM >> To: intel-gfx@lists.freedesktop.org >> Cc: dri-devel@lists.freedesktop.org; Shankar, Uma ; >> airlied@linux.ie; jani.nikula@linux.intel.com; ville.syrjala@linux.intel.com; >> Kulkarni, Vandita ; Sharma, Swati2 >> >> Subject: [PATCH v4 07/16] drm/dp_helper: Add helpers to configure PCONs RGB- >> YCbCr Conversion >> >> DP Specification for DP2.0 to HDMI2.1 Pcon specifies support for conversion of >> colorspace from RGB to YCbCr. >> https://groups.vesa.org/wg/DP/document/previewpdf/15651 >> >> This patch adds the relavant registers and helper functions to get the capability >> and set the color conversion bits for rgb->ycbcr conversion through PCON. >> >> Signed-off-by: Ankit Nautiyal >> --- >> drivers/gpu/drm/drm_dp_helper.c | 59 +++++++++++++++++++++++++++++++++ >> include/drm/drm_dp_helper.h | 10 +++++- >> 2 files changed, 68 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/drm_dp_helper.c >> b/drivers/gpu/drm/drm_dp_helper.c index d0626f57f99c..344662d5c295 100644 >> --- a/drivers/gpu/drm/drm_dp_helper.c >> +++ b/drivers/gpu/drm/drm_dp_helper.c >> @@ -949,6 +949,35 @@ bool >> drm_dp_downstream_444_to_420_conversion(const u8 >> dpcd[DP_RECEIVER_CAP_SIZE] } >> EXPORT_SYMBOL(drm_dp_downstream_444_to_420_conversion); >> >> +/** >> + * drm_dp_downstream_rgb_to_ycbcr_conversion() - determine downstream >> facing port >> + * RGB->YCbCr conversion capability >> + * @dpcd: DisplayPort configuration data >> + * @port_cap: downstream facing port capabilities >> + * >> + * Returns: whether the downstream facing port can convert RGB->YCbCr >> +*/ bool drm_dp_downstream_rgb_to_ycbcr_conversion(const u8 >> +dpcd[DP_RECEIVER_CAP_SIZE], >> + const u8 port_cap[4]) >> +{ >> + if (!drm_dp_is_branch(dpcd)) >> + return false; >> + >> + if (dpcd[DP_DPCD_REV] < 0x13) >> + return false; >> + >> + switch (port_cap[0] & DP_DS_PORT_TYPE_MASK) { >> + case DP_DS_PORT_TYPE_HDMI: >> + if ((dpcd[DP_DOWNSTREAMPORT_PRESENT] & >> DP_DETAILED_CAP_INFO_AVAILABLE) == 0) >> + return false; >> + >> + return port_cap[3] & DP_DS_HDMI_BT601_RGB_YCBCR_CONV; > I guess there are other conversions also possible, like BT709 and 2020. Update those > as well here. Yes you are right. I will modify the function to take as input colorspace, also and the function will be returning true, if the rgb->ycbcr conversion for the given colorspace is supported. > >> + default: >> + return false; >> + } >> +} >> +EXPORT_SYMBOL(drm_dp_downstream_rgb_to_ycbcr_conversion); >> + >> /** >> * drm_dp_downstream_mode() - return a mode for downstream facing port >> * @dev: DRM device >> @@ -3140,3 +3169,33 @@ int drm_dp_pcon_pps_override_param(struct >> drm_dp_aux *aux, u8 pps_param[6]) >> return 0; >> } >> EXPORT_SYMBOL(drm_dp_pcon_pps_override_param); >> + >> +/* >> + * drm_dp_pcon_convert_rgb_to_ycbcr() - Configure the PCon to convert >> +RGB to Ycbcr >> + * @aux: displayPort AUX channel >> + * @color_spc: Color space conversion type >> + * >> + * Returns 0 on success, else returns negative error code. >> + */ >> +int drm_dp_pcon_convert_rgb_to_ycbcr(struct drm_dp_aux *aux, u8 >> +color_spc) { >> + int ret; >> + u8 buf; >> + >> + if (color_spc != DP_CONVERSION_BT601_RGB_YCBCR_ENABLE || >> + color_spc != DP_CONVERSION_BT709_RGB_YCBCR_ENABLE || >> + color_spc != DP_CONVERSION_BT2020_RGB_YCBCR_ENABLE) >> + return -EINVAL; > Yeah this is wrong, fix it. Agreed. Will fix this in next version of the patch. > >> + >> + ret = drm_dp_dpcd_readb(aux, DP_PROTOCOL_CONVERTER_CONTROL_2, >> &buf); >> + if (ret < 0) >> + return ret; >> + >> + buf |= color_spc; >> + ret = drm_dp_dpcd_writeb(aux, >> DP_PROTOCOL_CONVERTER_CONTROL_2, buf); >> + if (ret < 0) >> + return ret; >> + >> + return 0; >> +} >> +EXPORT_SYMBOL(drm_dp_pcon_convert_rgb_to_ycbcr); >> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h index >> 347b4e1a55b4..1b3d54ed7a78 100644 >> --- a/include/drm/drm_dp_helper.h >> +++ b/include/drm/drm_dp_helper.h >> @@ -431,6 +431,9 @@ struct drm_device; >> # define DP_DS_HDMI_YCBCR420_PASS_THROUGH (1 << 2) >> # define DP_DS_HDMI_YCBCR444_TO_422_CONV (1 << 3) >> # define DP_DS_HDMI_YCBCR444_TO_420_CONV (1 << 4) >> +# define DP_DS_HDMI_BT601_RGB_YCBCR_CONV (1 << 5) >> +# define DP_DS_HDMI_BT709_RGB_YCBCR_CONV (1 << 6) >> +# define DP_DS_HDMI_BT2020_RGB_YCBCR_CONV (1 << 7) > I think it would be good to mention the location in spec (section or table), > will make it easier to understand/review by directly going to relevant sections in spec. This is still Draft 1 of the spec: VESA DP-to-HDMI PCON Specification Standalone Document. Link in the commit message. I will mention the current Section and Table no. nevertheless in the next version of the patch. Thanks & Regards, Ankit >> #define DP_MAX_DOWNSTREAM_PORTS 0x10 >> >> @@ -1217,7 +1220,9 @@ struct drm_device; >> # define DP_PCON_ENC_PPS_OVERRIDE_DISABLED 0 >> # define DP_PCON_ENC_PPS_OVERRIDE_EN_PARAMS 1 >> # define DP_PCON_ENC_PPS_OVERRIDE_EN_BUFFER 2 >> - >> +# define DP_CONVERSION_BT601_RGB_YCBCR_ENABLE (1 << 4) # define >> +DP_CONVERSION_BT709_RGB_YCBCR_ENABLE (1 << 5) # define >> +DP_CONVERSION_BT2020_RGB_YCBCR_ENABLE (1 << 6) >> >> /* PCON Downstream HDMI ERROR Status per Lane */ >> #define DP_PCON_HDMI_ERROR_STATUS_LN0 0x3037 >> @@ -2178,5 +2183,8 @@ int drm_dp_pcon_dsc_bpp_incr(const u8 >> pcon_dsc_dpcd[DP_PCON_DSC_ENCODER_CAP_SIZE >> int drm_dp_pcon_pps_default(struct drm_dp_aux *aux); int >> drm_dp_pcon_pps_override_buf(struct drm_dp_aux *aux, u8 pps_buf[128]); int >> drm_dp_pcon_pps_override_param(struct drm_dp_aux *aux, u8 pps_param[6]); >> +bool drm_dp_downstream_rgb_to_ycbcr_conversion(const u8 >> dpcd[DP_RECEIVER_CAP_SIZE], >> + const u8 port_cap[4]); >> +int drm_dp_pcon_convert_rgb_to_ycbcr(struct drm_dp_aux *aux, u8 >> +color_spc); >> >> #endif /* _DRM_DP_HELPER_H_ */ >> -- >> 2.17.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel