All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Winkler, Tomas" <tomas.winkler@intel.com>
To: Dorian Stoll <dorian.stoll@tmsp.io>,
	Arnd Bergmann <arnd@arndb.de>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] mei: me: Add itouch device IDs for SPT / ICP
Date: Mon, 1 Jun 2020 16:32:53 +0000	[thread overview]
Message-ID: <b22a353f4d4f47df9676c9572b6ac773@intel.com> (raw)
In-Reply-To: <20200601155954.764558-1-dorian.stoll@tmsp.io>



> These device IDs can be found on Microsoft Surface devices.
> 
> Signed-off-by: Dorian Stoll <dorian.stoll@tmsp.io>

This need to be done differently because of the server platforms conflict.
I have patches for that I will post short, though we are not officially supporting those devices under Linux, 
It will be hard to maintain,  as currently on the MS surface enables it as far as I know.

> ---
>  drivers/misc/mei/hw-me-regs.h | 2 ++
>  drivers/misc/mei/pci-me.c     | 2 ++
>  2 files changed, 4 insertions(+)
> 
> diff --git a/drivers/misc/mei/hw-me-regs.h b/drivers/misc/mei/hw-me-
> regs.h index 9392934e3a06..90e7d3020fa5 100644
> --- a/drivers/misc/mei/hw-me-regs.h
> +++ b/drivers/misc/mei/hw-me-regs.h
> @@ -59,6 +59,7 @@
> 
>  #define MEI_DEV_ID_SPT        0x9D3A  /* Sunrise Point */
>  #define MEI_DEV_ID_SPT_2      0x9D3B  /* Sunrise Point 2 */
> +#define MEI_DEV_ID_SPT_4      0x9D3E  /* Sunrise Point 4 (iTouch) */
>  #define MEI_DEV_ID_SPT_H      0xA13A  /* Sunrise Point H */
>  #define MEI_DEV_ID_SPT_H_2    0xA13B  /* Sunrise Point H 2 */
> 
> @@ -90,6 +91,7 @@
>  #define MEI_DEV_ID_CDF        0x18D3  /* Cedar Fork */
> 
>  #define MEI_DEV_ID_ICP_LP     0x34E0  /* Ice Lake Point LP */
> +#define MEI_DEV_ID_ICP_LP_4   0x34E4  /* Ice Lake Point LP 4 (iTouch) */
> 
>  #define MEI_DEV_ID_JSP_N      0x4DE0  /* Jasper Lake Point N */
> 
> diff --git a/drivers/misc/mei/pci-me.c b/drivers/misc/mei/pci-me.c index
> a1ed375fed37..5e621e90d8d4 100644
> --- a/drivers/misc/mei/pci-me.c
> +++ b/drivers/misc/mei/pci-me.c
> @@ -68,6 +68,7 @@ static const struct pci_device_id mei_me_pci_tbl[] = {
> 
>  	{MEI_PCI_DEVICE(MEI_DEV_ID_SPT, MEI_ME_PCH8_CFG)},
>  	{MEI_PCI_DEVICE(MEI_DEV_ID_SPT_2, MEI_ME_PCH8_CFG)},
> +	{MEI_PCI_DEVICE(MEI_DEV_ID_SPT_4, MEI_ME_PCH8_CFG)},
>  	{MEI_PCI_DEVICE(MEI_DEV_ID_SPT_H, MEI_ME_PCH8_SPS_CFG)},
>  	{MEI_PCI_DEVICE(MEI_DEV_ID_SPT_H_2, MEI_ME_PCH8_SPS_CFG)},
>  	{MEI_PCI_DEVICE(MEI_DEV_ID_LBG, MEI_ME_PCH12_SPS_CFG)},
> @@ -94,6 +95,7 @@ static const struct pci_device_id mei_me_pci_tbl[] = {
>  	{MEI_PCI_DEVICE(MEI_DEV_ID_CMP_H_3, MEI_ME_PCH8_CFG)},
> 
>  	{MEI_PCI_DEVICE(MEI_DEV_ID_ICP_LP, MEI_ME_PCH12_CFG)},
> +	{MEI_PCI_DEVICE(MEI_DEV_ID_ICP_LP_4, MEI_ME_PCH12_CFG)},
> 
>  	{MEI_PCI_DEVICE(MEI_DEV_ID_TGP_LP, MEI_ME_PCH15_CFG)},
> 
> --
> 2.26.2
> 


  reply	other threads:[~2020-06-01 16:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-01 15:59 [PATCH] mei: me: Add itouch device IDs for SPT / ICP Dorian Stoll
2020-06-01 16:32 ` Winkler, Tomas [this message]
2020-06-01 17:24   ` Dorian Stoll
2020-06-01 21:25     ` Winkler, Tomas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b22a353f4d4f47df9676c9572b6ac773@intel.com \
    --to=tomas.winkler@intel.com \
    --cc=arnd@arndb.de \
    --cc=dorian.stoll@tmsp.io \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.