From: Shuah Khan <skhan@linuxfoundation.org>
To: John Hubbard <jhubbard@nvidia.com>, Shuah Khan <shuah@kernel.org>
Cc: "Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Darren Hart" <dvhart@infradead.org>,
"Davidlohr Bueso" <dave@stgolabs.net>,
"Edward Liaw" <edliaw@google.com>,
"André Almeida" <andrealmeid@igalia.com>,
"Nysal Jan K . A" <nysal@linux.ibm.com>,
"Mark Brown" <broonie@kernel.org>,
"Valentin Obst" <kernel@valentinobst.de>,
linux-kselftest@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
llvm@lists.linux.dev, "Shuah Khan" <skhan@linuxfoundation.org>
Subject: Re: [PATCH v2 2/3] selftests/futex: don't pass a const char* to asprintf(3)
Date: Thu, 30 May 2024 15:13:40 -0600 [thread overview]
Message-ID: <b245cd0a-8a87-4169-b0de-e4f6ce6984c6@linuxfoundation.org> (raw)
In-Reply-To: <f0a1ca78-f94e-4f02-a5e0-ef9d610fac07@nvidia.com>
On 5/30/24 13:16, John Hubbard wrote:
> On 5/30/24 12:04 PM, Shuah Khan wrote:
>> On 5/28/24 20:29, John Hubbard wrote:
>>> When building with clang, via:
>>>
>>> make LLVM=1 -C tools/testing/selftests
>>>
>>> ...clang issues a warning, because test_name is passed into asprintf(3),
>>> which then changes it.
>>
>> Please include the warning in the commit log.
>
> Ah, OK, the warning is:
>
> futex_requeue_pi.c:403:17: warning: passing 'const char **' to parameter
> of type 'char **' discards qualifiers in nested pointer types
> [-Wincompatible-pointer-types-discards-qualifiers]
>
>
> Please let me know if you'd prefer a v3, or if you'd rather fix it
> up, whatever seems easiest for you.
>
Yes please send me v3.
thanks,
-- Shuah
next prev parent reply other threads:[~2024-05-30 21:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-29 2:29 [PATCH v2 0/3] selftests/futex: clang-inspired fixes John Hubbard
2024-05-29 2:29 ` [PATCH v2 1/3] selftests/futex: don't redefine .PHONY targets (all, clean) John Hubbard
2024-05-30 19:03 ` Shuah Khan
2024-05-30 19:13 ` John Hubbard
2024-05-30 21:12 ` Shuah Khan
2024-05-30 21:14 ` John Hubbard
2024-05-29 2:29 ` [PATCH v2 2/3] selftests/futex: don't pass a const char* to asprintf(3) John Hubbard
2024-05-30 19:04 ` Shuah Khan
2024-05-30 19:16 ` John Hubbard
2024-05-30 21:13 ` Shuah Khan [this message]
2024-05-30 21:15 ` John Hubbard
2024-05-29 2:29 ` [PATCH v2 3/3] selftests/futex: pass _GNU_SOURCE without a value to the compiler John Hubbard
2024-05-30 19:07 ` Shuah Khan
2024-05-30 14:23 ` [PATCH v2 0/3] selftests/futex: clang-inspired fixes Shuah Khan
2024-05-30 19:09 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b245cd0a-8a87-4169-b0de-e4f6ce6984c6@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=andrealmeid@igalia.com \
--cc=broonie@kernel.org \
--cc=dave@stgolabs.net \
--cc=dvhart@infradead.org \
--cc=edliaw@google.com \
--cc=jhubbard@nvidia.com \
--cc=kernel@valentinobst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mingo@redhat.com \
--cc=nysal@linux.ibm.com \
--cc=peterz@infradead.org \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.