Re: [PATCH] vDPA/ifcvf: allow userspace to suspend a queue

[Zhou Furong <furong.zhou@linux.intel.com>]

Hi,

> +bool ifcvf_get_vq_ready(struct ifcvf_hw *hw, u16 qid)
> +{
> +	struct virtio_pci_common_cfg __iomem *cfg = hw->common_cfg;
> +	bool queue_enable;
> +
> +	vp_iowrite16(qid, &cfg->queue_select);
> +	queue_enable = vp_ioread16(&cfg->queue_enable);
> +
> +	return (bool)queue_enable;
queue_enable is bool, why cast? looks like remove the variable is better.
return vp_ioread16(&cfg->queue_enable);

>   static bool ifcvf_vdpa_get_vq_ready(struct vdpa_device *vdpa_dev, u16 qid)
>   {
>   	struct ifcvf_hw *vf = vdpa_to_vf(vdpa_dev);
> +	bool ready;
>   
> -	return vf->vring[qid].ready;
> +	ready = ifcvf_get_vq_ready(vf, qid);
> +
> +	return ready;
remove ready looks better
return ifcvf_get_vq_ready(vf, qid);


Best regards,
Furong