From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 279B3C369DC for ; Wed, 7 May 2025 06:17:59 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.978220.1365051 (Exim 4.92) (envelope-from ) id 1uCY6C-0002yJ-HC; Wed, 07 May 2025 06:17:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 978220.1365051; Wed, 07 May 2025 06:17:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uCY6C-0002yC-EE; Wed, 07 May 2025 06:17:44 +0000 Received: by outflank-mailman (input) for mailman id 978220; Wed, 07 May 2025 06:17:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uCY6C-0002y6-3D for xen-devel@lists.xenproject.org; Wed, 07 May 2025 06:17:44 +0000 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [2a00:1450:4864:20::331]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f49268ac-2b0a-11f0-9ffb-bf95429c2676; Wed, 07 May 2025 08:17:30 +0200 (CEST) Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-43cfa7e7f54so3655045e9.1 for ; Tue, 06 May 2025 23:17:30 -0700 (PDT) Received: from [192.168.1.183] (host-92-26-98-202.as13285.net. [92.26.98.202]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-441d433e9efsm19444165e9.3.2025.05.06.23.17.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 May 2025 23:17:29 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f49268ac-2b0a-11f0-9ffb-bf95429c2676 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1746598650; x=1747203450; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=crHLmg0f4Do3RZv1tlldQ+CfN4wWtZcY35dbZBHB6vI=; b=q8nlNhZStKFdx5HetXhukUGfFLdpqiqbiCRYHlz2ErFgNRgxJc53x4vTsHYzpMWN0m l6ohxRHcCY4+hBxZFAYNIdgiaV/aiF+ufNJWOCkiR8i84UcnTZ+x7lWQbwSJovV3GzIY 1evGhy+fHy+o6zCfI3Pci7hsJJwscP10z9shg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746598650; x=1747203450; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=crHLmg0f4Do3RZv1tlldQ+CfN4wWtZcY35dbZBHB6vI=; b=NG6nAyPeb10JKbrWZ4VcFNFGEAgm8ZcXkutWiyhk2DSpc7viqxX0macnnaJJr0Nlf1 W0RrwkKZ5m1130LgDtWNfD67NlCxuZ1Uih314sXP3ekruEqHqCjTxjqCqYU0hKmQ8XWi HAe7E7lBjtpmRugWc325m/IN0nfCgH0T6zirqiWd0AqzuEOGPKpucY0jqHTan57Q9a4D /+Pcgyn+9SAAd+TRBakxixM4ce/fkCl6WnfChDN076VM1h0y1qq6p+TeA+nWnElm+BbR 9hu0T1Z7CCCi23Ys7uSWA5UleAroAuQNEiGQF6Z9TFEBQINhjt7GeavgsUU773XO4qlt eIsA== X-Gm-Message-State: AOJu0Yx0cn6PcC5rd8x2xgD2E9NFEeLNW5iJDfW2VN+SUaOohpNHiLHM N+lrDdDoxqpmmiNKWsqKd3pS9MIK7yHcP40MZxrAaCwRSHngmPou/3aiXoKYGFs= X-Gm-Gg: ASbGncsZ23nX1A0o+yYNoK8LPG6nc2k/8FRh8tMJd/pCFaweuKUtcBTpIvz8tswOhvE F7+2ER5AaryGE7nKC+XkMquSespDc+qrFZpkSITzPE0D49LeCBCDK87a7hTxe7GuFu8OKuJ6ymn HLXKHXUlZZl/cBg+9PUI6oSC+X9Hx0z5pAdEomf+hR4xLEpxcwVZTUsRAVDCymXybrlIvq34yJC Yk2fV3QwUw0oNbzccqOT8uq2grKJkHpPPsoXyQt0Wip5Qrw959rn4vc6GOZ5h020glCC+AEiSYx 0SxlcSyCPCYY8riFdVNcvb7/l5HDL6zqvSeVJf83tA51n748L6AMG+Tsvwc4Fj2LWvRKfkE++G6 IdqoUQw== X-Google-Smtp-Source: AGHT+IE9IUeR+OpKATphKydlRFzUsl5DDDRs6tAcjySNjXAr77Fa6H1Qd83FcPAiRWT0iWlSxDrejg== X-Received: by 2002:a05:600c:46c6:b0:43b:c6a7:ac60 with SMTP id 5b1f17b1804b1-441d44a3706mr11497375e9.10.1746598649537; Tue, 06 May 2025 23:17:29 -0700 (PDT) Message-ID: Date: Wed, 7 May 2025 07:17:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] xen/lib: Export additional sha256 functions To: Frediano Ziglio Cc: xen-devel@lists.xenproject.org, Ross Lagerwall , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini References: <20250506135655.187014-1-frediano.ziglio@cloud.com> <20250506135655.187014-2-frediano.ziglio@cloud.com> <5698b996-e23d-49f7-af37-645d4784dc67@citrix.com> Content-Language: en-GB From: Andrew Cooper Autocrypt: addr=andrew.cooper3@citrix.com; keydata= xsFNBFLhNn8BEADVhE+Hb8i0GV6mihnnr/uiQQdPF8kUoFzCOPXkf7jQ5sLYeJa0cQi6Penp VtiFYznTairnVsN5J+ujSTIb+OlMSJUWV4opS7WVNnxHbFTPYZVQ3erv7NKc2iVizCRZ2Kxn srM1oPXWRic8BIAdYOKOloF2300SL/bIpeD+x7h3w9B/qez7nOin5NzkxgFoaUeIal12pXSR Q354FKFoy6Vh96gc4VRqte3jw8mPuJQpfws+Pb+swvSf/i1q1+1I4jsRQQh2m6OTADHIqg2E ofTYAEh7R5HfPx0EXoEDMdRjOeKn8+vvkAwhviWXTHlG3R1QkbE5M/oywnZ83udJmi+lxjJ5 YhQ5IzomvJ16H0Bq+TLyVLO/VRksp1VR9HxCzItLNCS8PdpYYz5TC204ViycobYU65WMpzWe LFAGn8jSS25XIpqv0Y9k87dLbctKKA14Ifw2kq5OIVu2FuX+3i446JOa2vpCI9GcjCzi3oHV e00bzYiHMIl0FICrNJU0Kjho8pdo0m2uxkn6SYEpogAy9pnatUlO+erL4LqFUO7GXSdBRbw5 gNt25XTLdSFuZtMxkY3tq8MFss5QnjhehCVPEpE6y9ZjI4XB8ad1G4oBHVGK5LMsvg22PfMJ ISWFSHoF/B5+lHkCKWkFxZ0gZn33ju5n6/FOdEx4B8cMJt+cWwARAQABzSlBbmRyZXcgQ29v cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPsLBegQTAQgAJAIbAwULCQgHAwUVCgkI CwUWAgMBAAIeAQIXgAUCWKD95wIZAQAKCRBlw/kGpdefoHbdD/9AIoR3k6fKl+RFiFpyAhvO 59ttDFI7nIAnlYngev2XUR3acFElJATHSDO0ju+hqWqAb8kVijXLops0gOfqt3VPZq9cuHlh IMDquatGLzAadfFx2eQYIYT+FYuMoPZy/aTUazmJIDVxP7L383grjIkn+7tAv+qeDfE+txL4 SAm1UHNvmdfgL2/lcmL3xRh7sub3nJilM93RWX1Pe5LBSDXO45uzCGEdst6uSlzYR/MEr+5Z JQQ32JV64zwvf/aKaagSQSQMYNX9JFgfZ3TKWC1KJQbX5ssoX/5hNLqxMcZV3TN7kU8I3kjK mPec9+1nECOjjJSO/h4P0sBZyIUGfguwzhEeGf4sMCuSEM4xjCnwiBwftR17sr0spYcOpqET ZGcAmyYcNjy6CYadNCnfR40vhhWuCfNCBzWnUW0lFoo12wb0YnzoOLjvfD6OL3JjIUJNOmJy RCsJ5IA/Iz33RhSVRmROu+TztwuThClw63g7+hoyewv7BemKyuU6FTVhjjW+XUWmS/FzknSi dAG+insr0746cTPpSkGl3KAXeWDGJzve7/SBBfyznWCMGaf8E2P1oOdIZRxHgWj0zNr1+ooF /PzgLPiCI4OMUttTlEKChgbUTQ+5o0P080JojqfXwbPAyumbaYcQNiH1/xYbJdOFSiBv9rpt TQTBLzDKXok86M7BTQRS4TZ/ARAAkgqudHsp+hd82UVkvgnlqZjzz2vyrYfz7bkPtXaGb9H4 Rfo7mQsEQavEBdWWjbga6eMnDqtu+FC+qeTGYebToxEyp2lKDSoAsvt8w82tIlP/EbmRbDVn 7bhjBlfRcFjVYw8uVDPptT0TV47vpoCVkTwcyb6OltJrvg/QzV9f07DJswuda1JH3/qvYu0p vjPnYvCq4NsqY2XSdAJ02HrdYPFtNyPEntu1n1KK+gJrstjtw7KsZ4ygXYrsm/oCBiVW/OgU g/XIlGErkrxe4vQvJyVwg6YH653YTX5hLLUEL1NS4TCo47RP+wi6y+TnuAL36UtK/uFyEuPy wwrDVcC4cIFhYSfsO0BumEI65yu7a8aHbGfq2lW251UcoU48Z27ZUUZd2Dr6O/n8poQHbaTd 6bJJSjzGGHZVbRP9UQ3lkmkmc0+XCHmj5WhwNNYjgbbmML7y0fsJT5RgvefAIFfHBg7fTY/i kBEimoUsTEQz+N4hbKwo1hULfVxDJStE4sbPhjbsPCrlXf6W9CxSyQ0qmZ2bXsLQYRj2xqd1 bpA+1o1j2N4/au1R/uSiUFjewJdT/LX1EklKDcQwpk06Af/N7VZtSfEJeRV04unbsKVXWZAk uAJyDDKN99ziC0Wz5kcPyVD1HNf8bgaqGDzrv3TfYjwqayRFcMf7xJaL9xXedMcAEQEAAcLB XwQYAQgACQUCUuE2fwIbDAAKCRBlw/kGpdefoG4XEACD1Qf/er8EA7g23HMxYWd3FXHThrVQ HgiGdk5Yh632vjOm9L4sd/GCEACVQKjsu98e8o3ysitFlznEns5EAAXEbITrgKWXDDUWGYxd pnjj2u+GkVdsOAGk0kxczX6s+VRBhpbBI2PWnOsRJgU2n10PZ3mZD4Xu9kU2IXYmuW+e5KCA vTArRUdCrAtIa1k01sPipPPw6dfxx2e5asy21YOytzxuWFfJTGnVxZZSCyLUO83sh6OZhJkk b9rxL9wPmpN/t2IPaEKoAc0FTQZS36wAMOXkBh24PQ9gaLJvfPKpNzGD8XWR5HHF0NLIJhgg 4ZlEXQ2fVp3XrtocHqhu4UZR4koCijgB8sB7Tb0GCpwK+C4UePdFLfhKyRdSXuvY3AHJd4CP 4JzW0Bzq/WXY3XMOzUTYApGQpnUpdOmuQSfpV9MQO+/jo7r6yPbxT7CwRS5dcQPzUiuHLK9i nvjREdh84qycnx0/6dDroYhp0DFv4udxuAvt1h4wGwTPRQZerSm4xaYegEFusyhbZrI0U9tJ B8WrhBLXDiYlyJT6zOV2yZFuW47VrLsjYnHwn27hmxTC/7tvG3euCklmkn9Sl9IAKFu29RSo d5bD8kMSCYsTqtTfT6W4A3qHGvIDta3ptLYpIAOD2sY3GYq2nf3Bbzx81wZK14JdDDHUX2Rs 6+ahAA== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 07/05/2025 6:26 am, Frediano Ziglio wrote: > On Tue, May 6, 2025 at 11:17 PM Andrew Cooper wrote: >> On 06/05/2025 3:05 pm, Andrew Cooper wrote: >>> On 06/05/2025 2:56 pm, Frediano Ziglio wrote: >>>> diff --git a/xen/include/xen/sha2.h b/xen/include/xen/sha2.h >>>> index 47d97fbf01..ea8bad67e4 100644 >>>> --- a/xen/include/xen/sha2.h >>>> +++ b/xen/include/xen/sha2.h >>>> @@ -9,6 +9,16 @@ >>>> >>>> #define SHA2_256_DIGEST_SIZE 32 >>>> >>>> +struct sha2_256_state { >>>> + uint32_t state[SHA2_256_DIGEST_SIZE / sizeof(uint32_t)]; >>>> + uint8_t buf[64]; >>>> + size_t count; /* Byte count. */ >>>> +}; >>>> + >>>> +void sha2_256_init(struct sha2_256_state *s); >>>> +void sha2_256_update(struct sha2_256_state *s, const void *msg, >>>> + size_t len); >>>> +void sha2_256_final(struct sha2_256_state *s, void *_dst); >>>> void sha2_256_digest(uint8_t digest[SHA2_256_DIGEST_SIZE], >>>> const void *msg, size_t len); >>> sha2_256_digest() is unlike the others as it holds sha2_256_state >>> internally. I'd suggest having all of the additions below this point, >>> which group them more nicely. >>> >>> Can fix on commit. Otherwise LGTM. >> Not quite. Now that sha2_256_final() is exported, it should have a >> proper type for _dst. I've folded: >> >> diff --git a/xen/include/xen/sha2.h b/xen/include/xen/sha2.h >> index 0d55fe640431..cb30e8f8d77c 100644 >> --- a/xen/include/xen/sha2.h >> +++ b/xen/include/xen/sha2.h >> @@ -21,6 +21,7 @@ struct sha2_256_state { >> void sha2_256_init(struct sha2_256_state *s); >> void sha2_256_update(struct sha2_256_state *s, const void *msg, >> size_t len); >> -void sha2_256_final(struct sha2_256_state *s, void *_dst); >> +void sha2_256_final(struct sha2_256_state *s, >> + uint8_t digest[SHA2_256_DIGEST_SIZE]); >> >> #endif /* XEN_SHA2_H */ >> diff --git a/xen/lib/sha2-256.c b/xen/lib/sha2-256.c >> index 896a257ed9b7..08ef7011a1c3 100644 >> --- a/xen/lib/sha2-256.c >> +++ b/xen/lib/sha2-256.c >> @@ -171,9 +171,9 @@ void sha2_256_update(struct sha2_256_state *s, const >> void *msg, >> memcpy(s->buf + partial, msg, len); >> } >> >> -void sha2_256_final(struct sha2_256_state *s, void *_dst) >> +void sha2_256_final(struct sha2_256_state *s, uint8_t >> digest[SHA2_256_DIGEST_SIZE]) >> { >> - uint32_t *dst = _dst; >> + uint32_t *dst = (uint32_t *)digest; > That is we are never going to support architectures with unaligned > memory access. Note how it's written to.     /* Store state in digest */     for ( i = 0; i < 8; i++ )         put_unaligned_be32(s->state[i], &dst[i]); It works just fine on misaligned buffers. ~Andrew