From: Krzysztof Kozlowski <krzk@kernel.org>
To: Michal Simek <michal.simek@amd.com>, Ben Levinsky <ben.levinsky@amd.com>
Cc: andersson@kernel.org, mathieu.poirier@linaro.org,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, tanmay.shah@amd.com
Subject: Re: [PATCH v2 1/2] dt-bindings: remoteproc: document AMD BRAM-based rproc
Date: Tue, 28 Apr 2026 15:28:50 +0200 [thread overview]
Message-ID: <b29fc356-0c5e-4418-9d3f-c04a2c0f7957@kernel.org> (raw)
In-Reply-To: <a6a231e5-ee87-4045-ab16-8acdd4937f42@amd.com>
On 28/04/2026 15:18, Michal Simek wrote:
>>>
>>> properties:
>>> compatible:
>>> items:
>>> - enum:
>>> - xlnx,zynqmp-bram-rproc
>>> - xlnx,versal-bram-rproc
>>> - xlnx,versal-net-bram-rproc
>>> - amd,versal2-bram-rproc
>>> - const: amd,bram-rproc
>>>
>>> The example should also be updated:
>>
>> Yes, except what I wrote earlier and is mentioned in the writing
>> bindings doc - the specific compatible should be also the fallback.
>
> properties:
> compatible:
> oneOf:
> - const: xlnx,zynqmp-bram-rproc
> - items:
> - enum:
> - xlnx,versal-bram-rproc
> - xlnx,versal-net-bram-rproc
> - amd,versal2-bram-rproc
> - const: xlnx,zynqmp-bram-rproc
>
> Good now?
Yes, looks good to me!
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-04-28 13:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-27 16:27 [PATCH v2 0/2] remoteproc: add AMD BRAM-based remote processor driver Ben Levinsky
2026-04-27 16:27 ` [PATCH v2 1/2] dt-bindings: remoteproc: document AMD BRAM-based rproc Ben Levinsky
2026-04-28 6:50 ` Krzysztof Kozlowski
2026-04-28 8:33 ` Michal Simek
2026-04-28 8:47 ` Krzysztof Kozlowski
2026-04-28 9:04 ` Michal Simek
2026-04-28 9:14 ` Krzysztof Kozlowski
2026-04-28 13:09 ` Michal Simek
2026-04-28 13:12 ` Krzysztof Kozlowski
2026-04-28 13:18 ` Michal Simek
2026-04-28 13:28 ` Krzysztof Kozlowski [this message]
2026-04-27 16:27 ` [PATCH v2 2/2] remoteproc: add AMD BRAM-based remote processor driver Ben Levinsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b29fc356-0c5e-4418-9d3f-c04a2c0f7957@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=ben.levinsky@amd.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=michal.simek@amd.com \
--cc=robh@kernel.org \
--cc=tanmay.shah@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.