From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90A54C433DF for ; Thu, 30 Jul 2020 08:05:37 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5F313206C0 for ; Thu, 30 Jul 2020 08:05:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="phyF7SdJ"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="LxrOuAMn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5F313206C0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:References: To:From:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=36GH5Z+OvmrRxSM4VR4+77U9WyvyEs/oipqeJ6ebjRE=; b=phyF7SdJw19pFvgD6yGFB2JtO UEVWEwbWqT+uU19+YccTYSkkKWS8DJ4ktWBTDrXTCzUDCoztBAEJ0r3iR2Ko+UV9/Lbc0vWTPaiCW uQji2VHZiAeYmA6q9K1OhEMs/VTwk3X+zJtCTND+cTXW0t2VBqymc+9btDQEFOU4J0TmmBJSYAphH E12pA9zDkf17p0mP5aNcrwD2wjSV7tz2VlI/ce5bMkeh3PV2hVftoOi7txIc752uqRXtT5bEd1Ifk 5YzIhE3BefOeYl6WpS+lAvq1xhiEEKZ258/wkgfKhFCJJMVmYCC8uTq/bz+M+C6Is1w3vepfLVd2J doBnNGADQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k13Xq-0002ys-PU; Thu, 30 Jul 2020 08:04:06 +0000 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120] helo=us-smtp-1.mimecast.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k13Xm-0002xz-NZ for linux-arm-kernel@lists.infradead.org; Thu, 30 Jul 2020 08:04:04 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596096241; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=H0xFjUNNz1aIAD3w49A9CwosszuqMXn6sxy/ttSBVwk=; b=LxrOuAMnbAY7CGAHR843tqnbKjlSN+NvazsA5vRGZUwi8k7dbpvXKRi3dqrN800pGckUws dXkI6qgWlSttpfC9xEvYnzPCF8oYIUhYgPt/OrIiSti3mj3WCOO2uPsrr5XdeCwoTIOfE/ AHZIfA1eWQXs3YqfJCb1fcFIdeVRNVU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-37-SpnDxg_TPQK8D_VEDKOu2w-1; Thu, 30 Jul 2020 04:03:57 -0400 X-MC-Unique: SpnDxg_TPQK8D_VEDKOu2w-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 726F2106B243; Thu, 30 Jul 2020 08:03:55 +0000 (UTC) Received: from [10.64.54.54] (vpn2-54-54.bne.redhat.com [10.64.54.54]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D57A17BD47; Thu, 30 Jul 2020 08:03:52 +0000 (UTC) Subject: Re: [PATCH v4 00/15] Refactor SDEI client driver From: Gavin Shan To: linux-arm-kernel@lists.infradead.org References: <20200730014531.310465-1-gshan@redhat.com> Message-ID: Date: Thu, 30 Jul 2020 18:03:50 +1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.0 MIME-Version: 1.0 In-Reply-To: <20200730014531.310465-1-gshan@redhat.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=gshan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200730_040402_839110_A6EE1739 X-CRM114-Status: GOOD ( 26.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, catalin.marinas@arm.com, james.morse@arm.com, shan.gavin@gmail.com, Jonathan.Cameron@huawei.com, will@kernel.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi James, On 7/30/20 11:45 AM, Gavin Shan wrote: > This series bases on 5.8-rc7 and refactors the SDEI client driver. > It's the preparatory work of virtualizing SDEI afterwords. The series > is organized as below: > > * PATCH[1-13] refactors and clean up the code. They shouldn't cause > any functional changes. > * PATCH[14-15] exposes "struct sdei_event", which will be dereferenced > on virtualizing SDEI. After it's applied, the SDEI event is identified > by the instance of "struct sdei_event" instead of event number. > > The series can be checked out from: > > git@github.com:gwshan/linux.git > (branch: "sdei_client") > I'm not sure if you need to review it as Jonathan almost finishes the review. It would be nice to get this merged in 5.9.rc1/rc2 since the subsequent series to support SDEI virtualization, which depends on this series. Thanks in advance for your time and comments :) > Testing > ======= > I have the SDEI virtualization code implemented as part of KVM module. > With that, the SDEI event can be registered/unregistered/enabled/disabled. > Also, the SDEI event can be injected from host and the guest handler runs > properly. > > The code can be found from: > > git@github.com:gwshan/linux.git > (branch: "sdei") > > Changelog > ========= > v4: > Rebase to last upstream kernel (Gavin) > Use @event_el for SDEI internal event and use @event to cache > SDEI event if needed (Jonathan) > Rename @se to @event for APIs (Jonathan) > v3: > Rebase to 5.8.rc7 (Gavin) > Pick rbs from Jonathan (Gavin) > Correct spellings in commit logs (Jonathan) > Rename "out" to "unlock" tag (Jonathan) > Keep the empty line in sdei_event_unregister() (Jonathan) > Drop tabs between type and field for struct sdei_crosscall_args (Jonathan) > Use smp_call_func_t for @fn argument in CPU callbacks (Jonathan) > Split struct sdei_event into struct sdei_{internal,}_event (Jonathan) > Remove last two patches and get it reviewed later (Jonathan) > v2: > Rebase to 5.8.rc6 (Gavin) > Improved changelog (James/Gavin) > Split patches for easy review (Gavin) > Drop changes to reorder variables (James) > Drop unnecessary (@regs removal) cleanup in sdei_event_create() (James) > Fix broken case for device-tree in sdei_init() (James) > > Gavin Shan (15): > drivers/firmware/sdei: Remove sdei_is_err() > drivers/firmware/sdei: Common block for failing path in > sdei_event_create() > drivers/firmware/sdei: Retrieve event number from event instance > drivers/firmware/sdei: Avoid nested statements in sdei_init() > drivers/firmware/sdei: Unregister driver on error in sdei_init() > drivers/firmware/sdei: Remove duplicate check in sdei_get_conduit() > drivers/firmware/sdei: Remove Drop redundant error message in > sdei_probe() > drivers/firmware/sdei: Remove while loop in sdei_event_register() > drivers/firmware/sdei: Remove while loop in sdei_event_unregister() > drivers/firmware/sdei: Cleanup on cross call function > drivers/firmware/sdei: Introduce sdei_do_local_call() > drivers/firmware/sdei: Remove _sdei_event_register() > drivers/firmware/sdei: Remove _sdei_event_unregister() > drivers/firmware/sdei: Expose struct sdei_event > drivers/firmware/sdei: Identify event by struct sdei_event > > drivers/firmware/arm_sdei.c | 459 +++++++++++++++++------------------- > include/linux/arm_sdei.h | 16 +- > 2 files changed, 231 insertions(+), 244 deletions(-) > Thanks, Gavin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel