From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: "joshi.k@samsung.com" <joshi.k@samsung.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"kbusch@kernel.org" <kbusch@kernel.org>
Subject: Re: [PATCH 1/3] block: shrink rq_map_data a bit
Date: Sun, 7 Aug 2022 09:26:33 +0000 [thread overview]
Message-ID: <b2b935da-7869-71ce-105a-ba1b1beee8c2@nvidia.com> (raw)
In-Reply-To: <20220806152004.382170-2-axboe@kernel.dk>
On 8/6/22 08:20, Jens Axboe wrote:
> We don't need full ints for several of these members. Change the
> page_order and nr_entries to unsigned shorts, and the true/false from_user
> and null_mapped to booleans.
>
> This shrinks the struct from 32 to 24 bytes on 64-bit archs.
>
> Signed-off-by: Jens Axboe <axboe@kernel.dk>
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
next prev parent reply other threads:[~2022-08-07 9:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-06 15:20 [PATCHSET 0/3] passthru block optimizations Jens Axboe
2022-08-06 15:20 ` [PATCH 1/3] block: shrink rq_map_data a bit Jens Axboe
2022-08-07 9:26 ` Chaitanya Kulkarni [this message]
2022-08-06 15:20 ` [PATCH 2/3] block: enable bio caching use for passthru IO Jens Axboe
2022-08-07 9:27 ` Chaitanya Kulkarni
2022-08-07 18:08 ` Kanchan Joshi
2022-08-07 18:45 ` Jens Axboe
2022-08-06 15:20 ` [PATCH 3/3] block: use on-stack page vec for <= UIO_FASTIOV Jens Axboe
2022-08-07 9:30 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2b935da-7869-71ce-105a-ba1b1beee8c2@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=axboe@kernel.dk \
--cc=joshi.k@samsung.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.