Re: [PATCH V2 03/13] ASoC: amd: acp: fix PDM1 quirk and PDM controller selection for ACP7.B/7.F

["Mukunda,Vijendar" <vijendar.mukunda@amd.com>]

On 10/22/26 11:53, sashiko-bot@kernel.org wrote:
> [You don't often get email from sashiko-bot@kernel.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] ASoC: amd: acp: commit message describes fixup instead of new PDM support
> --
>
> commit 1cff813ba92933eeaa9d776d31dbcd42c0513207
> Author: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
>
> ASoC: amd: acp: fix PDM1 quirk and PDM controller selection for ACP7.B/7.F
>
> This commit adds ASOC_SDW_ACP_DMIC1 and pdm_sel support in
> sound/soc/amd/acp/acp-sdw-sof-mach.c to select between the "acp-sof-dmic0"
> and "acp-sof-dmic1" CPU DAIs on ACP7.B and ACP7.F platforms.
>
>>      ASoC: amd: acp: fix PDM1 quirk and PDM controller selection for ACP7.B/7.F
>>
>>      The ASOC_SDW_ACP_DMIC1 quirk was evaluated before dmi_check_system()
>>      and quirk_override were applied, so the pdm_sel fallback always saw
>>      the compile-time default and was effectively dead code. Move it to
>>      after the quirk is fully resolved and restrict it to ACP7B/7F revisions
>>      where PDM controller selection is meaningful.
>>
>>      Since ACP7.B/7.F exposes exactly one active PDM controller, use
>>      else if for the DMIC0 fallback: check ASOC_SDW_ACP_DMIC1 first; only
>>      fall back to ASOC_SDW_ACP_DMIC (DMIC0) when DMIC1 is not set.
>>
>>      Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
> [Severity: Low]
> This isn't a bug in the code, but the commit subject and message describe
> moving an existing ASOC_SDW_ACP_DMIC1 check and fixing a pre-existing
> pdm_sel fallback.
>
> Looking at the patch, ASOC_SDW_ACP_DMIC1 and pdm_sel in struct amd_mc_ctx
> (in sound/soc/amd/acp/soc_amd_sdw_common.h), the mach->pdata extraction and
> quirk fallback in mc_probe() (in sound/soc/amd/acp/acp-sdw-sof-mach.c), and
> the ACP7B_PCI_REV / ACP7F_PCI_REV CPU DAI selection in
> create_dmic_dailinks() (in sound/soc/amd/acp/acp-sdw-sof-mach.c) are all
> newly introduced by this commit rather than moved from an earlier location.
>
> Was a fixup commit message retained when squashing an earlier revision, and
> should the commit subject and changelog be updated to describe adding new
> PDM controller selection support for ACP7.B/7.F?
will rephrase the commit message and push the v3 version.
>
> --
> Sashiko AI review · https://sashiko.dev/#/patchset/20261022060724.1814741-1-Vijendar.Mukunda@amd.com?part=3