All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiner Kallweit <hkallweit1@gmail.com>
To: Oded Gabbay <ogabbay@kernel.org>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
	Hans de Goede <hdegoede@redhat.com>
Cc: "open list:AMD KFD" <dri-devel@lists.freedesktop.org>
Subject: [PATCH 1/6] drm/sysfs: Remove version attribute
Date: Sun, 8 Sep 2024 14:08:58 +0200	[thread overview]
Message-ID: <b2d8d283-36cc-42e8-a8e7-e57e9698a9b5@gmail.com> (raw)
In-Reply-To: <499229fd-5344-4799-85bf-93e4b3b45eca@gmail.com>

This undocumented attribute returns a version string which hasn't been
changed for ages. libdrm doesn't use it and I also found no other user.
So I think we can remove it.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
 drivers/gpu/drm/drm_sysfs.c | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/drivers/gpu/drm/drm_sysfs.c b/drivers/gpu/drm/drm_sysfs.c
index fb3bbb6ad..49e5faf11 100644
--- a/drivers/gpu/drm/drm_sysfs.c
+++ b/drivers/gpu/drm/drm_sysfs.c
@@ -126,8 +126,6 @@ static const struct component_ops typec_connector_ops = {
 	.unbind = typec_connector_unbind,
 };
 
-static CLASS_ATTR_STRING(version, S_IRUGO, "drm 1.1.0 20060810");
-
 /**
  * drm_sysfs_init - initialize sysfs helpers
  *
@@ -140,19 +138,10 @@ static CLASS_ATTR_STRING(version, S_IRUGO, "drm 1.1.0 20060810");
  */
 int drm_sysfs_init(void)
 {
-	int err;
-
 	drm_class = class_create("drm");
 	if (IS_ERR(drm_class))
 		return PTR_ERR(drm_class);
 
-	err = class_create_file(drm_class, &class_attr_version.attr);
-	if (err) {
-		class_destroy(drm_class);
-		drm_class = NULL;
-		return err;
-	}
-
 	drm_class->devnode = drm_devnode;
 
 	drm_sysfs_acpi_register();
@@ -169,7 +158,6 @@ void drm_sysfs_destroy(void)
 	if (IS_ERR_OR_NULL(drm_class))
 		return;
 	drm_sysfs_acpi_unregister();
-	class_remove_file(drm_class, &class_attr_version.attr);
 	class_destroy(drm_class);
 	drm_class = NULL;
 }
-- 
2.46.0



  reply	other threads:[~2024-09-08 12:09 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-08 12:04 [PATCH 0/6] drm: Series with core improvements/refactorings Heiner Kallweit
2024-09-08 12:08 ` Heiner Kallweit [this message]
2024-09-22 14:55   ` [PATCH 1/6] drm/sysfs: Remove version attribute Dmitry Baryshkov
2024-09-30 10:49     ` Heiner Kallweit
2024-10-01 10:01       ` Dmitry Baryshkov
2024-10-01 11:07         ` Heiner Kallweit
2024-10-01 11:26           ` Dmitry Baryshkov
2024-09-08 12:09 ` [PATCH 2/6] drm/sysfs: Drop unused drm_class_device_(un)register Heiner Kallweit
2024-09-22 14:57   ` Dmitry Baryshkov
2024-09-08 12:10 ` [PATCH 3/6] drm: Refactor drm_core_init error path Heiner Kallweit
2024-09-22 14:58   ` Dmitry Baryshkov
2024-09-08 12:11 ` [PATCH 4/6] drm: Change drm_class from pointer to const struct class Heiner Kallweit
2024-09-22 15:11   ` Dmitry Baryshkov
2024-11-02 21:33     ` Heiner Kallweit
2024-11-03 23:59       ` Greg Kroah-Hartman
2024-09-08 12:12 ` [PATCH 5/6] drm: Add __init annotations Heiner Kallweit
2024-09-22 15:12   ` Dmitry Baryshkov
2024-09-08 12:14 ` [PATCH 6/6] drm: drm/sysfs: Remove device type drm_minor Heiner Kallweit
2024-09-22 15:17   ` Dmitry Baryshkov
2024-10-19 15:18 ` [PATCH 0/6] drm: Series with core improvements/refactorings Dmitry Baryshkov
2024-10-20 21:00   ` Heiner Kallweit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b2d8d283-36cc-42e8-a8e7-e57e9698a9b5@gmail.com \
    --to=hkallweit1@gmail.com \
    --cc=airlied@gmail.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hdegoede@redhat.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=ogabbay@kernel.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.