Re: [PATCH ath-next v3 5/8] wifi: ath12k: add WBM RX error drop statistics

[Jeff Johnson <jeff.johnson@oss.qualcomm.com>]

On 8/10/2026 7:44 AM, Pardeep Kaur wrote:
> diff --git a/drivers/net/wireless/ath/ath12k/debugfs.c b/drivers/net/wireless/ath/ath12k/debugfs.c
> index cbda754d8656..34c605b609cb 100644
> --- a/drivers/net/wireless/ath/ath12k/debugfs.c
> +++ b/drivers/net/wireless/ath/ath12k/debugfs.c
> @@ -1071,6 +1071,20 @@ static ssize_t ath12k_debugfs_dump_device_dp_stats(struct file *file,
>  		[HAL_REO_DEST_RING_ERROR_CODE_PN_ERR_FLAG_SET] = "PN err",
>  		[HAL_REO_DEST_RING_ERROR_CODE_DESC_BLOCKED] = "Desc blocked"};
>  
> +	static const char *wbm_rx_drop[WBM_ERR_DROP_MAX] = {
> +		[WBM_ERR_GET_SW_DESC] = "SW desc error",
> +		[WBM_ERR_DESC_PARSE] = "Desc parse error",
> +		[WBM_ERR_DROP_INV_HW_ID] = "Invalid hw id",
> +		[WBM_ERR_DROP_NULL_PRTNR_DP] = "Null Partner dp",
> +		[WBM_ERR_DROP_NULL_PROC_DP] = "Process Null Partner dp",
> +		[WBM_ERR_DROP_NULL_PDEV] = "Null Pdev",
> +		[WBM_ERR_DROP_NULL_AR] = "Null ar",
> +		[WBM_ERR_DROP_CAC_RUNNING] = "CAC Running",
> +		[WBM_ERR_DROP_SG] = "Scatter Gather",
> +		[WBM_ERR_DROP_INV_NWIFI_HDR] = "Invalid NWifi Hdr len",
> +		[WBM_ERR_DROP_REO_GENERIC]  = "REO Generic",

nit: extra space before =

> +		[WBM_ERR_DROP_RXDMA_GENERIC] = "RXDMA Generic"};
> +
>  	static const char *wbm_rel_src[HAL_WBM_REL_SRC_MODULE_MAX] = {
>  		[HAL_WBM_REL_SRC_MODULE_TQM] = "TQM",
>  		[HAL_WBM_REL_SRC_MODULE_RXDMA] = "Rxdma",...> diff --git a/drivers/net/wireless/ath/ath12k/dp_stats.h
b/drivers/net/wireless/ath/ath12k/dp_stats.h
> new file mode 100644
> index 000000000000..04d3892acff3
> --- /dev/null
> +++ b/drivers/net/wireless/ath/ath12k/dp_stats.h
> @@ -0,0 +1,25 @@
> +/* SPDX-License-Identifier: BSD-3-Clause-Clear */
> +/*
> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
> + */
> +
> +#ifndef ATH12K_DP_STATS_H
> +#define ATH12K_DP_STATS_H
> +
> +enum ath12k_wbm_err_drop_reason {
> +	WBM_ERR_GET_SW_DESC,
> +	WBM_ERR_DESC_PARSE,

nit: why aren't these two also WBM_ERR_DROP_*
> +	WBM_ERR_DROP_INV_HW_ID,
> +	WBM_ERR_DROP_NULL_PRTNR_DP,
> +	WBM_ERR_DROP_NULL_PROC_DP,
> +	WBM_ERR_DROP_NULL_PDEV,
> +	WBM_ERR_DROP_NULL_AR,
> +	WBM_ERR_DROP_CAC_RUNNING,
> +	WBM_ERR_DROP_SG,
> +	WBM_ERR_DROP_INV_NWIFI_HDR,
> +	WBM_ERR_DROP_REO_GENERIC,
> +	WBM_ERR_DROP_RXDMA_GENERIC,
> +	WBM_ERR_DROP_MAX,
> +};
> +
> +#endif /* ATH12K_DP_STATS_H */