From: Matthieu Baerts <matttbe@kernel.org>
To: Gang Yan <yangang@kylinos.cn>, mptcp@lists.linux.dev
Subject: Re: [mptcp-next v4 0/2] selftests: mptcp: add tests for increasing
Date: Mon, 24 Feb 2025 13:13:45 +0100 [thread overview]
Message-ID: <b2eaec83-6f05-47f9-9a82-3fecb73e6966@kernel.org> (raw)
In-Reply-To: <cover.1740385876.git.yangang@kylinos.cn>
Hi Gang Yan,
On 24/02/2025 10:02, Gang Yan wrote:
> These patches provide a method to verify the 'mptcp_diag_dump_one'
> function, and the new tool 'mptcp_diag' can get the specific mptcp_info
> through multi msks.
Thank you for the update.
It looks good to me, just 2 small comments, but I can do the
modifications when applying the patches, no need to send a v5 just for that.
Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
> Hi Matt:
>
> Thank you for your suggestions regarding these patches, they have been
> very useful to me. Sorry for the misunderstanding caused by my misuse of
> the 'CLOSE' keyword. Currently, I have used the 'Link' instead. These
> patches are designed for 'mptcp_dump_one'.
>
> There may need another test case for 'subflow_get_info_size'. I will
> continue to work on resolving this issue.
OK, Great!
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
next prev parent reply other threads:[~2025-02-24 12:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-24 9:02 [mptcp-next v4 0/2] selftests: mptcp: add tests for increasing Gang Yan
2025-02-24 9:02 ` [mptcp-next v4 1/2] selftests: mptcp: Add a tool to get specific msk_info Gang Yan
2025-02-24 12:13 ` Matthieu Baerts
2025-02-24 9:02 ` [mptcp-next v4 2/2] selftests: mptcp: add a test for mptcp_diag_dump_one Gang Yan
2025-02-24 10:06 ` [mptcp-next v4 0/2] selftests: mptcp: add tests for increasing MPTCP CI
2025-02-24 12:13 ` Matthieu Baerts [this message]
2025-02-24 12:23 ` Matthieu Baerts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2eaec83-6f05-47f9-9a82-3fecb73e6966@kernel.org \
--to=matttbe@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=yangang@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.