From: Jens Axboe <axboe@kernel.dk>
To: Christian Brauner <brauner@kernel.org>, io-uring@vger.kernel.org
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: (subset) [PATCHSET v2 0/6] io_uring related epoll cleanups
Date: Fri, 15 May 2026 09:25:24 -0600 [thread overview]
Message-ID: <b2ecc3cf-12bf-470a-b30c-f89e64301629@kernel.dk> (raw)
In-Reply-To: <20260515-lachnummer-havarie-c6e68d7fe5ef@brauner>
On 5/15/26 9:08 AM, Christian Brauner wrote:
> On Thu, 14 May 2026 08:07:16 -0600, Jens Axboe wrote:
>> One of the nastier things about epoll is how it allows nesting contexts
>> inside each other, leading to the necessity of loop detection and the
>> issues that have come with that.
>>
>> I don't believe there's any reason to support nesting on the io_uring
>> side, in fact IORING_OP_EPOLL_CTL is a historical mistake, imho. But
>> let's at least try and contain the damage and disallow nested contexts
>> from our side.
>>
>> [...]
>
> @Jens, I added the epoll specific change to vfs-7.2.eventpoll. There
> were quite some merge conflicts now that I had to fix up. Please take a
> look and make sure it's sane. Otherwise I'm going to push this and will
> keep the branch stable.
I think your merge commit ended up messing it up, as you have
- static inline bool is_file_epoll(struct file *f)
-int is_file_epoll(struct file *f)
++bool is_file_epoll(struct file *f)
which now makes it return a bool, and the header has it as an int
still.
--
Jens Axboe
prev parent reply other threads:[~2026-05-15 15:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-14 14:07 [PATCHSET v2 0/6] io_uring related epoll cleanups Jens Axboe
2026-05-14 14:07 ` [PATCH 1/6] eventpoll: pass struct epoll_filefd through ep_find() and ep_insert() Jens Axboe
2026-05-14 14:07 ` [PATCH 2/6] eventpoll: export is_file_epoll() Jens Axboe
2026-05-14 14:07 ` [PATCH 3/6] eventpoll: add file based control interface Jens Axboe
2026-05-14 14:07 ` [PATCH 4/6] eventpoll: rename struct epoll_filefd to epoll_key Jens Axboe
2026-05-14 14:07 ` [PATCH 5/6] io_uring/epoll: switch to using do_epoll_ctl_file() interface Jens Axboe
2026-05-14 14:07 ` [PATCH 6/6] io_uring/epoll: disallow adding an epoll file to an epoll context Jens Axboe
2026-05-15 15:08 ` (subset) [PATCHSET v2 0/6] io_uring related epoll cleanups Christian Brauner
2026-05-15 15:25 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2ecc3cf-12bf-470a-b30c-f89e64301629@kernel.dk \
--to=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=io-uring@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.