From: Krzysztof Kozlowski <krzk@kernel.org>
To: devi priya <quic_devipriy@quicinc.com>,
bhelgaas@google.com, lpieralisi@kernel.org, kw@linux.com,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
andersson@kernel.org, konrad.dybcio@linaro.org,
mturquette@baylibre.com, sboyd@kernel.org,
manivannan.sadhasivam@linaro.org, linux-arm-msm@vger.kernel.org,
linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH V5 3/6] dt-bindings: PCI: qcom: Document the IPQ9574 PCIe controller.
Date: Mon, 13 May 2024 08:48:19 +0200 [thread overview]
Message-ID: <b3199f40-0983-4185-bd0c-2e2d45d690ad@kernel.org> (raw)
In-Reply-To: <20240512082858.1806694-4-quic_devipriy@quicinc.com>
On 12/05/2024 10:28, devi priya wrote:
>
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - qcom,pcie-ipq9574
> + then:
> + properties:
> + clocks:
> + minItems: 6
> + maxItems: 6
> + clock-names:
> + items:
> + - const: ahb # AHB clock
> + - const: aux # Auxiliary clock
> + - const: axi_m # AXI Master clock
> + - const: axi_s # AXI Slave clock
> + - const: axi_bridge # AXI bridge clock
> + - const: rchng
That's introducing one more order of clocks... Please keep it
consistent. The only existing case with ahb has it at after axi_m and
others. Why making things everytime differently?
I also to propose to finally drop the obvious comments, like "AHB
clock". It cannot be anything else. AXI Master / slave are descriptive,
so should stay.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-05-13 6:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-12 8:28 [PATCH V5 0/6] Add PCIe support for IPQ9574 devi priya
2024-05-12 8:28 ` [PATCH V5 1/6] Add PCIe pipe clock definitions for IPQ9574 SoC devi priya
2024-05-23 15:03 ` Bjorn Helgaas
2024-05-12 8:28 ` [PATCH V5 2/6] clk: qcom: gcc-ipq9574: Add PCIe pipe clocks devi priya
2024-05-12 8:28 ` [PATCH V5 3/6] dt-bindings: PCI: qcom: Document the IPQ9574 PCIe controller devi priya
2024-05-13 6:48 ` Krzysztof Kozlowski [this message]
2024-05-14 7:25 ` Manivannan Sadhasivam
2024-05-23 4:29 ` Devi Priya
2024-05-12 8:28 ` [PATCH V5 4/6] arm64: dts: qcom: ipq9574: Add PCIe PHYs and controller nodes devi priya
2024-05-14 7:39 ` Manivannan Sadhasivam
2024-05-23 7:07 ` Devi Priya
2024-05-12 8:28 ` [PATCH V5 5/6] arm64: dts: qcom: ipq9574: Enable PCIe PHYs and controllers devi priya
2024-05-12 8:28 ` [PATCH V5 6/6] PCI: qcom: Add support for IPQ9574 devi priya
2024-05-30 14:47 ` Manivannan Sadhasivam
2024-06-10 5:45 ` Devi Priya
2024-06-10 17:54 ` Manivannan Sadhasivam
2024-05-30 17:11 ` Bjorn Helgaas
2024-06-10 5:46 ` Devi Priya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3199f40-0983-4185-bd0c-2e2d45d690ad@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mturquette@baylibre.com \
--cc=quic_devipriy@quicinc.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.