From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vk1-f181.google.com (mail-vk1-f181.google.com [209.85.221.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88AB247254D for ; Thu, 6 Aug 2026 16:59:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786035590; cv=none; b=Db/c/rdE+3sieWW2kZ32//S2g29T/PvSJ40A2VyAmHFvoXQq7DjCO77l6Hb50DCyXX4IJZOTWyarecG0bjtxj0n5xaXKKcK8oakU7CFIhguhHDTQ0WdBCOMRO++QaJLlRqKUk1Wl+EnBHg0yuSICorI6MRuyJyTyNmzeZ3RK5VQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786035590; c=relaxed/simple; bh=oJD4nFEyaXWgVqYToy/GNwtnNE2Mg2QHu3WCWAeSWAs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=H6HMqCKeUhckAQOYeV0TKWyP9+vP41nOh0scba6uREojMK0VyjqjObiCxYXndYcFPEhsHya3iuddPw0tA2VPJCH3NbjK774PHgsoxh0O0iC6oQ+Q/KAu7Idf5P6QBK/OORIsoTkamtC9SPdTAwTdKxwdb/iFPHAexh/oNBaBSFw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=F4InoYPE; arc=none smtp.client-ip=209.85.221.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="F4InoYPE" Received: by mail-vk1-f181.google.com with SMTP id 71dfb90a1353d-5c3163a88a1so677868e0c.3 for ; Thu, 06 Aug 2026 09:59:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786035587; x=1786640387; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=i1O4+GTfBoV2V1bEoIh5L2jSUBNvl32w940uX7HvSIA=; b=F4InoYPEd7e4RlzP/rCzVMcbllbtFfDmi4H5AlZl4mehvdu9C6eLjw0+2rrfBHnw8k m/xCJRI93plaouBs7wlDC3LcUu3epffd9nlF5MBl+0Lgq/Yxu163lrMGKqBks2ONRENl rVWlq9pvvs63vIzhmUMVgK17woMEQrkTJGm14fIC6EXHS466O4AwDO3DdUnYnZIQeO1x 9CRcfjVMBROY4ylwdaVX6a1w1qF3kr5ZNYgoFWHHKnH8dbaNAoaPEKAdllMysktMZ3lw ykXd6Kr+y9IaeKi3VfIa+FCCLmP9vIgcuct6iNuWNdBeO82L41MdbGq3wAYRNPKUeBRb QBYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786035587; x=1786640387; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=i1O4+GTfBoV2V1bEoIh5L2jSUBNvl32w940uX7HvSIA=; b=lQ5QFv/9WKMCtDIvLrw4xn9nA1Q+cDvqTVT8sPU3dJeFJk6a/Xo1d5ViJj8GkZEYuG 4gQXIY+AjyFMwwhrthqoxffviRrMJUjFPMz01KhQzh+jisTKYWNBLSCDJsRMvHFJIHUB 60w5NYdFkvHSO8X4/7KpXxC2tfqTNlNTBEH0SIfq3IJv+zNbaubCHt1BhpFHZR/PC+NK yYeIWPA+/w6bIQNadXGMdLIFFT1giaTrxXrUjNfQpeHocq6zLxTWZFRfWd2hfgQnSRNL Z2pleO8Eo46m/TrB4fLhsc78TkVtiz2cY53U9tbbVqHeMoiO7/uH2tjJiF/JdEVru4Jw 2fvg== X-Forwarded-Encrypted: i=1; AHgh+Rp1Mtgiwn2IcftkOBMHHGAS5klyLTaBh4OVw/D7Q66uIrT2r+Py7VDor4Mw8lI2kSpYmTbJC/H3JJ7yZihu@vger.kernel.org X-Gm-Message-State: AOJu0YzCkbI5dlrqXA+sn53LhHRocyvrIk/bru204Pud5x2NUfu7uOH6 aFYyQbLOV8UzAXk9NYOm3ZYZuzZul9+Zet36tMt+2Uq+HJNQtkUwbB5y X-Gm-Gg: AR+sD13J4qOYqmCV3HrisEfxx5pKL3xJ1fExyF8cg+em2bK9oV7FIBOXoPnd8hVnC7z GSiubynLpdhRKH9ZzgG5UF2sqOEHlJJSZ/eX1s2j4VSxI4b1Pub1o27oKzUhYtKFdmBZoOYBaHm ro4i5bj6Od+WFUf1XWFyaEjtAVWx6eUF3jNk1up2CqtuY2HnigXxZeN5vw52Ub5YUfBKrZ81vbf EC92kUT7qOuLq/EgeOMhm55sCldRsEcDOvAfn7tqabyuhZhwGYa4w0vbDRh58VRY4xPLZOvBhZv 65hY4N2yxFZC3eQGjWM94PuvmoUvpa56zxjSPBt234MgNihbLuIhbrxUVQsxFcllaIxOa0lLJjY bAkHNh8GMZiZUEW4/MqzqgC9xS/6om4ENtQqxl7mAbV9ispDnaNQZIsgXvARf2yfRm8TlholM9F qBfDfg6YrdsH2vv5GIKADe8+XNfRcsfGfo4LaSPamzy+499Ht7lRyP7h6vGi+S3ZqV9YDzJzoQ4 nxSBNM= X-Received: by 2002:a05:6122:3a0c:b0:5c2:ac92:eb18 with SMTP id 71dfb90a1353d-5c3d919ab80mr2046889e0c.7.1786035586648; Thu, 06 Aug 2026 09:59:46 -0700 (PDT) Received: from syssplab.cs.fiu.edu (nat1.cs.fiu.edu. [131.94.134.89]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-5c3d05c594fsm3706321e0c.8.2026.08.06.09.59.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Aug 2026 09:59:45 -0700 (PDT) From: Chao Shi To: Jan Kara , Christian Brauner , Alexander Viro , Matthew Wilcox , linux-fsdevel@vger.kernel.org Cc: Theodore Ts'o , Andreas Dilger , Baokun Li , Ojaswin Mujoo , Ritesh Harjani , Zhang Yi , Zhang Yi , Bob Copeland , Namjae Jeon , Sungjong Seo , Yuezhang Mo , OGAWA Hirofumi , Mark Fasheh , Joel Becker , Joseph Qi , Andreas Gruenbacher , linux-ext4@vger.kernel.org, ocfs2-devel@lists.linux.dev, gfs2@lists.linux.dev, linux-kernel@vger.kernel.org, Chao Shi , Weidong Zhu Subject: [PATCH v2 10/21] omfs: check for an inode write error with buffer_write_io_error() Date: Thu, 6 Aug 2026 12:58:33 -0400 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit __omfs_write_inode() spots a failed synchronous write, on both the primary block and each mirror, by testing BH_Req together with !BH_Uptodate. That relies on the write completion handler clearing BH_Uptodate on error, which this series removes: a buffer whose write failed still holds the data the filesystem asked to be written, so declaring it not up to date is wrong and makes callers re-read it. BH_Write_EIO says exactly what this code wants to know, and it implies BH_Req, so each pair collapses into one test. No behaviour change today - a failed write sets BH_Write_EIO and clears BH_Uptodate together. It stops being a no-op at the end of the series, where the new test is the one that still works. Acked-by: Weidong Zhu Signed-off-by: Chao Shi --- fs/omfs/inode.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/omfs/inode.c b/fs/omfs/inode.c index 1d915ef72119..bc37029a4afb 100644 --- a/fs/omfs/inode.c +++ b/fs/omfs/inode.c @@ -145,7 +145,7 @@ static int __omfs_write_inode(struct inode *inode, int wait) mark_buffer_dirty(bh); if (wait) { sync_dirty_buffer(bh); - if (buffer_req(bh) && !buffer_uptodate(bh)) + if (buffer_write_io_error(bh)) sync_failed = 1; } @@ -159,7 +159,7 @@ static int __omfs_write_inode(struct inode *inode, int wait) mark_buffer_dirty(bh2); if (wait) { sync_dirty_buffer(bh2); - if (buffer_req(bh2) && !buffer_uptodate(bh2)) + if (buffer_write_io_error(bh2)) sync_failed = 1; } brelse(bh2); -- 2.43.0