All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Wang, Wei W" <wei.w.wang@intel.com>
To: David Hildenbrand <david@redhat.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: "mst@redhat.com" <mst@redhat.com>,
	"dgilbert@redhat.com" <dgilbert@redhat.com>,
	"peterx@redhat.com" <peterx@redhat.com>,
	"quintela@redhat.com" <quintela@redhat.com>
Subject: RE: [PATCH v3] migration: clear the memory region dirty bitmap when skipping free pages
Date: Thu, 22 Jul 2021 09:57:13 +0000	[thread overview]
Message-ID: <b39f279ef6634325ab2be8d903e41001@intel.com> (raw)
In-Reply-To: <0faf5f01-399f-621f-431e-d35b3e87b9ff@redhat.com>

On Thursday, July 22, 2021 5:48 PM, David Hildenbrand wrote:
> On 22.07.21 10:30, Wei Wang wrote:
> > When skipping free pages to send, their corresponding dirty bits in
> > the memory region dirty bitmap need to be cleared. Otherwise the
> > skipped pages will be sent in the next round after the migration
> > thread syncs dirty bits from the memory region dirty bitmap.
> >
> > Cc: David Hildenbrand <david@redhat.com>
> > Cc: Peter Xu <peterx@redhat.com>
> > Cc: Michael S. Tsirkin <mst@redhat.com>
> > Reported-by: David Hildenbrand <david@redhat.com>
> > Signed-off-by: Wei Wang <wei.w.wang@intel.com>
> > ---
> >   migration/ram.c | 74
> +++++++++++++++++++++++++++++++++++++------------
> >   1 file changed, 56 insertions(+), 18 deletions(-)
> >
> 
> LGTM, thanks
> 
> Reviewed-by: David Hildenbrand <david@redhat.com>
> 

Thanks. Please remember to have a regression test together with Peterx's that patch when you get a chance.

Best,
Wei

  reply	other threads:[~2021-07-22  9:58 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-22  8:30 [PATCH v3] migration: clear the memory region dirty bitmap when skipping free pages Wei Wang
2021-07-22  9:47 ` David Hildenbrand
2021-07-22  9:57   ` Wang, Wei W [this message]
2021-07-22 14:51     ` Peter Xu
2021-07-22 14:51       ` David Hildenbrand
2021-07-22 17:41         ` Peter Xu
2021-07-23  7:50           ` David Hildenbrand
2021-07-23  8:14             ` Wang, Wei W
2021-07-23  8:16               ` David Hildenbrand
2021-07-23  8:32                 ` Wang, Wei W
2021-07-23 12:51             ` Peter Xu
2021-07-23 12:52               ` David Hildenbrand
2021-07-23  8:03       ` David Hildenbrand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b39f279ef6634325ab2be8d903e41001@intel.com \
    --to=wei.w.wang@intel.com \
    --cc=david@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=mst@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.