From: John Garry <john.g.garry@oracle.com>
To: Eric Biggers <ebiggers@kernel.org>,
Kent Overstreet <kent.overstreet@linux.dev>
Cc: linux-fsdevel@vger.kernel.org, linux-bcachefs@vger.kernel.org,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
Josef Bacik <josef@toxicpanda.com>,
Miklos Szeredi <mszeredi@redhat.com>,
Christian Brauner <brauner@kernel.org>,
David Howells <dhowells@redhat.com>
Subject: Re: [PATCH v2] statx: stx_subvol
Date: Tue, 28 May 2024 13:46:39 +0100 [thread overview]
Message-ID: <b3b02658-ffc4-4bd9-b77a-af65ae359474@oracle.com> (raw)
In-Reply-To: <20240312021308.GA1182@sol.localdomain>
On 12/03/2024 02:13, Eric Biggers wrote:
> On Thu, Mar 07, 2024 at 09:29:12PM -0500, Kent Overstreet wrote:
>> __u32 stx_dio_mem_align; /* Memory buffer alignment for direct I/O */
>> __u32 stx_dio_offset_align; /* File offset alignment for direct I/O */
>> + __u64 stx_subvol; /* Subvolume identifier */
>> /* 0xa0 */
>> - __u64 __spare3[12]; /* Spare space for future expansion */
>> + __u64 __spare3[11]; /* Spare space for future expansion */
>> /* 0x100 */
> The /* 0xa0 */ comment needs to be updated (or deleted).
I would tend to agree. Was this intentionally not updated (or deleted)?
next prev parent reply other threads:[~2024-05-28 12:46 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-08 2:29 [PATCH v2] statx: stx_subvol Kent Overstreet
2024-03-08 11:42 ` Neal Gompa
2024-03-08 16:34 ` Kent Overstreet
2024-03-08 16:44 ` Neal Gompa
2024-03-08 16:48 ` Kent Overstreet
2024-03-08 16:56 ` Darrick J. Wong
2024-03-08 17:13 ` Kent Overstreet
2024-03-09 11:46 ` Jeff Layton
2024-03-09 12:15 ` Kent Overstreet
2024-03-11 2:17 ` Dave Chinner
2024-03-11 5:30 ` Miklos Szeredi
2024-03-11 5:49 ` Kent Overstreet
2024-03-11 13:42 ` Christian Brauner
2024-03-11 8:12 ` Johannes Thumshirn
2024-03-11 13:43 ` Christian Brauner
2024-03-11 20:15 ` Kent Overstreet
2024-03-12 14:27 ` Christian Brauner
2024-03-11 22:43 ` David Sterba
2024-03-12 14:27 ` Christian Brauner
2024-03-12 17:17 ` Neal Gompa
2024-03-12 2:13 ` Eric Biggers
2024-05-28 12:46 ` John Garry [this message]
2024-05-28 22:11 ` Andreas Dilger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3b02658-ffc4-4bd9-b77a-af65ae359474@oracle.com \
--to=john.g.garry@oracle.com \
--cc=brauner@kernel.org \
--cc=dhowells@redhat.com \
--cc=ebiggers@kernel.org \
--cc=josef@toxicpanda.com \
--cc=kent.overstreet@linux.dev \
--cc=linux-bcachefs@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mszeredi@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.