From: Bhaumik Bhatt <bbhatt@codeaurora.org>
To: Jeffrey Hugo <jhugo@codeaurora.org>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
linux-arm-msm@vger.kernel.org, hemantk@codeaurora.org,
linux-kernel@vger.kernel.org,
jhugo=codeaurora.org@codeaurora.org
Subject: Re: [PATCH v1 04/10] bus: mhi: core: Use the IRQF_ONESHOT flag for the BHI interrupt line
Date: Mon, 12 Oct 2020 16:52:17 -0700 [thread overview]
Message-ID: <b3ba694d03469e767f1e82260cb8a006@codeaurora.org> (raw)
In-Reply-To: <26de08b5-b477-c5b9-fdca-eb80bcf98561@codeaurora.org>
On 2020-10-09 09:04, Jeffrey Hugo wrote:
> On 10/9/2020 9:57 AM, Manivannan Sadhasivam wrote:
>> On Fri, Sep 18, 2020 at 07:02:29PM -0700, Bhaumik Bhatt wrote:
>>> Remove the IRQF_SHARED flag as it is not needed for the BHI interrupt
>>> and replace it with IRQF_ONESHOT so that host can be sure that the
>>> next BHI hard interrupt is triggered only when the threaded interrupt
>>> handler has returned. This is to avoid any race conditions we may run
>>> into if BHI interrupts fire one after another.
>>>
>>> Signed-off-by: Bhaumik Bhatt <bbhatt@codeaurora.org>
>>> ---
>>> drivers/bus/mhi/core/init.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/bus/mhi/core/init.c
>>> b/drivers/bus/mhi/core/init.c
>>> index ca32563..9ae4c19 100644
>>> --- a/drivers/bus/mhi/core/init.c
>>> +++ b/drivers/bus/mhi/core/init.c
>>> @@ -167,7 +167,7 @@ int mhi_init_irq_setup(struct mhi_controller
>>> *mhi_cntrl)
>>> /* Setup BHI_INTVEC IRQ */
>>> ret = request_threaded_irq(mhi_cntrl->irq[0], mhi_intvec_handler,
>>> mhi_intvec_threaded_handler,
>>> - IRQF_SHARED | IRQF_NO_SUSPEND,
>>> + IRQF_ONESHOT | IRQF_NO_SUSPEND,
>>
>> Jeff, I believe you're the one requested for shared irq during initial
>> push.
>> Are you okay with this?
>
> Nope :)
>
> AIC100 has a single interrupt for BHI/MHI activity, so this needs to be
> shared.
Did not account for this. Will drop this patch.
Thanks,
Bhaumik
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
Forum, a
Linux Foundation Collaborative Project
next prev parent reply other threads:[~2020-10-12 23:53 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-19 2:02 [PATCH v1 00/10] Bug fixes and improvements for MHI power operations Bhaumik Bhatt
2020-09-19 2:02 ` [PATCH v1 01/10] bus: mhi: core: Use appropriate names for firmware load functions Bhaumik Bhatt
2020-10-09 15:23 ` Manivannan Sadhasivam
2020-09-19 2:02 ` [PATCH v1 02/10] bus: mhi: core: Move to using high priority workqueue Bhaumik Bhatt
2020-10-09 15:49 ` Manivannan Sadhasivam
2020-09-19 2:02 ` [PATCH v1 03/10] bus: mhi: core: Skip device wake in error or shutdown states Bhaumik Bhatt
2020-10-09 15:54 ` Manivannan Sadhasivam
2020-09-19 2:02 ` [PATCH v1 04/10] bus: mhi: core: Use the IRQF_ONESHOT flag for the BHI interrupt line Bhaumik Bhatt
2020-10-09 15:57 ` Manivannan Sadhasivam
2020-10-09 16:04 ` Jeffrey Hugo
2020-10-12 23:52 ` Bhaumik Bhatt [this message]
2020-09-19 2:02 ` [PATCH v1 05/10] bus: mhi: core: Disable IRQs when powering down Bhaumik Bhatt
2020-10-09 16:02 ` Manivannan Sadhasivam
2020-10-13 0:03 ` Bhaumik Bhatt
2020-10-10 23:45 ` Manu Gautam
2020-09-19 2:02 ` [PATCH v1 06/10] bus: mhi: core: Improve shutdown handling after link down detection Bhaumik Bhatt
2020-10-09 16:19 ` Manivannan Sadhasivam
2020-10-13 18:40 ` Bhaumik Bhatt
2020-10-11 0:06 ` Manu Gautam
2020-09-19 2:02 ` [PATCH v1 07/10] bus: mhi: core: Move to SYS_ERROR regardless of RDDM capability Bhaumik Bhatt
2020-10-09 16:32 ` Manivannan Sadhasivam
2020-10-14 1:06 ` Bhaumik Bhatt
2020-09-19 2:02 ` [PATCH v1 08/10] bus: mhi: core: Move to an error state on any firmware load failure Bhaumik Bhatt
2020-10-09 16:42 ` Manivannan Sadhasivam
2020-10-14 1:37 ` Bhaumik Bhatt
2020-09-19 2:02 ` [PATCH v1 09/10] bus: mhi: core: Move to an error state on mission mode failure Bhaumik Bhatt
2020-10-09 16:44 ` Manivannan Sadhasivam
2020-09-19 2:02 ` [PATCH v1 10/10] bus: mhi: core: Mark device inactive soon after host issues a shutdown Bhaumik Bhatt
2020-10-09 17:18 ` Manivannan Sadhasivam
2020-10-11 0:17 ` Manu Gautam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3ba694d03469e767f1e82260cb8a006@codeaurora.org \
--to=bbhatt@codeaurora.org \
--cc=hemantk@codeaurora.org \
--cc=jhugo=codeaurora.org@codeaurora.org \
--cc=jhugo@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.