From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 5B652E00E07; Wed, 24 Jul 2019 12:29:17 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_MED, URI_HEX autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, * medium trust * [198.47.19.141 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * 0.1 URI_HEX URI: URI hostname has long hexadecimal sequence * -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's * domain * -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature * 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily * valid Received: from fllv0015.ext.ti.com (fllv0015.ext.ti.com [198.47.19.141]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 9D5AFE00DD7 for ; Wed, 24 Jul 2019 12:29:16 -0700 (PDT) Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id x6OJTGQv080384 for ; Wed, 24 Jul 2019 14:29:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1563996556; bh=XTgZdutgGVN5eu7YZlD0uH5Ghat9yVBvuLpI2cueHtw=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=HA9IJto++4NHwI8Q8bqLUz0jsLCF47J/eqXDRuWGzo9+dTApM/3ABsTY+Wcq7/B7X o85Lvged8XPZOtTSStCzaVjyuFVlsScAKUnVdTNYAxHUXLM54lwSD0Dsg1umDlkhjR 1VjObgu4dhHMmGpjja1Sp+8hPbCMGNoaIONtIk2w= Received: from DFLE114.ent.ti.com (dfle114.ent.ti.com [10.64.6.35]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x6OJTGgM089234 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 24 Jul 2019 14:29:16 -0500 Received: from DFLE113.ent.ti.com (10.64.6.34) by DFLE114.ent.ti.com (10.64.6.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Wed, 24 Jul 2019 14:29:15 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DFLE113.ent.ti.com (10.64.6.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Wed, 24 Jul 2019 14:29:15 -0500 Received: from [10.250.86.29] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id x6OJTFrf006356; Wed, 24 Jul 2019 14:29:15 -0500 To: Denys Dmytriyenko References: <20190719210619.18583-1-afd@ti.com> <20190719210619.18583-2-afd@ti.com> <20190724192429.GF5700@beryl> From: "Andrew F. Davis" Message-ID: Date: Wed, 24 Jul 2019 15:29:15 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190724192429.GF5700@beryl> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Cc: meta-ti@yoctoproject.org Subject: Re: [thud/master][RFC PATCH 2/3] ti-sgx-ddk-um: Add expat as runtime dependency X-BeenThere: meta-ti@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Usage and development list for the meta-ti layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Jul 2019 19:29:17 -0000 Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit On 7/24/19 3:24 PM, Denys Dmytriyenko wrote: > On Fri, Jul 19, 2019 at 05:06:18PM -0400, Andrew F. Davis wrote: >> Although not needed for the IMG default EGL implementation libexpat >> is needed when using the Mesa EGL version. > > Yes, and Rogue has it in RDEPENDS, as it uses Mesa. Why would SGX need it? > I have SGX using Mesa now, we get some EGL extensions and much closer to EGL1.5 support. > >> While here s/libudev/udev as 'libudev' is package shipped as part of the >> eudev project, but we use systemd, so we actually depend on 'udev'. > > And systemd also provides libudev. From run-time dependency, we really require > libudev, not udev. As udev is just a daemon and bunch of config files - there > is nothing to run-time depend on in there... > That's rather confusing.., will drop change for v2 > >> Move the PACKAGE_ARCH and PR defines to a more natural spot that also >> lines up with the RGX version of recipe for easier diffs. >> >> One thing we could have done is remove the DEPENDS line. We do not have >> any build dependencies as these are pre-made library binaries, but I use >> the package rootfs generated by bitbake to build the binaries locally, >> so leave it for now. > > Is this detail really necessary for the commit message? > Nope, just extra for the RFC, will drop from final. Andrew > >> Signed-off-by: Andrew F. Davis >> --- >> recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb b/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb >> index 3c0242e2..a1e35b52 100644 >> --- a/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb >> +++ b/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb >> @@ -3,9 +3,10 @@ HOMEPAGE = "https://git.ti.com/graphics/omap5-sgx-ddk-um-linux" >> LICENSE = "TI-TSPA" >> LIC_FILES_CHKSUM = "file://TI-Linux-Graphics-DDK-UM-Manifest.doc;md5=b17390502bc89535c86cfbbae961a2a8" >> >> +PACKAGE_ARCH = "${MACHINE_ARCH}" >> COMPATIBLE_MACHINE = "ti33x|ti43x|omap-a15|k3" >> >> -PACKAGE_ARCH = "${MACHINE_ARCH}" >> +PR = "r33" >> >> BRANCH = "ti-img-sgx/thud/${PV}" >> >> @@ -22,11 +23,10 @@ INITSCRIPT_PARAMS = "defaults 8" >> >> inherit update-rc.d >> >> -PR = "r33" >> PROVIDES += "virtual/egl virtual/libgles1 virtual/libgles2 virtual/libgbm omap5-sgx-ddk-um-linux" >> >> -DEPENDS += "libdrm udev wayland libffi" >> -RDEPENDS_${PN} += "libdrm libudev wayland libffi libdrm-omap" >> +DEPENDS += "libdrm udev wayland libffi expat" >> +RDEPENDS_${PN} += "libdrm libdrm-omap udev wayland libffi expat" >> >> RPROVIDES_${PN} = "libegl libgles1 libgles2 libgbm omap5-sgx-ddk-um-linux" >> RPROVIDES_${PN}-dev = "libegl-dev libgles1-dev libgles2-dev libgbm-dev omap5-sgx-ddk-um-linux-dev" >> -- >> 2.17.1 >>