From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8C7B6CD1284 for ; Tue, 2 Apr 2024 14:01:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6PVDg+TVj+cDOVGqalgyJj87wb/64Xq+Vkhdx8tbJc8=; b=d7jyB4bTBfDg15 dPrZZeiQfZ02fFSDcTSd2aC4YYn39yIYNfjAwab+Z6RS8iR7WUAuEkwx86Aiyqha7VBAWMT++SfH+ QF/gmc4fPupEwf3EN0iFtEGIi886uXPw69EMZpN2FsyoGLUqHdD7p3F3glwNJlNkgbgnBMCljZMXS dGTJ+a3+72SLqsl5363XmWash98cALISQLvuNbBRq9GarRtw9jmmmstYwyRb2/TqZVOP0BmONoaa4 LIcwubhT98D8oY6jSJFGxvvfoVajV07PQjTx0hs/4Xy81Is0jqG+ri8eoUSq+HOgMjU4ZeDHk/V75 APQjkLqCQxfIHuBeFR3w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rregv-0000000BTpk-1uWN; Tue, 02 Apr 2024 14:00:45 +0000 Received: from esa.microchip.iphmx.com ([68.232.153.233]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rregs-0000000BToq-0GBJ for linux-arm-kernel@lists.infradead.org; Tue, 02 Apr 2024 14:00:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1712066442; x=1743602442; h=message-id:subject:from:to:cc:date:in-reply-to: references:content-transfer-encoding:mime-version; bh=qsST0ylz6gOANXRGsGFqczoAFStFcUOplO5NxDoGV7U=; b=Wt7y+0wFedGbp3EwEx+G3cxD9hHUfpMbs6rs6qy9lrRqI8k72IAjNU48 Y3mPZQKesGGBs42fHJIkDjY2IpwNDIc5utFcN5zsIyaiqqsS3oRJZGVKR euzJTzigXgdAtDGd9GaNWpReHOWf7lp7ODH4EslrSgT0RWfI4cj6sLXAf AUOeXkprKUF2d6ARWiaKisOAfUFj8x1fDgIBw+U2YB4Wzqur/ksZJuw3d fouTOqph911rLnjo87HHoiijzKCJT7clnLhHnfqJZYmwYL0Nl/62DpngB N06WSMGXNWZ6dxFwihiHH9o7GTml2nic6K/ygDELrpzQBdLAFzLFDhJ7A g==; X-CSE-ConnectionGUID: FQZgR+amRMal/fXHX2p5Mw== X-CSE-MsgGUID: 8c+KslA7TH6D+wDEUkqJTQ== X-IronPort-AV: E=Sophos;i="6.07,175,1708412400"; d="scan'208";a="19169899" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa3.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 02 Apr 2024 07:00:37 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 2 Apr 2024 07:00:35 -0700 Received: from DEN-DL-M31857.microsemi.net (10.10.85.11) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server id 15.1.2507.35 via Frontend Transport; Tue, 2 Apr 2024 07:00:33 -0700 Message-ID: Subject: Re: [PATCH RFT 01/10] arm64: dts: microchip: sparx5: fix mdio reg From: Steen Hegelund To: Krzysztof Kozlowski Date: Tue, 2 Apr 2024 16:00:32 +0200 In-Reply-To: <20240401153740.123978-1-krzk@kernel.org> References: <20240401153740.123978-1-krzk@kernel.org> User-Agent: Evolution 3.44.4-0ubuntu2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240402_070042_184978_5FD7B7BE X-CRM114-Status: GOOD ( 19.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , Daniel Machon , Bjarni Jonasson , linux-kernel@vger.kernel.org, Conor Dooley , Claudiu Beznea , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , UNGLinuxDriver@microchip.com, "David S. Miller" , Lars Povlsen Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgS3J6eXN6dG9mLAoKCk9uIE1vbiwgMjAyNC0wNC0wMSBhdCAxNzozNyArMDIwMCwgS3J6eXN6 dG9mIEtvemxvd3NraSB3cm90ZToKPiBbU29tZSBwZW9wbGUgd2hvIHJlY2VpdmVkIHRoaXMgbWVz c2FnZSBkb24ndCBvZnRlbiBnZXQgZW1haWwgZnJvbQo+IGtyemtAa2VybmVsLm9yZy4gTGVhcm4g d2h5IHRoaXMgaXMgaW1wb3J0YW50IGF0Cj4gaHR0cHM6Ly9ha2EubXMvTGVhcm5BYm91dFNlbmRl cklkZW50aWZpY2F0aW9uwqBdCj4gCj4gRVhURVJOQUwgRU1BSUw6IERvIG5vdCBjbGljayBsaW5r cyBvciBvcGVuIGF0dGFjaG1lbnRzIHVubGVzcyB5b3UKPiBrbm93IHRoZSBjb250ZW50IGlzIHNh ZmUKPiAKPiBDb3JyZWN0IHRoZSByZWcgYWRkcmVzcyBvZiBtZGlvIG5vZGUgdG8gbWF0Y2ggdW5p dCBhZGRyZXNzLsKgIEFzc3VtZQo+IHRoZQo+IHJlZyBpcyBub3QgY29ycmVjdCBhbmQgdW5pdCBh ZGRyZXNzIHdhcyBjb3JyZWN0LCBiZWNhdXNlIHRoZXJlIGlzCj4gYWxlcmFkeSBub2RlIHVzaW5n IHRoZSBleGlzdGluZyByZWcgMHgxMTAxMDJkNC4KPiAKPiDCoCBzcGFyeDUuZHRzaTo0NDMuMjUt NDUxLjU6IFdhcm5pbmcgKHNpbXBsZV9idXNfcmVnKToKPiAvYXhpQDYwMDAwMDAwMC9tZGlvQDYx MTAxMDJmODogc2ltcGxlLWJ1cyB1bml0IGFkZHJlc3MgZm9ybWF0IGVycm9yLAo+IGV4cGVjdGVk ICI2MTEwMTAyZDQiCj4gCj4gRml4ZXM6IGQwZjQ4MmJiMDZmOSAoImFybTY0OiBkdHM6IHNwYXJ4 NTogQWRkIHRoZSBTcGFyeDUgc3dpdGNoCj4gbm9kZSIpCj4gU2lnbmVkLW9mZi1ieTogS3J6eXN6 dG9mIEtvemxvd3NraSA8a3J6a0BrZXJuZWwub3JnPgo+IAo+IC0tLQo+IAo+IE5vdCB0ZXN0ZWQg b24gaGFyZHdhcmUKPiAtLS0KPiDCoGFyY2gvYXJtNjQvYm9vdC9kdHMvbWljcm9jaGlwL3NwYXJ4 NS5kdHNpIHwgMiArLQo+IMKgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0 aW9uKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2FyY2gvYXJtNjQvYm9vdC9kdHMvbWljcm9jaGlwL3Nw YXJ4NS5kdHNpCj4gYi9hcmNoL2FybTY0L2Jvb3QvZHRzL21pY3JvY2hpcC9zcGFyeDUuZHRzaQo+ IGluZGV4IDI0MDc1Y2Q5MTQyMC4uNWQ4MjBkYThjNjlkIDEwMDY0NAo+IC0tLSBhL2FyY2gvYXJt NjQvYm9vdC9kdHMvbWljcm9jaGlwL3NwYXJ4NS5kdHNpCj4gKysrIGIvYXJjaC9hcm02NC9ib290 L2R0cy9taWNyb2NoaXAvc3Bhcng1LmR0c2kKPiBAQCAtNDQ3LDcgKzQ0Nyw3IEBAIG1kaW8yOiBt ZGlvQDYxMTAxMDJmOCB7Cj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoCBwaW5jdHJsLW5hbWVzID0gImRlZmF1bHQiOwo+IMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgI2FkZHJlc3MtY2VsbHMgPSA8MT47Cj4gwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAjc2l6ZS1jZWxscyA9IDww PjsKPiAtwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcmVnID0g PDB4NiAweDExMDEwMmQ0IDB4MjQ+Owo+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoCByZWcgPSA8MHg2IDB4MTEwMTAyZjggMHgyND47Cj4gwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgIH07Cj4gCj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg IG1kaW8zOiBtZGlvQDYxMTAxMDMxYyB7Cj4gLS0KPiAyLjM0LjEKPiAKCkkgZGlkIGEgY2hlY2sg b2Ygb3VyIGN1cnJlbnQgU3Bhcng1IEVWQnMgYW5kIG5vbmUgb2YgdGhlbSB1c2VzCmNvbnRyb2xs ZXIgMiBpbiBhbnkgcmV2aXNpb24sIHNvIHRoaXMgaXMgcHJvYmFibHkgd2h5IGl0IGhhcyBub3Qg Y29tZQp1cCBiZWZvcmUsIHNvIGFzIGl0IHN0YW5kcyB3ZSBoYXZlIG5vIHBsYXRmb3JtIHRvIHRl c3QgdGhpcyBjaGFuZ2Ugb24KY3VycmVudGx5LgoKQmVzaWRlcyB0aGF0IHRoZSBjaGFuZ2UgbG9v a3MgZ29vZCB0byBtZS4KCkJlc3QgUmVnYXJkcwpTdGVlbgoKUmV2aWV3ZWQtYnk6IFN0ZWVuIEhl Z2VsdW5kIDxTdGVlbi5IZWdlbHVuZEBtaWNyb2NoaXAuY29tPgoKCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcg bGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmlu ZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.153.233]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CEDE385639; Tue, 2 Apr 2024 14:00:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=68.232.153.233 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712066440; cv=none; b=IWM9YK88PKrSXjDU5InSLftYPt3WLjUH21GU9RcyuNBdQM0sjaUa+NyG2kfGxNZIHetOVCejAvoz9t5eTJETGbsoDRssrT6yzZaPBph6SLp1vRLfQOPwA6JfRrDgELhVvEXRKkoJ6+rblM6bKQfPp2Ssj+2ItFtlolZ+qQyAhIg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712066440; c=relaxed/simple; bh=qsST0ylz6gOANXRGsGFqczoAFStFcUOplO5NxDoGV7U=; h=Message-ID:Subject:From:To:CC:Date:In-Reply-To:References: Content-Type:MIME-Version; b=C0MaAdWvZMlWqqkYFMI1ZsJf1JLB/4goOXO9u5OeVGEyPLSaUF5n3EF3pg8hZZi7k+rm2XFU4pyr39KPTbuRGcJ84n7e2g103pc5nVvrylpXEmUuv/YNjcJthDJrNmhnj/ZC/wU/eGRygxpjzEYh2JLmR+JwIugPKUGVzZ0jE2c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=microchip.com; spf=pass smtp.mailfrom=microchip.com; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b=1K/27f1q; arc=none smtp.client-ip=68.232.153.233 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=microchip.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=microchip.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="1K/27f1q" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1712066438; x=1743602438; h=message-id:subject:from:to:cc:date:in-reply-to: references:content-transfer-encoding:mime-version; bh=qsST0ylz6gOANXRGsGFqczoAFStFcUOplO5NxDoGV7U=; b=1K/27f1qJ0aJ/VMY9DZCAMala9HzpzdZxIpqluoufgxI16a/RL5fUvwt cSMPOgk0yhL0xe1LN11ugXrtlLZqgwc6k1Lq/4xFQLmAO9bCidNiTtDqx 9hZJxpgDkSh4y6dKcO/IlDdZexQEN0R4TaQ5AgG83yMBqr3WsShM9M/Nl CdPzK3RYXre/Dq28wqRuHSE1PZWiu9NIV70373cC3jRMYQXrUreddtTXz 3Od2pallLfWqsJQ7Y8l4xRLZsKyn3EXinjS2qNmpjHJG9rh71PLHD8mM3 NiLc2GuZe541Sh3tehvs3BsF6eDQndBsGlCV+cv3DfxVfSFaORGfLS1/E g==; X-CSE-ConnectionGUID: FQZgR+amRMal/fXHX2p5Mw== X-CSE-MsgGUID: 8c+KslA7TH6D+wDEUkqJTQ== X-IronPort-AV: E=Sophos;i="6.07,175,1708412400"; d="scan'208";a="19169899" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa3.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 02 Apr 2024 07:00:37 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 2 Apr 2024 07:00:35 -0700 Received: from DEN-DL-M31857.microsemi.net (10.10.85.11) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server id 15.1.2507.35 via Frontend Transport; Tue, 2 Apr 2024 07:00:33 -0700 Message-ID: Subject: Re: [PATCH RFT 01/10] arm64: dts: microchip: sparx5: fix mdio reg From: Steen Hegelund To: Krzysztof Kozlowski CC: Nicolas Ferre , Claudiu Beznea , Rob Herring , "Krzysztof Kozlowski" , Lars Povlsen , Daniel Machon , , "David S. Miller" , Bjarni Jonasson , , , , Conor Dooley Date: Tue, 2 Apr 2024 16:00:32 +0200 In-Reply-To: <20240401153740.123978-1-krzk@kernel.org> References: <20240401153740.123978-1-krzk@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.4-0ubuntu2 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi Krzysztof, On Mon, 2024-04-01 at 17:37 +0200, Krzysztof Kozlowski wrote: > [Some people who received this message don't often get email from > krzk@kernel.org. Learn why this is important at > https://aka.ms/LearnAboutSenderIdentification=C2=A0] >=20 > EXTERNAL EMAIL: Do not click links or open attachments unless you > know the content is safe >=20 > Correct the reg address of mdio node to match unit address.=C2=A0 Assume > the > reg is not correct and unit address was correct, because there is > alerady node using the existing reg 0x110102d4. >=20 > =C2=A0 sparx5.dtsi:443.25-451.5: Warning (simple_bus_reg): > /axi@600000000/mdio@6110102f8: simple-bus unit address format error, > expected "6110102d4" >=20 > Fixes: d0f482bb06f9 ("arm64: dts: sparx5: Add the Sparx5 switch > node") > Signed-off-by: Krzysztof Kozlowski >=20 > --- >=20 > Not tested on hardware > --- > =C2=A0arch/arm64/boot/dts/microchip/sparx5.dtsi | 2 +- > =C2=A01 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/arch/arm64/boot/dts/microchip/sparx5.dtsi > b/arch/arm64/boot/dts/microchip/sparx5.dtsi > index 24075cd91420..5d820da8c69d 100644 > --- a/arch/arm64/boot/dts/microchip/sparx5.dtsi > +++ b/arch/arm64/boot/dts/microchip/sparx5.dtsi > @@ -447,7 +447,7 @@ mdio2: mdio@6110102f8 { > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 pinctrl-= names =3D "default"; > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 #address= -cells =3D <1>; > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 #size-ce= lls =3D <0>; > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 reg =3D <0x6 0= x110102d4 0x24>; > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 reg =3D <0x6 0= x110102f8 0x24>; > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 }; >=20 > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 mdio3: mdio@61101031c { > -- > 2.34.1 >=20 I did a check of our current Sparx5 EVBs and none of them uses controller 2 in any revision, so this is probably why it has not come up before, so as it stands we have no platform to test this change on currently. Besides that the change looks good to me. Best Regards Steen Reviewed-by: Steen Hegelund