From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6DB67C282EC for ; Tue, 11 Mar 2025 09:23:38 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.907505.1314732 (Exim 4.92) (envelope-from ) id 1trvpV-0006Qw-PU; Tue, 11 Mar 2025 09:23:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 907505.1314732; Tue, 11 Mar 2025 09:23:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1trvpV-0006Qp-MU; Tue, 11 Mar 2025 09:23:17 +0000 Received: by outflank-mailman (input) for mailman id 907505; Tue, 11 Mar 2025 09:23:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1trvpU-0006PY-Bk for xen-devel@lists.xenproject.org; Tue, 11 Mar 2025 09:23:16 +0000 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [2a00:1450:4864:20::330]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 759a0a6c-fe5a-11ef-9898-31a8f345e629; Tue, 11 Mar 2025 10:23:14 +0100 (CET) Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-43cfe63c592so13537275e9.2 for ; Tue, 11 Mar 2025 02:23:14 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43d01d52582sm26261625e9.4.2025.03.11.02.23.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Mar 2025 02:23:13 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 759a0a6c-fe5a-11ef-9898-31a8f345e629 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1741684994; x=1742289794; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=/E48EJjKAda6GgF2NXXxln++ydiCrFAJy7BswZnKIWs=; b=JCsrPoStzk2lPyw0/vxanbZfBj6hVYnHi0uWwD8I4v2FOH4vIc8BzpqT8JNpcGytjU eoA7LrHqUYiLvgco+VvdsDtQ27A8QnXNEu6JCGpaY/JunyGlk81lVo2t1j8k7VTMvSqi ui9U1xhlInNFARtkE6WkTsXRg+2a2auIjogDj4j4utIk11iy+PhsBKThL7wENB+eWccC xKR5WBOuQKzglIJWisPQNs4XT7/OCfKO2YCS9Cjo2JhQOUICrFm6eh2iztWLR+dGc7aG hC7igxM0UnOt9kVPfZWGqKZn/DtJbm73Gmy4QzYbS0tpPUFZ72+SLmfv0+F24gKv01lm T7BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741684994; x=1742289794; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/E48EJjKAda6GgF2NXXxln++ydiCrFAJy7BswZnKIWs=; b=sQIjaJWHZahrjVSt6+1G2MPUpHqNwJG8wl74o3Z6cp249rNyV4okGo5hnF38NUTbrP sUzzEQhX29/29a/T10rstgeRSicKVHyE2qGt/ygfhY/EV3FmqdwERUf+XyO0PCKjIBy6 tl8+2Jja5tV15cJ0umbl94c9JaBrpha+rBCP1n+L+fXfBEB+iGS5m1NR0G8EW1/Nv/gY IAu1Nct8a9/YaRYETgQIVfMtCVWS6aqm7tZ89ssxFp9DxExO0vlLVJHpYz9SBhNi+RnH 3oKVLjvbKbdXvu656FuCK4qQuM+6xdGqjkeGP9RFbqVXvjJTibzh5A/ZkD5N+HguXEXU w8rA== X-Forwarded-Encrypted: i=1; AJvYcCUJDL82s3LPA+VqSxwaoFxzXfvwjT+BsgSc7RXgH4Vuz88Ub3soomJ6rWyZaAiA5yQaHxlP5gIkUSk=@lists.xenproject.org X-Gm-Message-State: AOJu0YzD/9NUMp9UlWqHMgYHIKOdTycpz5+r6JJYSUISFgjtKnbMh13V XcgJJXUpyDcUCyc8C3J0WZzTzT4ZKdfAomibz3ETM1ayCd83T0W1hnTQZI6WhQ== X-Gm-Gg: ASbGnct1mOpA5Yek+z5NQQ4+PIYaW3cL+OBUft7GLAzUfcfSboVaIYlNYmNBAI0onjx UQcvYmsyNiz2FWmeaweZwYvR1ojjK7oBjPetkzp5Q3SOLTjN7euzvZK9+wTntxH7cU9LTZ4H81j cu8Cenl/VJ7MJnMxBS0Vd7KL/juQuYeWK3jTbXK0p+zzTpsu0abY3VnZMg/R4peIOBmx04CGs8O zDJ92EzMgRYoGotZV58KiAhZ67yI8xTD779fJMWl7cZWQzRrd+2VbQ+/ZSEYZFwCYAibMr20NBV ZXaA7uF4t3dqfTjSVjpowWHYyJzwxZZC26HBdhW9BsEuG1+rSIBYumMbE5oRRpzgJJLXU+6J+5F OxjNVFADcSO4CJKQEETCUDpCzwSjAlPciqjxcyNRI X-Google-Smtp-Source: AGHT+IG2FSmY77nmTC2TqlL5UKevRnAzYj1bizHIS6y6fldKVttc0yRi0ZnM8Bp2xFt0soKDBgf/iw== X-Received: by 2002:a05:600c:198d:b0:43c:fdbe:4398 with SMTP id 5b1f17b1804b1-43cfdbe4493mr56614775e9.6.1741684994089; Tue, 11 Mar 2025 02:23:14 -0700 (PDT) Message-ID: Date: Tue, 11 Mar 2025 10:23:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] tools: Mark ACPI SDTs as NVS in the PVH build path To: Alejandro Vallejo Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Anthony PERARD , Juergen Gross , xen-devel@lists.xenproject.org References: <20250310152523.81181-1-alejandro.vallejo@cloud.com> <5f207284-d206-417a-b963-c922119abe33@suse.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11.03.2025 10:17, Alejandro Vallejo wrote: > On Tue Mar 11, 2025 at 8:30 AM GMT, Jan Beulich wrote: >> On 10.03.2025 16:25, Alejandro Vallejo wrote: >>> Commit cefeffc7e583 marked ACPI tables as NVS in the hvmloader path >>> because SeaBIOS may otherwise just mark it as RAM. There is, however, >>> yet another reason to do it even in the PVH path. Xen's incarnation of >>> AML relies on having access to some ACPI tables (e.g: _STA of Processor >>> objects relies on reading the processor online bit in its MADT entry) >>> >>> This is problematic if the OS tries to reclaim ACPI memory for page >>> tables as it's needed for runtime and can't be reclaimed after the OSPM >>> is up and running. >>> >>> Fixes: de6d188a519f("hvmloader: flip "ACPI data" to "ACPI NVS" type for ACPI table region)" >>> Signed-off-by: Alejandro Vallejo >>> --- >>> I really, really, really dislike this idea of accessing the MADT from >>> AML. >> >> I think this isn't Xen's invention, but something I've seen in various >> systems' AML. > > Do you mean ACPI hotplug? I don't think I've ever seen a real system with > support for it. I don't suppose you remember any specifically? I'd be quite > interested to have a look at their ACPI dumps. Well, what I've seen were systems with firmware provisions for hotplug, even if e.g. the electric aspects were missing. There was a time, after all, during which Intel was trying to get OEMs to support this. Jan