From: Michael Straube <straube.linux@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: gregkh@linuxfoundation.org, linux@wolf-entwicklungen.de,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: pi433: add missing call to cdev_del()
Date: Mon, 26 Nov 2018 19:12:07 +0100 [thread overview]
Message-ID: <b3f1023b-1df2-9748-3514-eb601697c725@gmail.com> (raw)
In-Reply-To: <20181126180105.GM2970@unbuntlaptop>
On 11/26/18 7:01 PM, Dan Carpenter wrote:
> On Mon, Nov 26, 2018 at 06:53:55PM +0100, Michael Straube wrote:
>> retval = cdev_add(device->cdev, device->devt, 1);
>> if (retval) {
>> dev_dbg(device->dev, "register of cdev failed");
>> + cdev_del(device->cdev);
>> goto cdev_failed;
>
> No no... That's not the right thing. Do "goto del_cdev;" and add a
> label at the end.
>
> del_cdev:
> cdev_del(device->cdev);
>
> regards,
> dan carpenter
>
Ah ok, I thought about that but was not sure. Thanks,
Michael
prev parent reply other threads:[~2018-11-26 18:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-26 17:53 [PATCH] staging: pi433: add missing call to cdev_del() Michael Straube
2018-11-26 18:01 ` Dan Carpenter
2018-11-26 18:12 ` Michael Straube [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3f1023b-1df2-9748-3514-eb601697c725@gmail.com \
--to=straube.linux@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@wolf-entwicklungen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.