From: Krzysztof Kozlowski <krzk@kernel.org>
To: ot_shunxi.zhang@mediatek.com,
Eddie Huang <eddie.huang@mediatek.com>,
Sean Wang <sean.wang@mediatek.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Lee Jones <lee@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-rtc@vger.kernel.org,
linux-kernel@vger.kernel.org, sirius.wang@mediatek.com,
vince-wl.liu@mediatek.com, jh.hsu@mediatek.com
Subject: Re: [PATCH v1 1/2] mfd: mt6397: Add new bit definitions for RTC_BBPU register
Date: Mon, 11 Aug 2025 13:02:49 +0200 [thread overview]
Message-ID: <b41749ae-640b-4911-976f-8aa36d40ed6b@kernel.org> (raw)
In-Reply-To: <20250811081543.4377-2-ot_shunxi.zhang@mediatek.com>
On 11/08/2025 10:15, ot_shunxi.zhang@mediatek.com wrote:
> From: Shunxi Zhang <ot_shunxi.zhang@mediatek.com>
>
> This patch adds new bit definitions for the RTC_BBPU register in the
Why? There is no user of these. Don't add useless defines.
> mt6397 RTC header file. The following bit definitions are introduced:
Hm?
>
> Signed-off-by: Shunxi Zhang <ot_shunxi.zhang@mediatek.com>
> ---
> include/linux/mfd/mt6397/rtc.h | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/include/linux/mfd/mt6397/rtc.h b/include/linux/mfd/mt6397/rtc.h
> index 27883af44f87..001cef6b7302 100644
> --- a/include/linux/mfd/mt6397/rtc.h
> +++ b/include/linux/mfd/mt6397/rtc.h
> @@ -15,8 +15,11 @@
> #include <linux/rtc.h>
>
> #define RTC_BBPU 0x0000
> +#define RTC_BBPU_PWREN BIT(0)
> +#define RTC_BBPU_CLR BIT(1)
> +#define RTC_BBPU_RESET_AL BIT(3)
> #define RTC_BBPU_CBUSY BIT(6)
> -#define RTC_BBPU_KEY (0x43 << 8)
> +#define RTC_BBPU_KEY (0x43 << 8)
Why?
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-08-11 11:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-11 8:15 [PATCH v1 0/2] rtc: Enhance RTC driver with BBPU bit definitions and shutdown handling ot_shunxi.zhang
2025-08-11 8:15 ` [PATCH v1 1/2] mfd: mt6397: Add new bit definitions for RTC_BBPU register ot_shunxi.zhang
2025-08-11 11:02 ` Krzysztof Kozlowski [this message]
2025-08-11 11:21 ` Giorgi Tchankvetadze
2025-08-19 7:53 ` Shunxi Zhang (章顺喜)
2025-08-19 7:54 ` Shunxi Zhang (章顺喜)
2025-08-19 8:16 ` Krzysztof Kozlowski
2025-08-19 8:32 ` Shunxi Zhang (章顺喜)
2025-08-11 8:15 ` [PATCH v1 2/2] rtc: mt6397: Add BBPU alarm status reset and shutdown handling ot_shunxi.zhang
2025-08-11 13:09 ` Alexandre Belloni
2025-08-19 7:48 ` Shunxi Zhang (章顺喜)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b41749ae-640b-4911-976f-8aa36d40ed6b@kernel.org \
--to=krzk@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=eddie.huang@mediatek.com \
--cc=jh.hsu@mediatek.com \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-rtc@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=ot_shunxi.zhang@mediatek.com \
--cc=sean.wang@mediatek.com \
--cc=sirius.wang@mediatek.com \
--cc=vince-wl.liu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.