From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A0DECC5478C for ; Mon, 26 Feb 2024 08:23:53 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.685302.1065787 (Exim 4.92) (envelope-from ) id 1reWH4-0001XK-PO; Mon, 26 Feb 2024 08:23:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 685302.1065787; Mon, 26 Feb 2024 08:23:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1reWH4-0001XD-Mc; Mon, 26 Feb 2024 08:23:46 +0000 Received: by outflank-mailman (input) for mailman id 685302; Mon, 26 Feb 2024 08:23:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1reWH2-00015c-Vd for xen-devel@lists.xenproject.org; Mon, 26 Feb 2024 08:23:44 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5a338a19-d480-11ee-98f5-efadbce2ee36; Mon, 26 Feb 2024 09:23:43 +0100 (CET) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id A270E4EE0742; Mon, 26 Feb 2024 09:23:42 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5a338a19-d480-11ee-98f5-efadbce2ee36 MIME-Version: 1.0 Date: Mon, 26 Feb 2024 09:23:42 +0100 From: Nicola Vetrini To: Jan Beulich Cc: Stefano Stabellini , xen-devel@lists.xenproject.org, consulting@bugseng.com, Andrew Cooper , George Dunlap , Julien Grall , Wei Liu Subject: Re: [XEN PATCH 1/2] xen/console: drop return value from consoled_guest_rx/tx In-Reply-To: <004877c8-9aea-44b9-aa93-65665b0d3a8d@suse.com> References: <4998ec735bd7e5a50a229507e2b92ae56ec1ba4b.1708680104.git.nicola.vetrini@bugseng.com> <004877c8-9aea-44b9-aa93-65665b0d3a8d@suse.com> Message-ID: X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit On 2024-02-26 09:00, Jan Beulich wrote: > On 23.02.2024 23:56, Stefano Stabellini wrote: >> On Fri, 23 Feb 2024, Nicola Vetrini wrote: >>> These functions never saw a usage of their return value since >>> they were introduced, so it can be dropped since their usages >>> violate MISRA C Rule 17.7: >>> "The value returned by a function having non-void return type shall >>> be used". >>> >>> No functional change. >>> >>> Signed-off-by: Nicola Vetrini >> >> Reviewed-by: Stefano Stabellini > > The cleanup is certainly okay, but would one of you mind clarifying in > how > far this code is relevant for certification? I don't expect there are > plans > to run shim Xen in any projected production uses for which > certification is > relevant? (The subject prefix is also unnecessarily wide here, when > it's > only daemon code which is affected, not console code in general.) > I agree on the subject prefix being too wide. The configuration that uses consoled_guest_tx is #ifdef-ed for x86, so even in configurations that may never reach this condition this is relevant, unless its #ifdef is restricted to cases where the call may actually be reachable. consoled_guest_rx was adjusted for uniformity, even though it's technically not included in the configuration under analysis at the moment. -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com)