From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH 2/2] drm/scheduler: stop setting rq to NULL Date: Thu, 2 Aug 2018 08:42:54 +0200 Message-ID: References: <20180730110352.2657-1-christian.koenig@amd.com> <20180730110352.2657-2-christian.koenig@amd.com> Reply-To: christian.koenig@amd.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4F87D6E2AB for ; Thu, 2 Aug 2018 06:42:57 +0000 (UTC) Received: by mail-wr1-x443.google.com with SMTP id r16-v6so909727wrt.11 for ; Wed, 01 Aug 2018 23:42:57 -0700 (PDT) In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Andrey Grodzovsky , dri-devel@lists.freedesktop.org Cc: nayan26deshmukh@gmail.com List-Id: dri-devel@lists.freedesktop.org QW0gMDIuMDguMjAxOCB1bSAwMDoyNSBzY2hyaWViIEFuZHJleSBHcm9kem92c2t5Ogo+IFRoaW5r aW5nIGFnYWluIGFib3V0IHRoaXMgY2hhbmdlIGFuZCA1M2Q1ZjFlIGRybS9zY2hlZHVsZXI6IG1v dmUgaWRsZSAKPiBlbnRpdGllcyB0byBzY2hlZHVsZXIgd2l0aCBsZXNzIGxvYWQgdjIKPgo+IExv b2tzIHRvIG1lIGxpa2UgdXNlIGNhc2UgZm9yIHdoaWNoIGZjOWE1MzkgZHJtL3NjaGVkdWxlcjog YWRkIE5VTEwgCj4gcG9pbnRlciBjaGVjayBmb3IgcnVuIHF1ZXVlICh2Mikgd2FzIGRvbmUKPgo+ IHdpbGwgbm90IHdvcmsgYW55bW9yZS4KPgo+IEZpcnN0IG9mIGFsbCBpbiBkcm1fc2NoZWRfZW50 aXR5X3B1c2hfam9iLCAnaWYgKCFlbnRpdHktPnJxKScgd2lsbCAKPiBuZXZlciBiZSB0cnVlIGFu eSBtb3JlIHNpbmNlIHdlIHN0b3BwZWQgZW50aXR5LT5ycSB0byBOVUxMIGluCj4KPiBkcm1fc2No ZWRfZW50aXR5X2ZsdXNoLgoKR29vZCBwb2ludCwgZ29pbmcgdG8gcmVtb3ZlIHRoYXQuCgo+Cj4g U2Vjb25kIG9mIGFsbCwgZXZlbiBhZnRlciB3ZSByZW1vdmVkIHRoZSBlbnRpdHkgZnJvbSBycSBp biAKPiBkcm1fc2NoZWRfZW50aXR5X2ZsdXNoIHRvIHRlcm1pbmF0ZSBhbnkgc3Vic2VxdWVudCBz dWJtaXNzaW9ucwo+Cj4gdG8gdGhlIHF1ZXVlIHRoZSBvdGhlciB0aHJlYWQgZG9pbmcgcHVzaCBq b2IgY2FuIGp1c3QgYWNxdWlyZSBhZ2FpbiBhIAo+IHJ1biBxdWV1ZQo+Cj4gZnJvbSBkcm1fc2No ZWRfZW50aXR5X2dldF9mcmVlX3NjaGVkIGFuZCBjb250aW51ZSBzdWJtaXNzaW9uCgpUaGF0IGlz IGFjdHVhbGx5IGRlc2lyZWQuCgpXaGVuIGFub3RoZXIgcHJvY2VzcyBpcyBub3cgdXNpbmcgdGhl IGVudGl0eSB0byBzdWJtaXQgam9icyBhZGRpbmcgaXQgCmJhY2sgdG8gdGhlIHJxIGlzIGFjdHVh bGx5IHRoZSByaWdodCB0aGluZyB0byBkbyBjYXVzZSB0aGUgZW50aXR5IGlzIApzdGlsbCBpbiB1 c2UuCgpDaHJpc3RpYW4uCgo+IHNvIHlvdSBjYW4ndCBzdWJzdGl0dXRlICcgaWYgKCFlbnRpdHkt PnJxKScgdG8gJ2lmIAo+IChsaXN0X2VtcHR5KCZlbnRpdHktPmxpc3QpKScuCj4KPiBXaGF0IGFi b3V0IGFkZGluZyBhICdzdG9wcGVkJyBmbGFnIHRvIGRybV9zY2hlZF9lbnRpdHkgdG8gYmUgc2V0 IGluIAo+IGRybV9zY2hlZF9lbnRpdHlfZmx1c2ggYW5kIGluCj4KPiBkcm1fc2NoZWRfZW50aXR5 X3B1c2hfam9iIGNoZWNrIGZvcsKgICdpZiAoIWVudGl0eS0+c3RvcHBlZCknIGluc3RlYWQgCj4g b2bCoCAnIGlmICghZW50aXR5LT5ycSknID8KPgo+IEFuZHJleQo+Cj4KPiBPbiAwNy8zMC8yMDE4 IDA3OjAzIEFNLCBDaHJpc3RpYW4gS8O2bmlnIHdyb3RlOgo+PiBXZSByZW1vdmVkIHRoZSByZWR1 bmRhbmN5IG9mIGhhdmluZyBhbiBleHRyYSBzY2hlZHVsZXIgZmllbGQsIHNvIHdlCj4+IGNhbid0 IHNldCB0aGUgcnEgdG8gTlVMTCBhbnkgbW9yZSBvciBvdGhlcndpc2Ugd29uJ3Qga25vdyB3aGlj aAo+PiBzY2hlZHVsZXIgdG8gdXNlIGZvciB0aGUgY2xlYW51cC4KPj4KPj4gSnVzdCByZW1vdmUg dGhlIGVudGl0eSBmcm9tIHRoZSBzY2hlZHVsaW5nIGxpc3QgaW5zdGVhZC4KPj4KPj4gU2lnbmVk LW9mZi1ieTogQ2hyaXN0aWFuIEvDtm5pZyA8Y2hyaXN0aWFuLmtvZW5pZ0BhbWQuY29tPgo+PiAt LS0KPj4gwqAgZHJpdmVycy9ncHUvZHJtL3NjaGVkdWxlci9ncHVfc2NoZWR1bGVyLmMgfCAzNSAK Pj4gKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+PiDCoCAxIGZpbGUgY2hhbmdlZCwg OCBpbnNlcnRpb25zKCspLCAyNyBkZWxldGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9zY2hlZHVsZXIvZ3B1X3NjaGVkdWxlci5jIAo+PiBiL2RyaXZlcnMvZ3B1L2Ry bS9zY2hlZHVsZXIvZ3B1X3NjaGVkdWxlci5jCj4+IGluZGV4IGY1NjNlNGZiYjRiNi4uMWI3MzMy MjkyMDFlIDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vc2NoZWR1bGVyL2dwdV9zY2hl ZHVsZXIuYwo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vc2NoZWR1bGVyL2dwdV9zY2hlZHVsZXIu Ywo+PiBAQCAtMTk4LDIxICsxOTgsNiBAQCBpbnQgZHJtX3NjaGVkX2VudGl0eV9pbml0KHN0cnVj dCAKPj4gZHJtX3NjaGVkX2VudGl0eSAqZW50aXR5LAo+PiDCoCB9Cj4+IMKgIEVYUE9SVF9TWU1C T0woZHJtX3NjaGVkX2VudGl0eV9pbml0KTsKPj4gwqAgLS8qKgo+PiAtICogZHJtX3NjaGVkX2Vu dGl0eV9pc19pbml0aWFsaXplZCAtIFF1ZXJ5IGlmIGVudGl0eSBpcyBpbml0aWFsaXplZAo+PiAt ICoKPj4gLSAqIEBzY2hlZDogUG9pbnRlciB0byBzY2hlZHVsZXIgaW5zdGFuY2UKPj4gLSAqIEBl bnRpdHk6IFRoZSBwb2ludGVyIHRvIGEgdmFsaWQgc2NoZWR1bGVyIGVudGl0eQo+PiAtICoKPj4g LSAqIHJldHVybiB0cnVlIGlmIGVudGl0eSBpcyBpbml0aWFsaXplZCwgZmFsc2Ugb3RoZXJ3aXNl Cj4+IC0qLwo+PiAtc3RhdGljIGJvb2wgZHJtX3NjaGVkX2VudGl0eV9pc19pbml0aWFsaXplZChz dHJ1Y3QgZHJtX2dwdV9zY2hlZHVsZXIgCj4+ICpzY2hlZCwKPj4gLcKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgc3RydWN0IGRybV9zY2hlZF9lbnRpdHkgKmVu dGl0eSkKPj4gLXsKPj4gLcKgwqDCoCByZXR1cm4gZW50aXR5LT5ycSAhPSBOVUxMICYmCj4+IC3C oMKgwqDCoMKgwqDCoCBlbnRpdHktPnJxLT5zY2hlZCA9PSBzY2hlZDsKPj4gLX0KPj4gLQo+PiDC oCAvKioKPj4gwqDCoCAqIGRybV9zY2hlZF9lbnRpdHlfaXNfaWRsZSAtIENoZWNrIGlmIGVudGl0 eSBpcyBpZGxlCj4+IMKgwqAgKgo+PiBAQCAtMjI0LDcgKzIwOSw4IEBAIHN0YXRpYyBib29sIGRy bV9zY2hlZF9lbnRpdHlfaXNfaWRsZShzdHJ1Y3QgCj4+IGRybV9zY2hlZF9lbnRpdHkgKmVudGl0 eSkKPj4gwqAgewo+PiDCoMKgwqDCoMKgIHJtYigpOwo+PiDCoCAtwqDCoMKgIGlmICghZW50aXR5 LT5ycSB8fCBzcHNjX3F1ZXVlX3BlZWsoJmVudGl0eS0+am9iX3F1ZXVlKSA9PSBOVUxMKQo+PiAr wqDCoMKgIGlmIChsaXN0X2VtcHR5KCZlbnRpdHktPmxpc3QpIHx8Cj4+ICvCoMKgwqDCoMKgwqDC oCBzcHNjX3F1ZXVlX3BlZWsoJmVudGl0eS0+am9iX3F1ZXVlKSA9PSBOVUxMKQo+PiDCoMKgwqDC oMKgwqDCoMKgwqAgcmV0dXJuIHRydWU7Cj4+IMKgIMKgwqDCoMKgwqAgcmV0dXJuIGZhbHNlOwo+ PiBAQCAtMjc5LDggKzI2NSw2IEBAIGxvbmcgZHJtX3NjaGVkX2VudGl0eV9mbHVzaChzdHJ1Y3Qg Cj4+IGRybV9zY2hlZF9lbnRpdHkgKmVudGl0eSwgbG9uZyB0aW1lb3V0KQo+PiDCoMKgwqDCoMKg IGxvbmcgcmV0ID0gdGltZW91dDsKPj4gwqAgwqDCoMKgwqDCoCBzY2hlZCA9IGVudGl0eS0+cnEt PnNjaGVkOwo+PiAtwqDCoMKgIGlmICghZHJtX3NjaGVkX2VudGl0eV9pc19pbml0aWFsaXplZChz Y2hlZCwgZW50aXR5KSkKPj4gLcKgwqDCoMKgwqDCoMKgIHJldHVybiByZXQ7Cj4+IMKgwqDCoMKg wqAgLyoqCj4+IMKgwqDCoMKgwqDCoCAqIFRoZSBjbGllbnQgd2lsbCBub3QgcXVldWUgbW9yZSBJ QnMgZHVyaW5nIHRoaXMgZmluaSwgY29uc3VtZSAKPj4gZXhpc3RpbmcKPj4gwqDCoMKgwqDCoMKg ICogcXVldWVkIElCcyBvciBkaXNjYXJkIHRoZW0gb24gU0lHS0lMTAo+PiBAQCAtMjk5LDcgKzI4 Myw3IEBAIGxvbmcgZHJtX3NjaGVkX2VudGl0eV9mbHVzaChzdHJ1Y3QgCj4+IGRybV9zY2hlZF9l bnRpdHkgKmVudGl0eSwgbG9uZyB0aW1lb3V0KQo+PiDCoMKgwqDCoMKgIGxhc3RfdXNlciA9IGNt cHhjaGcoJmVudGl0eS0+bGFzdF91c2VyLCBjdXJyZW50LT5ncm91cF9sZWFkZXIsIAo+PiBOVUxM KTsKPj4gwqDCoMKgwqDCoCBpZiAoKCFsYXN0X3VzZXIgfHwgbGFzdF91c2VyID09IGN1cnJlbnQt Pmdyb3VwX2xlYWRlcikgJiYKPj4gwqDCoMKgwqDCoMKgwqDCoMKgIChjdXJyZW50LT5mbGFncyAm IFBGX0VYSVRJTkcpICYmIChjdXJyZW50LT5leGl0X2NvZGUgPT0gCj4+IFNJR0tJTEwpKQo+PiAt wqDCoMKgwqDCoMKgwqAgZHJtX3NjaGVkX2VudGl0eV9zZXRfcnEoZW50aXR5LCBOVUxMKTsKPj4g K8KgwqDCoMKgwqDCoMKgIGRybV9zY2hlZF9ycV9yZW1vdmVfZW50aXR5KGVudGl0eS0+cnEsIGVu dGl0eSk7Cj4+IMKgIMKgwqDCoMKgwqAgcmV0dXJuIHJldDsKPj4gwqAgfQo+PiBAQCAtMzIwLDcg KzMwNCw3IEBAIHZvaWQgZHJtX3NjaGVkX2VudGl0eV9maW5pKHN0cnVjdCAKPj4gZHJtX3NjaGVk X2VudGl0eSAqZW50aXR5KQo+PiDCoMKgwqDCoMKgIHN0cnVjdCBkcm1fZ3B1X3NjaGVkdWxlciAq c2NoZWQ7Cj4+IMKgIMKgwqDCoMKgwqAgc2NoZWQgPSBlbnRpdHktPnJxLT5zY2hlZDsKPj4gLcKg wqDCoCBkcm1fc2NoZWRfZW50aXR5X3NldF9ycShlbnRpdHksIE5VTEwpOwo+PiArwqDCoMKgIGRy bV9zY2hlZF9ycV9yZW1vdmVfZW50aXR5KGVudGl0eS0+cnEsIGVudGl0eSk7Cj4+IMKgIMKgwqDC oMKgwqAgLyogQ29uc3VtcHRpb24gb2YgZXhpc3RpbmcgSUJzIHdhc24ndCBjb21wbGV0ZWQuIEZv cmNlZnVsbHkKPj4gwqDCoMKgwqDCoMKgICogcmVtb3ZlIHRoZW0gaGVyZS4KPj4gQEAgLTQxNiwx NSArNDAwLDEyIEBAIHZvaWQgZHJtX3NjaGVkX2VudGl0eV9zZXRfcnEoc3RydWN0IAo+PiBkcm1f c2NoZWRfZW50aXR5ICplbnRpdHksCj4+IMKgwqDCoMKgwqAgaWYgKGVudGl0eS0+cnEgPT0gcnEp Cj4+IMKgwqDCoMKgwqDCoMKgwqDCoCByZXR1cm47Cj4+IMKgIC3CoMKgwqAgc3Bpbl9sb2NrKCZl bnRpdHktPnJxX2xvY2spOwo+PiAtCj4+IC3CoMKgwqAgaWYgKGVudGl0eS0+cnEpCj4+IC3CoMKg wqDCoMKgwqDCoCBkcm1fc2NoZWRfcnFfcmVtb3ZlX2VudGl0eShlbnRpdHktPnJxLCBlbnRpdHkp Owo+PiArwqDCoMKgIEJVR19PTighcnEpOwo+PiDCoCArwqDCoMKgIHNwaW5fbG9jaygmZW50aXR5 LT5ycV9sb2NrKTsKPj4gK8KgwqDCoCBkcm1fc2NoZWRfcnFfcmVtb3ZlX2VudGl0eShlbnRpdHkt PnJxLCBlbnRpdHkpOwo+PiDCoMKgwqDCoMKgIGVudGl0eS0+cnEgPSBycTsKPj4gLcKgwqDCoCBp ZiAocnEpCj4+IC3CoMKgwqDCoMKgwqDCoCBkcm1fc2NoZWRfcnFfYWRkX2VudGl0eShycSwgZW50 aXR5KTsKPj4gLQo+PiArwqDCoMKgIGRybV9zY2hlZF9ycV9hZGRfZW50aXR5KHJxLCBlbnRpdHkp Owo+PiDCoMKgwqDCoMKgIHNwaW5fdW5sb2NrKCZlbnRpdHktPnJxX2xvY2spOwo+PiDCoCB9Cj4+ IMKgIEVYUE9SVF9TWU1CT0woZHJtX3NjaGVkX2VudGl0eV9zZXRfcnEpOwo+CgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBs aXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK