From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85192C433DF for ; Thu, 2 Jul 2020 13:39:24 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5076D207CD for ; Thu, 2 Jul 2020 13:39:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JsW0ON7a"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="zgOjKcUt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5076D207CD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Jh5OalagYKis5xzMJ1dNOrPw0Os245Xin3vMXWWRooY=; b=JsW0ON7ahV1auxvRkSLVv6pzv vNjBIbQyzlDNHK//HFzvQDAeFK5ysO6/VUp2Z7wAkTFOsya0BoO+rXchacB3cwv3vG5ETsVLIi31B VEq/tEoOR/SOiYeA0X0oDqKtDB3H9bpr5W9KOzk7nnexsng+QHt6YulJMZfHHVpkWYBjFrpk6OgtC SlDNeIykUlxN+hNYpz+RXuqqaQ7Oxk0IzLKegut78950M6WD7GiYQ/W27bBbYTYtqvD7ZmzejWpqL OJpttuJWnkXA5W/iFQUdYkInYpS72tXuRAF7UZTjagSLSpNCFfcwCJjAjc8X0UdxzPpHNu5YY11F5 sQ5Mc7YHQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqzPd-0007Hl-2d; Thu, 02 Jul 2020 13:38:01 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqzPb-0007HI-2P for linux-arm-kernel@lists.infradead.org; Thu, 02 Jul 2020 13:37:59 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 241AB207CD; Thu, 2 Jul 2020 13:37:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593697078; bh=hduG8RcoB6Y0lE+3g7jHFto84R1rHz9MylAR+LshBOc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=zgOjKcUtHepkmiGPnnMypO3ZHYmIPQwOSjfm2PlTGeeBxzYdF06w0SutUeXmu87aB LNh8CcC9Yy/K94gU0rOqthG9sGlweSt6OvULqUmhJXQMYow3JnlkPcSiYTjgrTOUTC engaWLbImiQRSPFea/6wJBYoWUqhREYrcQpe3ryY= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jqzPY-008Px1-NH; Thu, 02 Jul 2020 14:37:56 +0100 MIME-Version: 1.0 Date: Thu, 02 Jul 2020 14:37:56 +0100 From: Marc Zyngier To: Valentin Schneider Subject: Re: [PATCH v2 14/17] arm64: Kill __smp_cross_call and co In-Reply-To: References: <20200624195811.435857-1-maz@kernel.org> <20200624195811.435857-15-maz@kernel.org> User-Agent: Roundcube Webmail/1.4.5 Message-ID: X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: valentin.schneider@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, will@kernel.org, catalin.marinas@arm.com, linux@arm.linux.org.uk, tglx@linutronix.de, jason@lakedaemon.net, sumit.garg@linaro.org, f.fainelli@gmail.com, gregory.clement@bootlin.com, andrew@lunn.ch, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200702_093759_179916_18BF9DA0 X-CRM114-Status: GOOD ( 11.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sumit Garg , Florian Fainelli , Russell King , Jason Cooper , kernel-team@android.com, Andrew Lunn , Catalin Marinas , Gregory Clement , linux-kernel@vger.kernel.org, Thomas Gleixner , Will Deacon , linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2020-06-25 19:25, Valentin Schneider wrote: > On 24/06/20 20:58, Marc Zyngier wrote: >> @@ -852,8 +841,7 @@ void arch_send_wakeup_ipi_mask(const struct >> cpumask *mask) >> #ifdef CONFIG_IRQ_WORK >> void arch_irq_work_raise(void) >> { >> - if (__smp_cross_call) >> - smp_cross_call(cpumask_of(smp_processor_id()), IPI_IRQ_WORK); >> + smp_cross_call(cpumask_of(smp_processor_id()), IPI_IRQ_WORK); > > AIU the following commit: > > eb631bb5bf5b ("arm64: Support arch_irq_work_raise() via self IPIs") > > It seems arm64 hasn't needed that check since > > 4b3dc9679cf7 ("arm64: force CONFIG_SMP=y and remove redundant > #ifdefs") > > Did I get that right? Indeed. SMP implies being able to IPI, and thus the check has been irrelevant for some time now. Thanks, M. -- Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67722C433DF for ; Thu, 2 Jul 2020 13:38:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 354052088E for ; Thu, 2 Jul 2020 13:38:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593697080; bh=hduG8RcoB6Y0lE+3g7jHFto84R1rHz9MylAR+LshBOc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=YZR1cj5GmszcP/8t8n4kQlenPHJLDamtxD6Wmvi944AO2zKsL95VnLztALrw8EpYM 5bGOcsig20463WMYgp08Zu68yijt+2LSnrU/bF9r9Gobdh/OxHdqyU+ImlWwIYX3mP PuZPJWnfWV2oknDzRkYXsrm2NJ04CFmFxFEKWclc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729420AbgGBNh7 (ORCPT ); Thu, 2 Jul 2020 09:37:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:35880 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729115AbgGBNh6 (ORCPT ); Thu, 2 Jul 2020 09:37:58 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 241AB207CD; Thu, 2 Jul 2020 13:37:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593697078; bh=hduG8RcoB6Y0lE+3g7jHFto84R1rHz9MylAR+LshBOc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=zgOjKcUtHepkmiGPnnMypO3ZHYmIPQwOSjfm2PlTGeeBxzYdF06w0SutUeXmu87aB LNh8CcC9Yy/K94gU0rOqthG9sGlweSt6OvULqUmhJXQMYow3JnlkPcSiYTjgrTOUTC engaWLbImiQRSPFea/6wJBYoWUqhREYrcQpe3ryY= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jqzPY-008Px1-NH; Thu, 02 Jul 2020 14:37:56 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 02 Jul 2020 14:37:56 +0100 From: Marc Zyngier To: Valentin Schneider Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Will Deacon , Catalin Marinas , Russell King , Thomas Gleixner , Jason Cooper , Sumit Garg , Florian Fainelli , Gregory Clement , Andrew Lunn , kernel-team@android.com Subject: Re: [PATCH v2 14/17] arm64: Kill __smp_cross_call and co In-Reply-To: References: <20200624195811.435857-1-maz@kernel.org> <20200624195811.435857-15-maz@kernel.org> User-Agent: Roundcube Webmail/1.4.5 Message-ID: X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: valentin.schneider@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, will@kernel.org, catalin.marinas@arm.com, linux@arm.linux.org.uk, tglx@linutronix.de, jason@lakedaemon.net, sumit.garg@linaro.org, f.fainelli@gmail.com, gregory.clement@bootlin.com, andrew@lunn.ch, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-06-25 19:25, Valentin Schneider wrote: > On 24/06/20 20:58, Marc Zyngier wrote: >> @@ -852,8 +841,7 @@ void arch_send_wakeup_ipi_mask(const struct >> cpumask *mask) >> #ifdef CONFIG_IRQ_WORK >> void arch_irq_work_raise(void) >> { >> - if (__smp_cross_call) >> - smp_cross_call(cpumask_of(smp_processor_id()), IPI_IRQ_WORK); >> + smp_cross_call(cpumask_of(smp_processor_id()), IPI_IRQ_WORK); > > AIU the following commit: > > eb631bb5bf5b ("arm64: Support arch_irq_work_raise() via self IPIs") > > It seems arm64 hasn't needed that check since > > 4b3dc9679cf7 ("arm64: force CONFIG_SMP=y and remove redundant > #ifdefs") > > Did I get that right? Indeed. SMP implies being able to IPI, and thus the check has been irrelevant for some time now. Thanks, M. -- Jazz is not dead. It just smells funny...