From: Sven Peter <sven@kernel.org>
To: Laxman Acharya Padhya <acharyalaxman8848@gmail.com>,
Janne Grunau <j@jannau.net>
Cc: Neal Gompa <neal@gompa.dev>, Arnd Bergmann <arnd@arndb.de>,
asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/4] soc: apple: rtkit: harden syslog shared-buffer handling
Date: Mon, 24 Aug 2026 10:55:07 +0200 [thread overview]
Message-ID: <b43ceb22-20c5-4930-a070-2f8199e304f2@kernel.org> (raw)
In-Reply-To: <cover.1787559303.git.acharyalaxman8848@gmail.com>
On 8/24/26 10:26, Laxman Acharya Padhya wrote:
> Split the syslog hardening into focused changes as requested. The first
> patch fixes the SYSLOG_INIT reinitialization leak. The second prevents
> zero-sized messages and out-of-bounds shared-memory copies. The third
> corrects the entry-count boundary, and the fourth rate limits validation
> warnings controlled by the coprocessor.
>
> The index-boundary change has not been tested on Apple hardware running
> Linux. Asahi m1n1 describes the initialization field as COUNT, consistent
> with the kernel's syslog_n_entries name, but patch 3 is kept independent so
> it can be reverted without removing the shared-memory bounds protection.
>
> Testing:
> - arm64 GCC build of drivers/soc/apple/rtkit.o with W=1 in Docker
> - scripts/checkpatch.pl --strict on each patch
How was this found? If it was AI assisted please also add the
appropriate Assisted-by: tags.
I'd also like a Tested-by from someone before I pick this up then to
make sure you didn't break anything.
Sven
prev parent reply other threads:[~2026-08-24 8:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-24 8:26 [PATCH v2 0/4] soc: apple: rtkit: harden syslog shared-buffer handling Laxman Acharya Padhya
2026-08-24 8:26 ` [PATCH v2 1/4] soc: apple: rtkit: free syslog buffer before reinitializing Laxman Acharya Padhya
2026-08-24 8:26 ` [PATCH v2 2/4] soc: apple: rtkit: bound syslog copies to the shared buffer Laxman Acharya Padhya
2026-08-24 8:26 ` [PATCH v2 3/4] soc: apple: rtkit: reject syslog indices outside the entry count Laxman Acharya Padhya
2026-08-24 8:26 ` [PATCH v2 4/4] soc: apple: rtkit: rate limit malformed syslog warnings Laxman Acharya Padhya
2026-08-24 8:55 ` Sven Peter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b43ceb22-20c5-4930-a070-2f8199e304f2@kernel.org \
--to=sven@kernel.org \
--cc=acharyalaxman8848@gmail.com \
--cc=arnd@arndb.de \
--cc=asahi@lists.linux.dev \
--cc=j@jannau.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neal@gompa.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.