All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Scally <dan.scally@ideasonboard.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>, linux-media@vger.kernel.org
Cc: antti.laakso@intel.com, Lixu Zhang <lixu.zhang@intel.com>,
	Miguel Vadillo <miguel.vadillo@intel.com>,
	Hans de Goede <hansg@kernel.org>,
	"Sapre, Sarang" <sarang.sapre@intel.com>
Subject: Re: [PATCH v2 3/3] media: ivsc: Use ipu_bridge_get_ipu6()
Date: Wed, 9 Sep 2026 15:24:44 +0100	[thread overview]
Message-ID: <b447495c-3635-49d3-a5d2-34396cbf4fcd@ideasonboard.com> (raw)
In-Reply-To: <20260909081953.3089179-4-sakari.ailus@linux.intel.com>

Hi sakari

On 09/09/2026 09:19, Sakari Ailus wrote:
> Instead of going through the PCI device ID table, use
> ipu_bridge_get_ipu6() to obtain a pointer to the IPU PCI device.
> 
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---

Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>
>   drivers/media/pci/intel/ivsc/mei_csi.c | 7 +------
>   1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/media/pci/intel/ivsc/mei_csi.c b/drivers/media/pci/intel/ivsc/mei_csi.c
> index c2917e156345..d4256415a829 100644
> --- a/drivers/media/pci/intel/ivsc/mei_csi.c
> +++ b/drivers/media/pci/intel/ivsc/mei_csi.c
> @@ -27,7 +27,6 @@
>   #include <linux/workqueue.h>
>   
>   #include <media/ipu-bridge.h>
> -#include <media/ipu6-pci-table.h>
>   #include <media/v4l2-async.h>
>   #include <media/v4l2-ctrls.h>
>   #include <media/v4l2-fwnode.h>
> @@ -644,13 +643,9 @@ static int mei_csi_probe(struct mei_cl_device *cldev,
>   	struct device *dev = &cldev->dev;
>   	struct pci_dev *ipu;
>   	struct mei_csi *csi;
> -	unsigned int i;
>   	int ret;
>   
> -	for (i = 0, ipu = NULL; !ipu && ipu6_pci_tbl[i].vendor; i++)
> -		ipu = pci_get_device(ipu6_pci_tbl[i].vendor,
> -				     ipu6_pci_tbl[i].device, NULL);
> -
> +	ipu = ipu_bridge_get_ipu6();
>   	if (!ipu)
>   		return -ENODEV;
>   


      parent reply	other threads:[~2026-09-09 14:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-09  8:19 [PATCH 0/3] Rework IPU6 PCI table Sakari Ailus
2026-09-09  8:19 ` [PATCH v2 1/3] media: ipu-bridge: Add ipu_bridge_get_ipu6() Sakari Ailus
2026-09-09  9:18   ` Antti Laakso
2026-09-09 14:24   ` Dan Scally
2026-09-09  8:19 ` [PATCH v2 2/3] media: cvs: Use ipu_bridge_get_ipu6() Sakari Ailus
2026-09-09  9:19   ` Antti Laakso
2026-09-09 14:24   ` Dan Scally
2026-09-09  8:19 ` [PATCH v2 3/3] media: ivsc: " Sakari Ailus
2026-09-09  9:20   ` Antti Laakso
2026-09-09 14:24   ` Dan Scally [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b447495c-3635-49d3-a5d2-34396cbf4fcd@ideasonboard.com \
    --to=dan.scally@ideasonboard.com \
    --cc=antti.laakso@intel.com \
    --cc=hansg@kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=lixu.zhang@intel.com \
    --cc=miguel.vadillo@intel.com \
    --cc=sakari.ailus@linux.intel.com \
    --cc=sarang.sapre@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.