From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E412BC71153 for ; Mon, 28 Aug 2023 15:35:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231258AbjH1Pew (ORCPT ); Mon, 28 Aug 2023 11:34:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36870 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231494AbjH1Pes (ORCPT ); Mon, 28 Aug 2023 11:34:48 -0400 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D1D92102 for ; Mon, 28 Aug 2023 08:34:45 -0700 (PDT) Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-31c8321c48fso1674264f8f.1 for ; Mon, 28 Aug 2023 08:34:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693236884; x=1693841684; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ONKM10Wmc3NrfrZ+9H0DuQyG8/OjRH71zbSgD3QHX3k=; b=kcUS+UEHkA3KajEFjsPuuj7eleSPye8oZm9O+fA7GNfU/eG20PDEQHEWNiu9apYeEI Hdj3QqOPaIQXQQ26TyfmGRV9wAXCPbmO/OvfezX/HQhM7FhqSRkQyXL5pYPnq8hP21Js 4DZAbcs986ghZqYr5OtcIb2/7wj65fAZkDEN8TPKd3yusx0BsY+7tFmUam6Dle1xk+56 qIO8u1NI5U06W4kbW9oIzhbGVpFxTgRcztudRD1mFY+L0du39ZbQc2qIbfiy+w4GlNU9 IZxrw2+iNKexGtKbT3oYW30dngZMU1n6OwlNXSc49PJ273U3NyFGF373RYzVSZDrJSZn dEXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693236884; x=1693841684; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ONKM10Wmc3NrfrZ+9H0DuQyG8/OjRH71zbSgD3QHX3k=; b=IILIfGYKC8LHpwRIrgIVeQ6+v+DWHJYJrRtkEIhAhjMerQaSgjXqL6Sev9xKz6cO+u 3NP3263kkGZPpkZAcxgBG71MX2uT7uHcbqP/HLHF2+4LUAbeMdyqiQoUhbyMqneQqiJ6 rak22NE14j3t5paNqrJPT4fVrjosC1ndsEExxGQgramwdlIyR5cpuIkWE2bTd/1CwX+W LCnzQgM2cEn8ycvKv1vq6gJatZJnw9BATIdgeweGmhSbW7N3Du+D8P67RKv8f35rDo1t Wdki7bYSpc71ZLBxAM1BKAcwkNqXDun9MQ+0wt0d1TIuORaWBYfa58bpZ4F9jhCx5Ag7 rrNg== X-Gm-Message-State: AOJu0YwA/S6Yc0+hzUvJZ3T2thM8DcxdPPQO/igA0QVRcEfHCNutRht/ 5TPKrj7EGseh9tVo0uPzyw6JUg== X-Google-Smtp-Source: AGHT+IH06t7aqZTIv+J+ouKvEaxICnWCrVM2DQhFTEFAypp/UEMw7EcorLIgH59N6d9pBifiywVpGw== X-Received: by 2002:adf:e849:0:b0:317:a499:72c8 with SMTP id d9-20020adfe849000000b00317a49972c8mr17274656wrn.1.1693236884282; Mon, 28 Aug 2023 08:34:44 -0700 (PDT) Received: from [192.168.0.162] (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id 12-20020a05600c028c00b003feef5b0bb7sm11120746wmk.40.2023.08.28.08.34.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Aug 2023 08:34:43 -0700 (PDT) Message-ID: Date: Mon, 28 Aug 2023 16:34:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v3 15/15] media: qcom: camss: Comment CSID dt_id field Content-Language: en-US To: Konrad Dybcio , rfoss@kernel.org, todor.too@gmail.com, agross@kernel.org, andersson@kernel.org, mchehab@kernel.org, hverkuil-cisco@xs4all.nl, laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com, andrey.konovalov@linaro.org Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230823104444.1954663-1-bryan.odonoghue@linaro.org> <20230823104444.1954663-16-bryan.odonoghue@linaro.org> <4929aa72-a134-4eeb-850e-46d9255c011b@linaro.org> From: Bryan O'Donoghue In-Reply-To: <4929aa72-a134-4eeb-850e-46d9255c011b@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 26/08/2023 11:18, Konrad Dybcio wrote: >> + /* >> + * A value caled 'CID' gets generated internal to CAMSS logic >> + * which is a concatenation of [vc:6 | dt_id:2] hence we reuse >> + * the least significant two bits of the VC to 'stuff' the CID value. >> + */ >> u8 dt_id = vc; > And where are you discarding the non-2-lsb? At the assignment of dt_id vc:6 dt_id:2 => cid:8 = [vc:6 | dt_id:2] vc == 00110110 cid = [110110 | 10] I have no more information what CID is or how the bitfield is populated than I have already indicated in the comment/commit log. --- bod