Re: [PATCH v14 2/8] mtd: spi-nor: core: Shrink the storage size of the flash_info's addr_nbytes

From: <Tudor.Ambarus@microchip.com>
To: <tkuw584924@gmail.com>, <p.yadav@ti.com>, <michael@walle.cc>
Cc: <miquel.raynal@bootlin.com>, <richard@nod.at>,
	<Bacem.Daassi@infineon.com>, <Takahiro.Kuwano@infineon.com>,
	<linux-mtd@lists.infradead.org>
Subject: Re: [PATCH v14 2/8] mtd: spi-nor: core: Shrink the storage size of the flash_info's addr_nbytes
Date: Tue, 3 May 2022 08:27:53 +0000	[thread overview]
Message-ID: <b45a7071-ebe8-d910-32ad-bb5148a683ff@microchip.com> (raw)
In-Reply-To: <20220503081627.341870-3-tudor.ambarus@microchip.com>

On 5/3/22 11:16, Tudor Ambarus wrote:
> The maximum number of address bytes in SPI NOR is 4. Shrink the storage
> size of the flash_info's addr_nbytes.
> 
> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
> ---
>  drivers/mtd/spi-nor/core.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/spi-nor/core.h b/drivers/mtd/spi-nor/core.h
> index 5fc3d4a8add1..fe7683fe1b4d 100644
> --- a/drivers/mtd/spi-nor/core.h
> +++ b/drivers/mtd/spi-nor/core.h
> @@ -493,7 +493,7 @@ struct flash_info {
>  	unsigned sector_size;
>  	u16 n_sectors;
>  	u16 page_size;
> -	u16 addr_nbytes;
> +	u8 addr_nbytes;

I think we can remove the nor->info->addr_nbytes entirely if we choose
to add late_init hooks instead for those couple of flashes that use it.
This will shrink the size for the big array of patches that we have.
Opinions?

Thanks,
ta
>  
>  	bool parse_sfdp;
>  	u16 flags;

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/