Re: [PATCH] scsi: sd: Set a default optimal IO size if one is not defined

[Damien Le Moal <dlemoal@kernel.org>]

On 6/11/25 19:23, Johannes Thumshirn wrote:
> On 11.06.25 09:43, Damien Le Moal wrote:
>> +	if (!lim->io_opt) {
>> +		lim->io_opt = ALIGN_DOWN(lim->max_sectors << SECTOR_SHIFT,
>> +					 sdkp->physical_block_size - 1);
>> +		sd_first_printk(KERN_WARNING, sdkp,
>> +			"Using default optimal transfer size of %u bytes\n",
>> +			lim->io_opt);
> 
> Is warning really a good logging level here? There now will be a warning 
> for every ATA device in the system.
> 
> I'd lower it to info.

You are absolutely right. Sending v2.

> 
> Otherwise,
> Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>


-- 
Damien Le Moal
Western Digital Research