All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: marciohenriques84@gmail.com, bitbake-devel@lists.openembedded.org
Cc: Marcio Henriques <marcio.henriques@ctw.bmwgroup.com>
Subject: Re: [bitbake-devel] [PATCH 1/1] bitbake: add BB_GIT_SHALLOW_SKIP_FAST to disable fast shallow mode
Date: Fri, 01 May 2026 10:29:59 +0100	[thread overview]
Message-ID: <b49490a4a2e1cbbbdd8eb84d3c5bb2af57418488.camel@linuxfoundation.org> (raw)
In-Reply-To: <20260430123847.25046-2-marcio.henriques@ctw.bmwgroup.com>

On Thu, 2026-04-30 at 13:38 +0100, Marcio Henriques via lists.openembedded.org wrote:
> In some CI environments, shallow tarballs are preferred as fallback artifacts,
> not as the primary source path.
> 
> Today, enabling shallow mode also enables an initial fast shallow path that may
> avoid creating/using the regular local clone flow in DL_DIR. This can reduce
> the effectiveness of incremental fetches and lead to larger re-downloads.
> 
> Add BB_GIT_SHALLOW_SKIP_FAST as an opt-in switch. When set to 1, the fetcher
> skips the fast shallow path from initialization and proceeds with the regular
> clone/update flow, while still allowing shallow behavior and tarball fallback.
> 
> Default behavior is preserved when the variable is unset.
> 
> Signed-off-by: Marcio Henriques <marcio.henriques@ctw.bmwgroup.com>
> ---
>  .../bitbake-user-manual-ref-variables.rst     | 19 +++++++++++++++++++
>  lib/bb/fetch2/git.py                          |  4 +++-
>  2 files changed, 22 insertions(+), 1 deletion(-)

I'm wondering why you wouldn't just turn off shallow clones in this
scenario?

I'm also conscious of not wanting to add too many options to the
fetcher, it makes the code more of a labyrinth and harder to
test/maintain. Would it make sense to use BB_GENERATE_MIRROR_TARBALLS
here to change behaviour?

That option is usually set for people wanting to build source
mirrors...


Cheers,

Richard


  parent reply	other threads:[~2026-05-01  9:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-30 12:38 [PATCH 0/1] Subject: [RFC PATCH] bitbake: fetch2/git: add switch to disable fast shallow path Marcio Henriques
2026-04-30 12:38 ` [PATCH 1/1] bitbake: add BB_GIT_SHALLOW_SKIP_FAST to disable fast shallow mode Marcio Henriques
2026-04-30 15:22   ` [bitbake-devel] " Antonin Godard
2026-05-01  9:29   ` Richard Purdie [this message]
2026-05-05  8:08     ` Marcio Henriques
2026-05-05  9:41       ` [bitbake-devel] " Richard Purdie
2026-05-11 16:14         ` Marcio Henriques
2026-05-12  8:15           ` [bitbake-devel] " Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b49490a4a2e1cbbbdd8eb84d3c5bb2af57418488.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=bitbake-devel@lists.openembedded.org \
    --cc=marcio.henriques@ctw.bmwgroup.com \
    --cc=marciohenriques84@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.