All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Singh, Gaurav K" <gaurav.k.singh@intel.com>
To: "Pandiyan, Dhinakaran" <dhinakaran.pandiyan@intel.com>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm: i915: Fix audio issue on BXT
Date: Thu, 5 Apr 2018 13:52:01 +0530	[thread overview]
Message-ID: <b49ed381-588d-086e-3e5e-020014c8f6bb@intel.com> (raw)
In-Reply-To: <1520275530.18001.4.camel@dk-H97M-D3H>



On 3/5/2018 11:51 PM, Pandiyan, Dhinakaran wrote:
> On Thu, 2018-01-04 at 00:48 +0530, Gaurav K Singh wrote:
>> From: Gaurav Singh <gaurav.k.singh@intel.com>
>>
>> On Apollolake, with stress test warm reboot, audio card
>> was not getting enumerated after reboot. This was a
>> spurious issue happening on Apollolake. HW codec and
>> HD audio controller link was going out of sync for which
>> there was a fix in i915 driver but was not getting invoked
>> for BXT. Extending this fix to BXT as well.
>>
>> Tested on apollolake chromebook by stress test warm reboot
>> with 2500 iterations.
>>
>> Signed-off-by: Gaurav K Singh <gaurav.k.singh@intel.com>
> Might be worth adding
>
> Bspec: 21829
>
> to the commit message.
> Reviewed-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
>
> Please rebase and send this patch to the list to CI it.

Hi DK,
Sure, i have added Bspec index and sent the updated patch.

https://patchwork.freedesktop.org/patch/215067/

With regards,
Gaurav
>
>
>> ---
>>   drivers/gpu/drm/i915/intel_audio.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
>> index f1502a0188eb..c71c04e1c3f6 100644
>> --- a/drivers/gpu/drm/i915/intel_audio.c
>> +++ b/drivers/gpu/drm/i915/intel_audio.c
>> @@ -729,7 +729,7 @@ static void i915_audio_component_codec_wake_override(struct device *kdev,
>>   	struct drm_i915_private *dev_priv = kdev_to_i915(kdev);
>>   	u32 tmp;
>>   
>> -	if (!IS_GEN9_BC(dev_priv))
>> +	if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv))
>>   		return;
>>   
>>   	i915_audio_component_get_power(kdev);

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2018-04-05  8:22 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-03 19:18 [PATCH] drm: i915: Fix audio issue on BXT Gaurav K Singh
2018-01-03 19:47 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-01-03 20:31 ` [PATCH] " Pandiyan, Dhinakaran
2018-01-03 21:18   ` Rodrigo Vivi
     [not found]     ` <FF3DDC77922A8A4BB08A3BC48A1EA8CB8DA78F44@BGSMSX101.gar.corp.intel.com>
2018-01-04  6:23       ` FW: " Sharma, Shashank
2018-01-04 16:43     ` Singh, Gaurav K
2018-01-04 21:59       ` Pandiyan, Dhinakaran
2018-01-09 19:54         ` Runyan, Arthur J
2018-02-27  2:03           ` Pandiyan, Dhinakaran
2018-02-27 16:48             ` Runyan, Arthur J
2018-02-27 16:52               ` Mullah, Abid A
2018-02-27 17:30                 ` Runyan, Arthur J
2018-03-05  6:09                   ` Singh, Gaurav K
2018-03-05  6:43                     ` Mullah, Abid A
2018-03-05  6:48                       ` Singh, Gaurav K
2018-01-03 21:19 ` ✓ Fi.CI.IGT: success for " Patchwork
2018-03-05 18:21 ` [PATCH] " Pandiyan, Dhinakaran
2018-03-09 15:54   ` Gaurav K Singh
2018-04-05  8:17   ` Gaurav K Singh
2018-04-05  8:22   ` Singh, Gaurav K [this message]
2018-04-05 16:42   ` [PATCH] drm/i915: " Gaurav K Singh
2018-04-05 17:58     ` Pandiyan, Dhinakaran
2018-04-06  8:41       ` Jani Nikula
2018-03-09 16:17 ` ✗ Fi.CI.BAT: failure for drm: i915: Fix audio issue on BXT (rev2) Patchwork
2018-04-05  9:18 ` ✓ Fi.CI.BAT: success for drm: i915: Fix audio issue on BXT (rev3) Patchwork
2018-04-05 12:32 ` ✗ Fi.CI.IGT: warning " Patchwork
2018-04-06  8:43   ` Jani Nikula
2018-04-05 17:16 ` ✗ Fi.CI.BAT: failure for drm: i915: Fix audio issue on BXT (rev4) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b49ed381-588d-086e-3e5e-020014c8f6bb@intel.com \
    --to=gaurav.k.singh@intel.com \
    --cc=dhinakaran.pandiyan@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.