From: Nikolay Borisov <nborisov@suse.com>
To: fdmanana@gmail.com
Cc: fstests <fstests@vger.kernel.org>,
linux-btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] btrfs: Add test for rename exchange behavior between subvolumes
Date: Mon, 30 Aug 2021 10:18:40 +0300 [thread overview]
Message-ID: <b49f409f-e5cc-6d13-ef6a-2ab25f95d19e@suse.com> (raw)
In-Reply-To: <CAL3q7H57NsQ2WhdsC3=gYftFp_JUKHVxNgCAQuXPwvFzux9CaA@mail.gmail.com>
<snip>
> Finally, this would also be a good opportunity to test regular renames
> with subvolumes too, as we had bugs and regressions in the past like
> in commit 4871c1588f92c6c13f4713a7009f25f217055807 ("Btrfs: use right
> root when checking for hash collision
> "), and never got any test cases for them.
What specific tests do you have in mind? Ordinary renames of files
within a subvolume are already tested by merit of generic geneirc/02[345].
The test in the patch you cited is basically renaming a subvolume within
the same subvolume, that's easy enough.
<snip>
next prev parent reply other threads:[~2021-08-30 7:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-19 13:14 [PATCH] btrfs: Add test for rename exchange behavior between subvolumes Nikolay Borisov
2021-08-23 15:49 ` Filipe Manana
2021-08-30 7:18 ` Nikolay Borisov [this message]
2021-08-30 10:56 ` Filipe Manana
2021-08-30 11:08 ` Nikolay Borisov
2021-08-30 11:11 ` Filipe Manana
2021-08-29 14:04 ` Eryu Guan
2021-08-30 7:10 ` Nikolay Borisov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b49f409f-e5cc-6d13-ef6a-2ab25f95d19e@suse.com \
--to=nborisov@suse.com \
--cc=fdmanana@gmail.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.