Re: [PATCH 3/3] hwsim: handle ADD/DEL_MAC_ADDR events

[Denis Kenzior <denkenz@gmail.com>]

Hi James,

>> +        __atomic_fetch_add(&interface_rec->ref, 1, __ATOMIC_SEQ_CST);
>> +        memcpy(interface_rec->addr, rx, ETH_ALEN);
> 
> Just realized this memcpy is redundant since the interface_rec wouldn't match 
> unless the address was already the same. This case only happens when 
> randomization is off and is a consequence of the kernel having two separate 
> addresses (one prefixed with 0x4, still not sure why they do this). So you get 
> the following events (say the perm address is 02:00:00:00:00:00):
> 
> ADD(tx=42:00:00:00:00:00, rx=02:00:00:00:00:00) (Interface Creation)
> ADD(tx=42:00:00:00:00:00, rx=02:00:00:00:00:00) (Scanning started)
> DEL(tx=42:00:00:00:00:00, rx=02:00:00:00:00:00) (Scanning ended)
> 
> When scan randomization is enabled it will create a completely separate dummy 
> interface and the DEL event can freely delete that.
> 
> I can remove this in v2 if you have additional comments
> 

Ok, I amended the patch to remove the redundant memcpy and applied.  Please 
double check that I didn't screw anything up.

Regards,
-Denis