From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH 2/5] drm/amdgpu: add ring soft recovery v2 Date: Thu, 23 Aug 2018 08:51:25 +0200 Message-ID: References: <20180822100531.52863-1-christian.koenig@amd.com> <20180822100531.52863-2-christian.koenig@amd.com> Reply-To: christian.koenig-5C7GfCeVMHo@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: =?UTF-8?B?TWFyZWsgT2zFocOhaw==?= , Alex Deucher Cc: amd-gfx mailing list QW0gMjIuMDguMjAxOCB1bSAyMTozMiBzY2hyaWViIE1hcmVrIE9sxaHDoWs6Cj4gT24gV2VkLCBB dWcgMjIsIDIwMTggYXQgMTI6NTYgUE0gQWxleCBEZXVjaGVyIDxhbGV4ZGV1Y2hlckBnbWFpbC5j b20+IHdyb3RlOgo+PiBPbiBXZWQsIEF1ZyAyMiwgMjAxOCBhdCA2OjA1IEFNIENocmlzdGlhbiBL w7ZuaWcKPj4gPGNrb2VuaWcubGVpY2h0enVtZXJrZW5AZ21haWwuY29tPiB3cm90ZToKPj4+IElu c3RlYWQgb2YgaGFtbWVyaW5nIGhhcmQgb24gdGhlIEdQVSB0cnkgYSBzb2Z0IHJlY292ZXJ5IGZp cnN0Lgo+Pj4KPj4+IHYyOiByZW9yZGVyIGNvZGUgYSBiaXQKPj4+Cj4+PiBTaWduZWQtb2ZmLWJ5 OiBDaHJpc3RpYW4gS8O2bmlnIDxjaHJpc3RpYW4ua29lbmlnQGFtZC5jb20+Cj4+PiAtLS0KPj4+ ICAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2pvYi5jICB8ICA2ICsrKysrKwo+ Pj4gICBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfcmluZy5jIHwgMjQgKysrKysr KysrKysrKysrKysrKysrKysrCj4+PiAgIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdw dV9yaW5nLmggfCAgNCArKysrCj4+PiAgIDMgZmlsZXMgY2hhbmdlZCwgMzQgaW5zZXJ0aW9ucygr KQo+Pj4KPj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVf am9iLmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfam9iLmMKPj4+IGluZGV4 IDI2NWZmOTBmNGUwMS4uZDkzZTMxYTVjNGU3IDEwMDY0NAo+Pj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2pvYi5jCj4+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1k L2FtZGdwdS9hbWRncHVfam9iLmMKPj4+IEBAIC0zMyw2ICszMywxMiBAQCBzdGF0aWMgdm9pZCBh bWRncHVfam9iX3RpbWVkb3V0KHN0cnVjdCBkcm1fc2NoZWRfam9iICpzX2pvYikKPj4+ICAgICAg ICAgIHN0cnVjdCBhbWRncHVfcmluZyAqcmluZyA9IHRvX2FtZGdwdV9yaW5nKHNfam9iLT5zY2hl ZCk7Cj4+PiAgICAgICAgICBzdHJ1Y3QgYW1kZ3B1X2pvYiAqam9iID0gdG9fYW1kZ3B1X2pvYihz X2pvYik7Cj4+Pgo+Pj4gKyAgICAgICBpZiAoYW1kZ3B1X3Jpbmdfc29mdF9yZWNvdmVyeShyaW5n LCBqb2ItPnZtaWQsIHNfam9iLT5zX2ZlbmNlLT5wYXJlbnQpKSB7Cj4+PiArICAgICAgICAgICAg ICAgRFJNX0VSUk9SKCJyaW5nICVzIHRpbWVvdXQsIGJ1dCBzb2Z0IHJlY292ZXJlZFxuIiwKPj4+ ICsgICAgICAgICAgICAgICAgICAgICAgICAgc19qb2ItPnNjaGVkLT5uYW1lKTsKPj4+ICsgICAg ICAgICAgICAgICByZXR1cm47Cj4+PiArICAgICAgIH0KPj4gSSB0aGluayB3ZSBzaG91bGQgc3Rp bGwgYnViYmxlIHVwIHRoZSBlcnJvciB0byB1c2Vyc3BhY2UgZXZlbiBpZiB3ZQo+PiBjYW4gcmVj b3Zlci4gIERhdGEgaXMgbG9zdCB3aGVuIHRoZSB3YXZlIGlzIGtpbGxlZC4gIFdlIHNob3VsZCB0 cmVhdAo+PiBpdCBsaWtlIGEgR1BVIHJlc2V0Lgo+IFllcywgcGxlYXNlIGluY3JlbWVudCBncHVf cmVzZXRfY291bnRlciwgc28gdGhhdCB3ZSBhcmUgY29tcGxpYW50IHdpdGgKPiBPcGVuR0wuIEJl aW5nIGFibGUgdG8gcmVjb3ZlciBmcm9tIGluZmluaXRlIGxvb3BzIGlzIGdyZWF0LCBidXQgdGVz dAo+IHN1aXRlcyBhbHNvIGV4cGVjdCB0aGlzIHRvIGJlIHByb3Blcmx5IHJlcG9ydGVkIHRvIHVz ZXJzcGFjZSB2aWEgdGhlCj4gcGVyLWNvbnRleHQgcXVlcnkuCgpTdXJlIHRoYXQgc2hvdWxkbid0 IGJlIGEgcHJvYmxlbS4KCj4gQWxzbyBwbGVhc2UgYnVtcCB0aGUgZGVhZGxpbmUgdG8gMSBzZWNv bmQuIEV2ZW4geW91IGlmIHlvdSBraWxsIGFsbAo+IHNoYWRlcnMsIHRoZSBJQiBjYW4gYWxzbyBj b250YWluIENQIERNQSwgd2hpY2ggbWF5IHRha2UgbG9uZ2VyIHRoYW4gMQo+IG1zLgoKSXMgdGhl cmUgYW55IHdheSB3ZSBjYW4gZ2V0IGEgZmVlZGJhY2sgZnJvbSB0aGUgU1EgaWYgdGhlIGtpbGwg d2FzIApzdWNjZXNzZnVsbHk/CgoxIHNlY29uZCBpcyB3YXkgdG8gbG9uZywgc2luY2UgaW4gdGhl IGNhc2Ugb2YgYSBibG9ja2VkIE1DIHdlIG5lZWQgdG8gCnN0YXJ0IHVwIGhhcmQgcmVzZXQgcmVs YXRpdmUgZmFzdC4KClJlZ2FyZHMsCkNocmlzdGlhbi4KCj4KPiBNYXJlawo+Cj4gTWFyZWsKPgo+ PiBBbGV4Cj4+Cj4+PiArCj4+PiAgICAgICAgICBEUk1fRVJST1IoInJpbmcgJXMgdGltZW91dCwg c2lnbmFsZWQgc2VxPSV1LCBlbWl0dGVkIHNlcT0ldVxuIiwKPj4+ICAgICAgICAgICAgICAgICAg ICBqb2ItPmJhc2Uuc2NoZWQtPm5hbWUsIGF0b21pY19yZWFkKCZyaW5nLT5mZW5jZV9kcnYubGFz dF9zZXEpLAo+Pj4gICAgICAgICAgICAgICAgICAgIHJpbmctPmZlbmNlX2Rydi5zeW5jX3NlcSk7 Cj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3Jpbmcu YyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9yaW5nLmMKPj4+IGluZGV4IDVk ZmQyNmJlMWVlYy4uYzA0NWE0ZTM4YWQxIDEwMDY0NAo+Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L2FtZC9hbWRncHUvYW1kZ3B1X3JpbmcuYwo+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9h bWRncHUvYW1kZ3B1X3JpbmcuYwo+Pj4gQEAgLTM4Myw2ICszODMsMzAgQEAgdm9pZCBhbWRncHVf cmluZ19lbWl0X3JlZ193cml0ZV9yZWdfd2FpdF9oZWxwZXIoc3RydWN0IGFtZGdwdV9yaW5nICpy aW5nLAo+Pj4gICAgICAgICAgYW1kZ3B1X3JpbmdfZW1pdF9yZWdfd2FpdChyaW5nLCByZWcxLCBt YXNrLCBtYXNrKTsKPj4+ICAgfQo+Pj4KPj4+ICsvKioKPj4+ICsgKiBhbWRncHVfcmluZ19zb2Z0 X3JlY292ZXJ5IC0gdHJ5IHRvIHNvZnQgcmVjb3ZlciBhIHJpbmcgbG9ja3VwCj4+PiArICoKPj4+ ICsgKiBAcmluZzogcmluZyB0byB0cnkgdGhlIHJlY292ZXJ5IG9uCj4+PiArICogQHZtaWQ6IFZN SUQgd2UgdHJ5IHRvIGdldCBnb2luZyBhZ2Fpbgo+Pj4gKyAqIEBmZW5jZTogdGltZWRvdXQgZmVu Y2UKPj4+ICsgKgo+Pj4gKyAqIFRyaWVzIHRvIGdldCBhIHJpbmcgcHJvY2VlZGluZyBhZ2FpbiB3 aGVuIGl0IGlzIHN0dWNrLgo+Pj4gKyAqLwo+Pj4gK2Jvb2wgYW1kZ3B1X3Jpbmdfc29mdF9yZWNv dmVyeShzdHJ1Y3QgYW1kZ3B1X3JpbmcgKnJpbmcsIHVuc2lnbmVkIGludCB2bWlkLAo+Pj4gKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0cnVjdCBkbWFfZmVuY2UgKmZlbmNlKQo+Pj4g K3sKPj4+ICsgICAgICAga3RpbWVfdCBkZWFkbGluZSA9IGt0aW1lX2FkZF91cyhrdGltZV9nZXQo KSwgMTAwMCk7Cj4+PiArCj4+PiArICAgICAgIGlmICghcmluZy0+ZnVuY3MtPnNvZnRfcmVjb3Zl cnkpCj4+PiArICAgICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwo+Pj4gKwo+Pj4gKyAgICAgICB3 aGlsZSAoIWRtYV9mZW5jZV9pc19zaWduYWxlZChmZW5jZSkgJiYKPj4+ICsgICAgICAgICAgICAg IGt0aW1lX3RvX25zKGt0aW1lX3N1YihkZWFkbGluZSwga3RpbWVfZ2V0KCkpKSA+IDApCj4+PiAr ICAgICAgICAgICAgICAgcmluZy0+ZnVuY3MtPnNvZnRfcmVjb3ZlcnkocmluZywgdm1pZCk7Cj4+ PiArCj4+PiArICAgICAgIHJldHVybiBkbWFfZmVuY2VfaXNfc2lnbmFsZWQoZmVuY2UpOwo+Pj4g K30KPj4+ICsKPj4+ICAgLyoKPj4+ICAgICogRGVidWdmcyBpbmZvCj4+PiAgICAqLwo+Pj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9yaW5nLmggYi9kcml2 ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfcmluZy5oCj4+PiBpbmRleCA0MDlmZGQ5Yjk3 MTAuLjljYzIzOTk2OGU0MCAxMDA2NDQKPj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1k Z3B1L2FtZGdwdV9yaW5nLmgKPj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2Ft ZGdwdV9yaW5nLmgKPj4+IEBAIC0xNjgsNiArMTY4LDggQEAgc3RydWN0IGFtZGdwdV9yaW5nX2Z1 bmNzIHsKPj4+ICAgICAgICAgIC8qIHByaW9yaXR5IGZ1bmN0aW9ucyAqLwo+Pj4gICAgICAgICAg dm9pZCAoKnNldF9wcmlvcml0eSkgKHN0cnVjdCBhbWRncHVfcmluZyAqcmluZywKPj4+ICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBlbnVtIGRybV9zY2hlZF9wcmlvcml0eSBwcmlvcml0 eSk7Cj4+PiArICAgICAgIC8qIFRyeSB0byBzb2Z0IHJlY292ZXIgdGhlIHJpbmcgdG8gbWFrZSB0 aGUgZmVuY2Ugc2lnbmFsICovCj4+PiArICAgICAgIHZvaWQgKCpzb2Z0X3JlY292ZXJ5KShzdHJ1 Y3QgYW1kZ3B1X3JpbmcgKnJpbmcsIHVuc2lnbmVkIHZtaWQpOwo+Pj4gICB9Owo+Pj4KPj4+ICAg c3RydWN0IGFtZGdwdV9yaW5nIHsKPj4+IEBAIC0yNjAsNiArMjYyLDggQEAgdm9pZCBhbWRncHVf cmluZ19maW5pKHN0cnVjdCBhbWRncHVfcmluZyAqcmluZyk7Cj4+PiAgIHZvaWQgYW1kZ3B1X3Jp bmdfZW1pdF9yZWdfd3JpdGVfcmVnX3dhaXRfaGVscGVyKHN0cnVjdCBhbWRncHVfcmluZyAqcmlu ZywKPj4+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1 aW50MzJfdCByZWcwLCB1aW50MzJfdCB2YWwwLAo+Pj4gICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIHVpbnQzMl90IHJlZzEsIHVpbnQzMl90IHZhbDEpOwo+ Pj4gK2Jvb2wgYW1kZ3B1X3Jpbmdfc29mdF9yZWNvdmVyeShzdHJ1Y3QgYW1kZ3B1X3JpbmcgKnJp bmcsIHVuc2lnbmVkIGludCB2bWlkLAo+Pj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IHN0cnVjdCBkbWFfZmVuY2UgKmZlbmNlKTsKPj4+Cj4+PiAgIHN0YXRpYyBpbmxpbmUgdm9pZCBh bWRncHVfcmluZ19jbGVhcl9yaW5nKHN0cnVjdCBhbWRncHVfcmluZyAqcmluZykKPj4+ICAgewo+ Pj4gLS0KPj4+IDIuMTQuMQo+Pj4KPj4+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCj4+PiBhbWQtZ2Z4IG1haWxpbmcgbGlzdAo+Pj4gYW1kLWdmeEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKPj4+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vYW1kLWdmeAo+PiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwo+PiBhbWQtZ2Z4IG1haWxpbmcgbGlzdAo+PiBhbWQtZ2Z4QGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwo+PiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2FtZC1nZngKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmFtZC1nZnggbWFpbGluZyBsaXN0CmFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdmeAo=