From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 429B9C41535 for ; Tue, 19 Dec 2023 13:15:48 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.656798.1025236 (Exim 4.92) (envelope-from ) id 1rFZwe-0002d1-5b; Tue, 19 Dec 2023 13:15:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 656798.1025236; Tue, 19 Dec 2023 13:15:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rFZwe-0002cu-2d; Tue, 19 Dec 2023 13:15:36 +0000 Received: by outflank-mailman (input) for mailman id 656798; Tue, 19 Dec 2023 13:15:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rFZwd-0002co-1t for xen-devel@lists.xenproject.org; Tue, 19 Dec 2023 13:15:35 +0000 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [2a00:1450:4864:20::32c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b03071e4-9e70-11ee-9b0f-b553b5be7939; Tue, 19 Dec 2023 14:15:32 +0100 (CET) Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-40c60dfa5bfso54130505e9.0 for ; Tue, 19 Dec 2023 05:15:32 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id az1-20020a05600c600100b0040b5517ae31sm2843959wmb.6.2023.12.19.05.15.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Dec 2023 05:15:31 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b03071e4-9e70-11ee-9b0f-b553b5be7939 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1702991732; x=1703596532; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:cc:references :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=VBizbzK46ciCCkt/oMCczQc2eIfqrFih45fwnP5KcFI=; b=GPF9/F5B6goxBqVa8W7l8pcBAAaGCmehYUzqiEJQX1bRNOtFkyrVlwh6wE3ZYr1aFN 7cJNLqaQrY5pZ18kzXsOgNyNI8Mh0Ccpo4wdsB1gAwt4669iKibRkbvK/KYFnrC+POPO 3d2MStJWu0hHgdxCe4rayV/mBhwd6t0z5t6kSTUSAHbtD0/TAtGs22cE+PWxBZKjKhIo oL/93sf6h02WENukK6sywMNZul3iqLRH4QcdoQaNEAqbbY8+8ENZdG+f8T5sAhLWb5Mj kxAV5w+VW1T+Dj6uKG/wPXGPRSwfd21RjIWYTh6Kffy0evetdrZxTZYIKjaHI29xP2hq Tn9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702991732; x=1703596532; h=content-transfer-encoding:in-reply-to:autocrypt:from:cc:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VBizbzK46ciCCkt/oMCczQc2eIfqrFih45fwnP5KcFI=; b=ELVe/3LefPQXtTIZnpD2UZRPyKDDP08a39O+ZLA8IgcrDIKPP88mjspZzeiVzSGyUh p3IajN7d0NukAeQi8dxwRcAREDX5+80JvKN7RwbZ2vyMJRn+9BuhJ+w5BNpCNLvI5yAF gd6SWYAa0ZktR1Oe3AL/frihcrP/7hUmJCAR1H1GLIGqZ9rC65/vklwSRwhDKEGINouL teXUNJrky2QfFCbvgZGeRPgs6fjl0qdfOvD6RodeAPkvvEHyi95a+plWFTMJT26gBTq2 AtdbwFltfpxbl1JzephgYB5SqYiR31UOrGaPAfyrJVAuCoC+25OrcyG+dWQ0+DxgUJCM 0L2Q== X-Gm-Message-State: AOJu0Yx8O/Vo3nnf6tcigTtsIYUVD3E22hFE97NvkxZK7oyybA/E8QJD w47btbsj6i5FnGGf6p97NNvlE7pkDZr4cAZqu2Fm X-Google-Smtp-Source: AGHT+IF6FsqEUpNNPfLbYz4cieu46o69QTKx++0RqbOR1ha8XYFEVncPCncBdTnvpvtcg8uNwquchQ== X-Received: by 2002:a05:600c:2147:b0:40c:23ca:1444 with SMTP id v7-20020a05600c214700b0040c23ca1444mr9471818wml.80.1702991732054; Tue, 19 Dec 2023 05:15:32 -0800 (PST) Message-ID: Date: Tue, 19 Dec 2023 14:15:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [BUG]i2c_hid_acpi broken with 4.17.2 on Framework Laptop 13 AMD Content-Language: en-US To: =?UTF-8?Q?S=C3=A9bastien_Chaumat?= References: <7f34d258-97fa-43e8-8d67-ac9dc93213af@suse.com> <52bd8702-cf7d-4f5b-883d-be6214ba31c0@suse.com> <435d159f-96d5-49af-82ec-bce6961e3391@suse.com> <64d738b7-08c1-4b2c-a828-a137c870408e@suse.com> Cc: xen-devel@lists.xenproject.org From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 18.12.2023 17:21, Sébastien Chaumat wrote: >>>>> On 05.12.2023 21:31, Sébastien Chaumat wrote: >>>>>>> [ 2.464598] amd_gpio AMDI0030:00: failed to enable wake-up interrupt >>>>>> >>>>>> Is it expected that IRQ7 goes from fasteoi (kernel 6.6.4 ) to >>>>>> ioapic-edge and IRQ9 to ioapic-level ? >>>>>> >>>>>> IR-IO-APIC 7-fasteoi pinctrl_amd >>>>>> IR-IO-APIC 9-fasteoi acpi >>>>>> >>>>>> to (xen 4.18.0) >>>>>> >>>>>> xen-pirq -ioapic-edge pinctrl_amd >>>>>> xen-pirq -ioapic-level acpi >>>>>> >>>>>> ? >>> > >>> This look similar to >>> https://yhbt.net/lore/all/20201006044941.fdjsp346kc5thyzy@Rk/t/ >>> >>> This issue seems that IRQ 7 (the GPIO controller) is natively fasteoi >>> (so level type) while in xen it is mapped to oapic-edge instead of >>> oapic-level >>> as the SSDT indicates : >>> >>> Device (GPIO) >>> >>> { >>> Name (_HID, "AMDI0030") // _HID: Hardware ID >>> Name (_CID, "AMDI0030") // _CID: Compatible ID >>> Name (_UID, Zero) // _UID: Unique ID >>> Method (_CRS, 0, NotSerialized) // _CRS: Current Resource Settings >>> { >>> Name (RBUF, ResourceTemplate () >>> { >>> Interrupt (ResourceConsumer, Level, ActiveLow, Shared, ,, ) >>> { >>> 0x00000007, >>> } >>> Any idea why ? >> >> Information coming from AML is required to be handed down by Dom0 to Xen. >> May want checking that (a) Dom0 properly does so and (b) Xen doesn't screw >> up in consuming that data. See PHYSDEVOP_setup_gsi. I wonder if this is >> specific to it being IRQ7 which GPIO uses, as at the (master) PIC IRQ7 is >> also the spurious vector. You may want to retry with the tip of the 4.17 >> branch (soon to become 4.17.3) - while it doesn't look very likely to me >> that recent backports there were related, it may still be that they make >> a difference. >> > > testing with 4.17.3: > > Adding some printk in PHYSDEVOP_setup_gsi, I see (in xl dmesg) that > (XEN) PHYSDEVOP_setup_gsi setup_gsi : gsi: 7 triggering: 1 polarity: 1 > > but later on in dmesg I see : > [ 1.747958] xen: registering gsi 7 triggering 0 polarity 1 Linux has exactly one place where this message is logged from, and that's ahead of it calling PHYSDEVOP_setup_gsi. Since you said "later", can you confirm that actually you see two instances of the Xen message and two instances of the Linux one (each of them with respectively matching trigger and polarity values)? Or are we indeed observing what would look to be corruption of a hypercall argument? If there were two calls, it would be important to realize that Xen will respect only the first one. Jan