Re: [OE-core] [wrynose][PATCH] kernel-fit-image.bbclass: Do not include kernel property in DTBO config subnodes

[Marek Vasut <marek.vasut@mailbox.org>]

On 7/30/26 2:39 PM, Yoann Congal wrote:

Hello everyone,

>>> The fitimage fixes landed in oe-core master 6 weeks ago and they fix
>>> fitImage usability issues which block me from updating to wrynose in
>>> multiple projects, that's why I keep monitoring this thread so, but
>>> again, please do not read this as a push.
>>
>> I think going with the four patches from
>> https://lore.kernel.org/all/cover.1784364567.git.yoann.congal@smile.fr/
>> without a fifth patch which adds test coverage for this fairly isolated
>> detail is fine.
> 
> This is where I disagree. Last time I reviewed this series it looked
> good but I had no way to check it actually worked once backported to
> wrynose. That is why I asked Ryan to backport the test from master to
> wrynose.

Is there a git tree/branch with those patches ? If so, I can at least 
test this locally and confirm whether or not anything is broken on my end ?

>> Important is: We need 4 not only 3 patches:
>>
>> Adrian Freihofer (1):
>>    oe-selftest: fitimage: Do not expect kernel property in DTBO config
>>      subnodes
>>
>> Marek Vasut (2):
>>    kernel-fit-image.bbclass: Do not include kernel property in DTBO
>>      config subnodes
>>    kernel-fit-image.bbclass: Fix operation with KERNEL_DTBVENDORED = "1"
>>
>> Ryan Eatmon (1):
>>    kernel-fit-image: Add KERNEL_DTBVENDORED support for
>>      FIT_CONF_DEFAULT_DTB
> 
> Yes. This is the patches I have for this work.
> 
>> And also important is: We need time for testing on master before back-
>> porting to stable. Six weeks is probably enough. But the exact same
>> pattern ended up with a broken stable branch maybe one year ago. And
>> also this time there was a state on master which was at least
>> incomplete (three instead of four patches). But still, I think this is
>> ready for stable now.
> 
> I agree on the series needing testing. One more argument for waiting for
> a wrynose test.
> See https://lore.kernel.org/all/DK3HWGV0JCOP.14DJEFKWLP67L@smile.fr/
> (from the same thread you linked)

I ran this now and got 8 commits which cleanly apply on the wrynose 
branch, maybe that is all that is missing for the test part ?

$ git log --oneline --reverse --grep=fitimage 
origin/wrynose..origin/master -- meta/lib/oeqa/selftest/cases/fitimage.py
e46d8473fb3 oeqa/selftest/fitimage: fix missing whitespace around assignment
0344e652a40 oe-selftest: fitimage: replace _gen_random_file with 
_gen_elf64_dummy
5592be53348 oe-selftest: fitimage: replace bbb-dtbs-as-ext with 
test-dtbs-as-ext
befc103a95d oe-selftest: fitimage: replace MACHINE==qemux86-64 guards 
with KERNEL_SETUP_BIN
4b08cf6048b oe-selftest: fitimage: add machine settings table and skip 
helpers
f17f4263c07 oe-selftest: fitimage: stop hardcoding MACHINE and DISTRO in 
tests
85e0408a81b oe-selftest: fitimage: Do not expect kernel property in DTBO 
config subnodes
de2e11e6362 oe-selftest: fitimage: Add tests for KERNEL_DTBVENDORED

-- 
Best regards,
Marek Vasut