From: Jiri Slaby <jirislaby@kernel.org>
To: Johan Hovold <johan@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v3 1/4] serial: revert guards in uart_wait_modem_status()
Date: Mon, 7 Sep 2026 08:51:26 +0200 [thread overview]
Message-ID: <b504b8a5-8bc3-49f2-a01d-4f24f46f84a0@kernel.org> (raw)
In-Reply-To: <3f33d9f0-65c2-49b7-bb6d-2fe33f0d8fbe@kernel.org>
On 07. 09. 26, 8:47, Jiri Slaby wrote:
> On 07. 09. 26, 8:44, Johan Hovold wrote:
>> Mixing scope-based and regular cleanup is discouraged and
>> uart_port_deref() used by uart_wait_modem_status() falls in the latter
>> category.
>>
>> Revert the premature guard conversion in preparation for fixing a hangup
>> race.
>
> It's not premature. Just convert uart_port_ref() to guards too. Gotos suck.
(Or don't use gotos and I will.)
--
js
suse labs
next prev parent reply other threads:[~2026-09-07 6:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-07 6:44 [PATCH v3 0/4] serial: fix ioctl hangup race Johan Hovold
2026-09-07 6:44 ` [PATCH v3 1/4] serial: revert guards in uart_wait_modem_status() Johan Hovold
2026-09-07 6:47 ` Jiri Slaby
2026-09-07 6:51 ` Jiri Slaby [this message]
2026-09-07 7:37 ` Johan Hovold
2026-09-07 6:51 ` sashiko-bot
2026-09-07 6:44 ` [PATCH v3 2/4] serial: fix ioctl hangup race Johan Hovold
2026-09-07 7:00 ` sashiko-bot
2026-09-07 7:14 ` Johan Hovold
2026-09-07 6:44 ` [PATCH v3 3/4] serial: fix TIOCMIWAIT race Johan Hovold
2026-09-07 6:50 ` sashiko-bot
2026-09-07 6:44 ` [PATCH v3 4/4] serial: abort TIOCMIWAIT on hangup Johan Hovold
2026-09-07 6:51 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b504b8a5-8bc3-49f2-a01d-4f24f46f84a0@kernel.org \
--to=jirislaby@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.