From: Jingbo Xu <jefflexu@linux.alibaba.com>
To: Gao Xiang <hsiangkao@linux.alibaba.com>, linux-erofs@lists.ozlabs.org
Subject: Re: [PATCH v6 2/3] erofs-utils: update on-disk format for xattr name filter
Date: Tue, 29 Aug 2023 22:19:03 +0800 [thread overview]
Message-ID: <b5077ec9-4ade-910d-b204-8c49ece23c5d@linux.alibaba.com> (raw)
In-Reply-To: <de02e15d-5bda-760f-dada-e3c8ca8d3390@linux.alibaba.com>
On 8/29/23 8:49 PM, Gao Xiang wrote:
>
>
> On 2023/8/29 20:41, Jingbo Xu wrote:
>> The xattr name bloom filter feature is going to be introduced to speed
>> up the negative xattr lookup, e.g. system.posix_acl_[access|default]
>> lookup when running "ls -lR" workload.
>
>
> I think you could just say
> "Let's keep in sync with kernel commit <12-char commit id>."
>
> here.
>
> ...
>
>> ---
>
>
> ...
>
>> +#define EROFS_XATTR_NAME_LEN_MAX UCHAR_MAX
>
> where is EROFS_XATTR_NAME_LEN_MAX used?
Indeed it's not used and I can't remember where it's used in the initial
implementation...
I will drop it later.
--
Thanks,
Jingbo
next prev parent reply other threads:[~2023-08-29 14:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-29 12:41 [PATCH v6 0/3] erofs-utils: introduce xattr name bloom filter Jingbo Xu
2023-08-29 12:41 ` [PATCH v6 1/3] erofs-utils: add xxh32 library Jingbo Xu
2023-08-29 12:44 ` Gao Xiang
2023-08-29 14:14 ` Jingbo Xu
2023-08-29 12:41 ` [PATCH v6 2/3] erofs-utils: update on-disk format for xattr name filter Jingbo Xu
2023-08-29 12:49 ` Gao Xiang
2023-08-29 14:19 ` Jingbo Xu [this message]
2023-08-29 12:41 ` [PATCH v6 3/3] erofs-utils: mkfs: enable " Jingbo Xu
2023-08-29 12:53 ` Gao Xiang
2023-08-29 14:20 ` Jingbo Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5077ec9-4ade-910d-b204-8c49ece23c5d@linux.alibaba.com \
--to=jefflexu@linux.alibaba.com \
--cc=hsiangkao@linux.alibaba.com \
--cc=linux-erofs@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.